[Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

Marcel Wiesweg
SVN commit 520824 by mwiesweg:

digikam from trunk:
Port "Superimpose" plugin to DImg

- use our own DImg blending support,
  do not rely on X11 (XRender) pixmaps for alpha blending
  - use DImg::bitBlendImage
  - supports 16 bit
  - is faster
- add an extra class to compute effect
- remove pixmap code from widget, adapt to new class

TODO:
There are now some issues with the size calculation, when you
zoom out too far the template is getting cropped

CCMAIL: [hidden email]


 M  +4 -4      Makefile.am  
 M  +30 -22    imageeffect_superimpose.cpp  
 M  +0 -4      imageeffect_superimpose.h  
 M  +143 -144  superimposewidget.cpp  
 M  +19 -15    superimposewidget.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

Gilles Caulier-2
On Monday 20 March 2006 11:14 pm, Marcel Wiesweg wrote:
> SVN commit 520824 by mwiesweg:
>
> digikam from trunk:
> Port "Superimpose" plugin to DImg
>
> - use our own DImg blending support,
>   do not rely on X11 (XRender) pixmaps for alpha blending

Marcel, the same way need to be done into InsertText plugin. I have used the
same technic (QPixmap) to merge text and target image. This way is wrong with
16 bits images...

Nothing is done into InsertText plugin in my computer. I have works to improve
B&W converter this week end following tips of Daniel Bauer (Pro-photograph
using digikam <http://www.daniel-bauer.com>).

You can fix InsertText plugin like you want.

>   - use DImg::bitBlendImage
>   - supports 16 bit
>   - is faster
> - add an extra class to compute effect
> - remove pixmap code from widget, adapt to new class

is B.K.O file #103695 or #103696 can be closed ?


Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

Gilles Caulier-2
In reply to this post by Marcel Wiesweg
On Monday 20 March 2006 11:14 pm, Marcel Wiesweg wrote:

> SVN commit 520824 by mwiesweg:
>
> digikam from trunk:
> Port "Superimpose" plugin to DImg
>
> - use our own DImg blending support,
>   do not rely on X11 (XRender) pixmaps for alpha blending
>   - use DImg::bitBlendImage
>   - supports 16 bit
>   - is faster
> - add an extra class to compute effect
> - remove pixmap code from widget, adapt to new class
>
> TODO:
> There are now some issues with the size calculation, when you
> zoom out too far the template is getting cropped
>
> CCMAIL: [hidden email]
>
>
>  M  +4 -4      Makefile.am
>  M  +30 -22    imageeffect_superimpose.cpp
>  M  +0 -4      imageeffect_superimpose.h
>  M  +143 -144  superimposewidget.cpp
>  M  +19 -15    superimposewidget.h

Marcel, the plugin cannot be compiled. You have forget to add
superimpose.cpp/.h implementation into svn (:=)...

compiling superimposewidget.cpp (g++)
superimposewidget.cpp:46:25: error: superimpose.h: Aucun fichier ou répertoire
de ce type
superimposewidget.cpp:77: error: 'SuperImpose' was not declared in this scope
superimposewidget.cpp:77: error: expected `;' before 'superimpose'
superimposewidget.cpp:78: error: 'superimpose' was not declared in this scope
superimposewidget.cpp:93: error: 'SuperImpose' was not declared in this scope
superimposewidget.cpp:93: error: expected `;' before 'superimpose'
superimposewidget.cpp:94: error: 'superimpose' was not declared in this scope
*** Exited with status: 2 ***

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

Marcel Wiesweg
In reply to this post by Gilles Caulier-2
> Marcel, the same way need to be done into InsertText plugin. I have used
> the same technic (QPixmap) to merge text and target image. This way is
> wrong with 16 bits images...
>
> Nothing is done into InsertText plugin in my computer. I have works to
> improve B&W converter this week end following tips of Daniel Bauer
> (Pro-photograph using digikam <http://www.daniel-bauer.com>).
>
> You can fix InsertText plugin like you want.
>

Ok, I will do it.

> Marcel, the plugin cannot be compiled. You have forget to add
> superimpose.cpp/.h implementation into svn (:=)...
>
> compiling superimposewidget.cpp (g++)
> superimposewidget.cpp:46:25: error: superimpose.h: Aucun fichier ou
> répertoire de ce type
> superimposewidget.cpp:77: error: 'SuperImpose' was not declared in this
> scope superimposewidget.cpp:77: error: expected `;' before 'superimpose'
> superimposewidget.cpp:78: error: 'superimpose' was not declared in this
> scope superimposewidget.cpp:93: error: 'SuperImpose' was not declared in
> this scope superimposewidget.cpp:93: error: expected `;' before
> 'superimpose' superimposewidget.cpp:94: error: 'superimpose' was not
> declared in this scope *** Exited with status: 2 ***

Now in svn. Sorry, I was tired yesterday...

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikamimageplugins/superimpose

Gilles Caulier-2
Le Mardi 21 Mars 2006 08:11 PM, Marcel Wiesweg a écrit :

> > Marcel, the same way need to be done into InsertText plugin. I have used
> > the same technic (QPixmap) to merge text and target image. This way is
> > wrong with 16 bits images...
> >
> > Nothing is done into InsertText plugin in my computer. I have works to
> > improve B&W converter this week end following tips of Daniel Bauer
> > (Pro-photograph using digikam <http://www.daniel-bauer.com>).
> >
> > You can fix InsertText plugin like you want.
>
> Ok, I will do it.
>
> > Marcel, the plugin cannot be compiled. You have forget to add
> > superimpose.cpp/.h implementation into svn (:=)...
> >
> > compiling superimposewidget.cpp (g++)
> > superimposewidget.cpp:46:25: error: superimpose.h: Aucun fichier ou
> > répertoire de ce type
> > superimposewidget.cpp:77: error: 'SuperImpose' was not declared in this
> > scope superimposewidget.cpp:77: error: expected `;' before 'superimpose'
> > superimposewidget.cpp:78: error: 'superimpose' was not declared in this
> > scope superimposewidget.cpp:93: error: 'SuperImpose' was not declared in
> > this scope superimposewidget.cpp:93: error: expected `;' before
> > 'superimpose' superimposewidget.cpp:94: error: 'superimpose' was not
> > declared in this scope *** Exited with status: 2 ***
>
> Now in svn. Sorry, I was tired yesterday...
>

No problem Marcel. Sometimes, i doing the same error (:=)))

I'm compiling digikam all days. I can detect an error speedly.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel