[Digikam-devel] extragear/graphics/digikam/libs/dimg/loaders

[Marcel Wiesweg]

SVN commit 541269 by mwiesweg:

digikam from trunk:
Use KProcess for RAW image loader.
Loading can now be cleanly aborted.

This is a good example that KProcess is not the perfect tool for use
with our shiny new multithreaded loader because KProcess is not reentrant,
but there are more advantages (wraps all system programming) so that
the necessary main thread indirections are ok.

TODO:
- implement fast loading specified in RAWDecodingSettings
- do we need to parse StdErr?

CCMAIL: [hidden email]



 M  +282 -235  rawloader.cpp  
 M  +46 -5     rawloader.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Lundi 15 Mai 2006 10:53 PM, Marcel Wiesweg a écrit :
> SVN commit 541269 by mwiesweg:
>
> digikam from trunk:
> Use KProcess for RAW image loader.
> Loading can now be cleanly aborted.
>
> This is a good example that KProcess is not the perfect tool for use
> with our shiny new multithreaded loader because KProcess is not reentrant,

Is QProcess with Qt 4.0 will be ?

> but there are more advantages (wraps all system programming) so that
> the necessary main thread indirections are ok.

I don't understand exactly what you mean. Please, Can you explain better ?

>
> TODO:
> - implement fast loading specified in RAWDecodingSettings

ok

> - do we need to parse StdErr?

yes. dcraw return an error message on the console when we trying to get the
embedded ICC color profile into RAW file and if none is found. Look below :

digikam: /home/gilles/Documents/photos/Test
Photograhs/RAW/MINOLTA-DYNAX5D.MRW : RAW file identified
digikam: Cannot load metadata using Exiv2 (This does not look like a TIFF
image)
Found MSB TIFF Header
<IFD> with 14 entries at offset 8
<EXIF> with 33 entries at offset 434
<MAKERNOTE> with 23 entries at offset 1004
digikam: Running dcraw command dcraw -c -4 -w -a -q 0 -p embed -o
'/home/gilles/Documents/ICCPROFILES/WideGamutRGB.icc'
'/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW'
/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW has no
embedded profile.

In fact, i need just a bool flag somewhere to see if an emebeded ICC color
profile have be found in RAW file. I will use this flag in
DImgInterface::slotImageLoaded() method to control better ICC color
management workflow with RAW file into image editor if 'Using Embeded
profile' option is enabled in RAW file decoding settings...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Lundi 15 Mai 2006 10:53 PM, Marcel Wiesweg a écrit :
> SVN commit 541269 by mwiesweg:
>
> digikam from trunk:
> Use KProcess for RAW image loader.
> Loading can now be cleanly aborted.

Here with dcraw 8.08, i can't load RAW files. I have an error message from the
console :

digikam: /home/gilles/Documents/photos/Test Photograhs/RAW/CANON-EOS10.CRW :
RAW file identified
digikam: Running dcraw command (dcraw,-c,-4,-w,-a,-q
0,/home/gilles/Documents/photos/Test Photograhs/RAW/CANON-EOS10.CRW)
digikam: Dcraw StdErr: Non-numeric argument to "-q"

The problem is with -q option (decoding quality - look in RAW file decoding
settings). Normally we need a space between q and a numerical value. For
obscurs reasons, the space between q and 0 isn't correctly interpreted.

Witch dcraw version have you used to test your implementation ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Tuesday 16 May 2006 12:19 am, Caulier Gilles wrote:

> Le Lundi 15 Mai 2006 10:53 PM, Marcel Wiesweg a écrit :
> > SVN commit 541269 by mwiesweg:
> >
> > digikam from trunk:
> > Use KProcess for RAW image loader.
> > Loading can now be cleanly aborted.
>
> Here with dcraw 8.08, i can't load RAW files. I have an error message from
> the console :
>
> digikam: /home/gilles/Documents/photos/Test Photograhs/RAW/CANON-EOS10.CRW
> : RAW file identified
> digikam: Running dcraw command (dcraw,-c,-4,-w,-a,-q
> 0,/home/gilles/Documents/photos/Test Photograhs/RAW/CANON-EOS10.CRW)
> digikam: Dcraw StdErr: Non-numeric argument to "-q"
>
> The problem is with -q option (decoding quality - look in RAW file decoding
> settings). Normally we need a space between q and a numerical value. For
> obscurs reasons, the space between q and 0 isn't correctly interpreted.
>
> Witch dcraw version have you used to test your implementation ?
>
> Gilles

Fixed in svn. Look my comments in svn log...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Monday 15 May 2006 10:53 pm, Marcel Wiesweg wrote:

> SVN commit 541269 by mwiesweg:
>
> digikam from trunk:
> Use KProcess for RAW image loader.
> Loading can now be cleanly aborted.
>
> This is a good example that KProcess is not the perfect tool for use
> with our shiny new multithreaded loader because KProcess is not reentrant,
> but there are more advantages (wraps all system programming) so that
> the necessary main thread indirections are ok.
>
> TODO:
> - implement fast loading specified in RAWDecodingSettings
> - do we need to parse StdErr?
>
> CCMAIL: [hidden email]
>

Marcel,

Loading progress information into Histogram form Color sidebar tab is
broken... Why ?

Note : progress info during loading in image editor work fine.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> >
> > digikam from trunk:
> > Use KProcess for RAW image loader.
> > Loading can now be cleanly aborted.
> >
> > This is a good example that KProcess is not the perfect tool for use
> > with our shiny new multithreaded loader because KProcess is not
> > reentrant,
>
> Is QProcess with Qt 4.0 will be ?

Qt4 QProcess looks much better. One more point to look forward to Qt4.

>
> > but there are more advantages (wraps all system programming) so that
> > the necessary main thread indirections are ok.
>
> I don't understand exactly what you mean. Please, Can you explain better ?

What I meant to say is:
KProcess wraps all low-level system programming. But since it is not
reentrant, we have to send an event to the main thread to start the process
from there.
It is not perfect, but there are more advantages than disadvantages.

>
> > TODO:
> > - implement fast loading specified in RAWDecodingSettings
>
> ok
>
> > - do we need to parse StdErr?
>
> yes. dcraw return an error message on the console when we trying to get the
> embedded ICC color profile into RAW file and if none is found. Look below :
>
> digikam: /home/gilles/Documents/photos/Test
> Photograhs/RAW/MINOLTA-DYNAX5D.MRW : RAW file identified
> digikam: Cannot load metadata using Exiv2 (This does not look like a TIFF
> image)
> Found MSB TIFF Header
> <IFD> with 14 entries at offset 8
> <EXIF> with 33 entries at offset 434
> <MAKERNOTE> with 23 entries at offset 1004
> digikam: Running dcraw command dcraw -c -4 -w -a -q 0 -p embed -o
> '/home/gilles/Documents/ICCPROFILES/WideGamutRGB.icc'
> '/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW'
> /home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW has
> no embedded profile.

Thats strange. Actually, the rawloader is receiving StdErr in
slotReceivedStderr. Is the last line coming from dcraw?

>
> In fact, i need just a bool flag somewhere to see if an emebeded ICC color
> profile have be found in RAW file. I will use this flag in
> DImgInterface::slotImageLoaded() method to control better ICC color
> management workflow with RAW file into image editor if 'Using Embeded
> profile' option is enabled in RAW file decoding settings...

> Loading progress information into Histogram form Color sidebar tab is
> broken... Why ?

For me with current svn version, the color sidebar is disabled as a whole
while the histogram is loading. Is that what you mean? I did not change
anything in that area.

Marcel

>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 16 Mai 2006 10:46 PM, Marcel Wiesweg a écrit :

> > > digikam from trunk:
> > > Use KProcess for RAW image loader.
> > > Loading can now be cleanly aborted.
> > >
> > > This is a good example that KProcess is not the perfect tool for use
> > > with our shiny new multithreaded loader because KProcess is not
> > > reentrant,
> >
> > Is QProcess with Qt 4.0 will be ?
>
> Qt4 QProcess looks much better. One more point to look forward to Qt4.

ok

>
> > > but there are more advantages (wraps all system programming) so that
> > > the necessary main thread indirections are ok.
> >
> > I don't understand exactly what you mean. Please, Can you explain better
> > ?
>
> What I meant to say is:
> KProcess wraps all low-level system programming. But since it is not
> reentrant, we have to send an event to the main thread to start the process
> from there.
> It is not perfect, but there are more advantages than disadvantages.

ok

>
> > > TODO:
> > > - implement fast loading specified in RAWDecodingSettings
> >
> > ok
> >
> > > - do we need to parse StdErr?
> >
> > yes. dcraw return an error message on the console when we trying to get
> > the embedded ICC color profile into RAW file and if none is found. Look
> > below :
> >
> > digikam: /home/gilles/Documents/photos/Test
> > Photograhs/RAW/MINOLTA-DYNAX5D.MRW : RAW file identified
> > digikam: Cannot load metadata using Exiv2 (This does not look like a TIFF
> > image)
> > Found MSB TIFF Header
> > <IFD> with 14 entries at offset 8
> > <EXIF> with 33 entries at offset 434
> > <MAKERNOTE> with 23 entries at offset 1004
> > digikam: Running dcraw command dcraw -c -4 -w -a -q 0 -p embed -o
> > '/home/gilles/Documents/ICCPROFILES/WideGamutRGB.icc'
> > '/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW'
> > /home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW has
> > no embedded profile.
>
> Thats strange. Actually, the rawloader is receiving StdErr in
> slotReceivedStderr. Is the last line coming from dcraw?

yes, but perhaps not from stderr, perhaps stdout.

>
> > In fact, i need just a bool flag somewhere to see if an emebeded ICC
> > color profile have be found in RAW file. I will use this flag in
> > DImgInterface::slotImageLoaded() method to control better ICC color
> > management workflow with RAW file into image editor if 'Using Embeded
> > profile' option is enabled in RAW file decoding settings...
> >
> > Loading progress information into Histogram form Color sidebar tab is
> > broken... Why ?
>
> For me with current svn version, the color sidebar is disabled as a whole
> while the histogram is loading. Is that what you mean?

Yes. Before, the histogram blinked during loading image... why the sidebar is
disable ? I think to have unchanged something in... or... I will chek the
code...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Tuesday 16 May 2006 11:47 pm, Caulier Gilles wrote:

> Le Mardi 16 Mai 2006 10:46 PM, Marcel Wiesweg a écrit :
> > > > digikam from trunk:
> > > > Use KProcess for RAW image loader.
> > > > Loading can now be cleanly aborted.
> > > >
> > > > This is a good example that KProcess is not the perfect tool for use
> > > > with our shiny new multithreaded loader because KProcess is not
> > > > reentrant,
> > >
> > > Is QProcess with Qt 4.0 will be ?
> >
> > Qt4 QProcess looks much better. One more point to look forward to Qt4.
>
> ok
>
> > > > but there are more advantages (wraps all system programming) so that
> > > > the necessary main thread indirections are ok.
> > >
> > > I don't understand exactly what you mean. Please, Can you explain
> > > better ?
> >
> > What I meant to say is:
> > KProcess wraps all low-level system programming. But since it is not
> > reentrant, we have to send an event to the main thread to start the
> > process from there.
> > It is not perfect, but there are more advantages than disadvantages.
>
> ok
>
> > > > TODO:
> > > > - implement fast loading specified in RAWDecodingSettings
> > >
> > > ok
> > >
> > > > - do we need to parse StdErr?
> > >
> > > yes. dcraw return an error message on the console when we trying to get
> > > the embedded ICC color profile into RAW file and if none is found. Look
> > > below :
> > >
> > > digikam: /home/gilles/Documents/photos/Test
> > > Photograhs/RAW/MINOLTA-DYNAX5D.MRW : RAW file identified
> > > digikam: Cannot load metadata using Exiv2 (This does not look like a
> > > TIFF image)
> > > Found MSB TIFF Header
> > > <IFD> with 14 entries at offset 8
> > > <EXIF> with 33 entries at offset 434
> > > <MAKERNOTE> with 23 entries at offset 1004
> > > digikam: Running dcraw command dcraw -c -4 -w -a -q 0 -p embed -o
> > > '/home/gilles/Documents/ICCPROFILES/WideGamutRGB.icc'
> > > '/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW'
> > > /home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW
> > > has no embedded profile.
> >
> > Thats strange. Actually, the rawloader is receiving StdErr in
> > slotReceivedStderr. Is the last line coming from dcraw?
>
> yes, but perhaps not from stderr, perhaps stdout.
>
> > > In fact, i need just a bool flag somewhere to see if an emebeded ICC
> > > color profile have be found in RAW file. I will use this flag in
> > > DImgInterface::slotImageLoaded() method to control better ICC color
> > > management workflow with RAW file into image editor if 'Using Embeded
> > > profile' option is enabled in RAW file decoding settings...
> > >
> > > Loading progress information into Histogram form Color sidebar tab is
> > > broken... Why ?
> >
> > For me with current svn version, the color sidebar is disabled as a whole
> > while the histogram is loading. Is that what you mean?
>
> Yes. Before, the histogram blinked during loading image... why the sidebar
> is disable ? I think to have unchanged something in... or... I will chek
> the code...

yes. My apologies. Fixed now !

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel