[Digikam-devel] [Bug 140303] New: slideshow must be relocated to View menu from tools menu

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         
           Summary: slideshow must be relocated to View menu from tools menu
           Product: digikam
           Version: 0.9.0
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: molecularbiophysics yahoo com


Version:           0.9.0 (using KDE 3.5.5 "release 45" , openSUSE 10.2)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.19-17JAN

I hope everyone will think like "I want to view the slideshow"

Please move it from Tools or make another one in View menu
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From molecularbiophysics yahoo com  2007-01-19 18:41 -------
To make it a bit clear. I am talking about the MAIN digikam window where one has all the different albums.

A better way would be to just have a small icon for slide show next to "Toggle full screen button" (In kuickshow they have a really good icon for slideshow - rest of it digikam rocks).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         
lure kubuntu org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lure kubuntu org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From caulier.gilles kdemail net  2007-02-09 16:36 -------
SVN commit 631948 by cgilles:

digikam from trunk: new Slideshow Tool using Preview feature !

Hi guys, you can slide your RAW files very fast like this !!!

This slide show tool is a simplified version of kipi-plugins SlideShow tool. No effect, no OpenGL. Just the picture slided on the screen.

But the must important feature is to use Image Preview : RAW files can be slided and pictures saved by digiKam image editor will be loaded very fast because we use preview image embeded in IPTC metadata (that the kipi-plugins cannot do it).

This slide show tool run always in fullscreen mode. this have simplified the common EditorWindow class implementation.

This slide show tool is available in Image Editor and Showfoto instead the old one. Added it to Album Gui is not a problem. It's very easy to add the right action on the main window menu.

Luka, If you want to do it before 0.9.1-Beta1, let's go to, and close files #135655, #140303, #140304. thanks in advance...

CCBUGS: 135655, 140303, 140304
BUG: 116518

 M  +1 -0      digikam/Makefile.am  
 M  +2 -0      showfoto/Makefile.am  
 M  +20 -13    showfoto/showfoto.cpp  
 M  +2 -1      showfoto/showfoto.h  
 M  +1 -1      utilities/Makefile.am  
 M  +14 -13    utilities/imageeditor/editor/Makefile.am  
 M  +9 -51     utilities/imageeditor/editor/editorwindow.cpp  
 M  +6 -9      utilities/imageeditor/editor/editorwindow.h  
 M  +2 -0      utilities/imageeditor/editor/editorwindowprivate.h  
 M  +19 -5     utilities/imageeditor/editor/imagewindow.cpp  
 M  +2 -1      utilities/imageeditor/editor/imagewindow.h  
 M  +1 -1      utilities/imageeditor/tools/Makefile.am  
 D             utilities/imageeditor/tools/slideshow.cpp  
 D             utilities/imageeditor/tools/slideshow.h  
 M  +14 -14    utilities/setup/setupslideshow.cpp  
 M  +4 -4      utilities/setup/setupslideshow.h  
 A             utilities/slideshow (directory)  
 A             utilities/slideshow/Makefile.am  
 AM            utilities/slideshow/slideshow.cpp   [License: GPL]
 AM            utilities/slideshow/slideshow.h   [License: GPL]
 AM            utilities/slideshow/toolbar.cpp   [License: GPL]
 AM            utilities/slideshow/toolbar.h   [License: GPL]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From hugelmopf web de  2007-02-09 19:33 -------
Hi Gilles,

this new slideshow is much slower (~5s per 8MP jpg picture) then the kipi-plugins-slideshow, when you run it for the first time one some pictures. If I repeat the slide show with the same pictures, it's fast. Unfortunately, restarting digikam and using the same pictures, it's slow again.
Is that different from what you experience/expect?

Something else:
If we want to also have this in album's "View" menu, we should rename the kipi plugin slideshow in "Tools" menu to something like "Advanced Slideshow", to avoid confusion.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From caulier.gilles kdemail net  2007-02-09 19:46 -------
Frank,

It's slow because the preloading of pictures is not yet enable. Something is missing in source code. I'm wiating than Marcel update the Preview interface on digiKam core.

In fact, your test want mean than the pictures go in a memory cache. This is why is more fast at second pass. When the pre-loading will be done, all will be fine for you (:=))... Note than imlib2 used by kuickshow work like this.

Marcel, please, please, please, give me a preload() method in Preview interface (:=)))...

Also, i'm agree with you. kipi-plugins slideshow need to be renamed like "Advanced Slideshow" or "OpenGl SlideShow"

Angelo, Valerio, please give me your viewpoint ?

Gilles

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         
lure kubuntu org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From lure kubuntu org  2007-02-09 23:03 -------
SVN commit 632071 by lure:

Add Slide Show to View menu and toolbar:
- uses own slideshow implementation (same as Showfoto/Image Editor)
- implemented with preview, so can be also used as full screen preview
- left KIPI-plugin in Tools menu (should be renamed to reduce confusion)

TODO: find good keyboard shortcut to assign to Slide Show function
- all obvious ones are already used: F5 (powerpoint), F12 (kpresenter)

CCBUG: 135655
BUG: 140303, 140304


 M  +1 -0      Makefile.am  
 M  +4 -0      digikamapp.cpp  
 M  +2 -0      digikamappprivate.h  
 M  +4 -1      digikamui.rc  
 M  +30 -0     digikamview.cpp  
 M  +1 -0      digikamview.h  


--- trunk/extragear/graphics/digikam/digikam/Makefile.am #632070:632071
 @ -20,6 +20,7  @
    -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \
    -I$(top_srcdir)/digikam/utilities/splashscreen \
    -I$(top_srcdir)/digikam/utilities/setup \
+   -I$(top_srcdir)/digikam/utilities/slideshow \
    -I$(top_srcdir)/digikam/utilities/batch \
    $(LIBKIPI_CFLAGS) $(GPHOTO_CFLAGS) $(all_includes)
 
--- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #632070:632071
 @ -765,6 +765,10  @
                                          "in full screen mode."));
 #endif
 
+    d->slideShowAction = new KAction(i18n("Slide Show"), "slideshow", 0,
+                                     d->view, SLOT(slotSlideShow()),
+                                     actionCollection(), "slideshow");
+
     d->quitAction = KStdAction::quit(this,
                                    SLOT(slotExit()),
                                    actionCollection(),
--- trunk/extragear/graphics/digikam/digikam/digikamappprivate.h #632070:632071
 @ -99,6 +99,7  @
         thumbSizePlusAction                  = 0;
         thumbSizeMinusAction                 = 0;
         fullScreenAction                     = 0;
+        slideShowAction                      = 0;
         rating0Star                          = 0;
         rating1Star                          = 0;
         rating2Star                          = 0;
 @ -188,6 +189,7  @
 
     // View Actions
     KAction               *fullScreenAction;
+    KAction               *slideShowAction;
     KAction               *thumbSizePlusAction;
     KAction               *thumbSizeMinusAction;
     KSelectAction         *imageSortAction;
--- trunk/extragear/graphics/digikam/digikam/digikamui.rc #632070:632071
 @ -1,5 +1,5  @
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="18" name="digikam" >
+<kpartgui version="19" name="digikam" >
 
  <MenuBar>
 
 @ -60,6 +60,7  @
   <Menu name="View" >
    <text>&amp;View</text>
      <Action name="full_screen" />
+     <Action name="slideshow" />
      <Separator/>
      <Action name="album_thumbSizeIncrease" />
      <Action name="album_thumbSizeDecrease" />
 @ -124,7 +125,9  @
   <Separator/>
   <Action name="album_thumbSizeIncrease" />
   <Action name="album_thumbSizeDecrease" />
+  <Separator/>
   <Action name="full_screen" />
+  <Action name="slideshow" />
  </ToolBar>
  <ActionProperties/>
 
--- trunk/extragear/graphics/digikam/digikam/digikamview.cpp #632070:632071
 @ -59,6 +59,7  @
 #include "albumsettings.h"
 #include "albumhistory.h"
 #include "batchsyncmetadata.h"
+#include "slideshow.h"
 #include "sidebar.h"
 #include "imagepropertiessidebardb.h"
 #include "datefolderview.h"
 @ -895,6 +896,35  @
     d->parent->toggledToPreviewMode(t);
 }
 
+void DigikamView::slotSlideShow()
+{
+    KConfig* config = kapp->config();
+    config->setGroup("ImageViewer Settings");
+    bool startWithCurrent = config->readBoolEntry("SlideShowStartCurrent", false);
+    bool loop             = config->readBoolEntry("SlideShowLoop", false);
+    bool printName        = config->readBoolEntry("SlideShowPrintName", true);
+    int  delay            = config->readNumEntry("SlideShowDelay", 5);
+
+    bool exifRotate = AlbumSettings::instance()->getExifRotate();
+    KURL::List urlList;
+
+    AlbumIconItem* item = 0;
+    if (startWithCurrent)
+        item = dynamic_cast<AlbumIconItem*>(d->iconView->currentItem());
+    else
+        item = dynamic_cast<AlbumIconItem*>(d->iconView->firstItem());
+
+    while (item)
+    {
+        urlList.append(item->imageInfo()->kurl());
+
+        item = dynamic_cast<AlbumIconItem*>(item->nextItem());
+    }
+
+    SlideShow *slide = new SlideShow(urlList, exifRotate, delay*1000, printName, loop);
+    slide->show();
+}
+
 void DigikamView::slotImageEdit()
 {
     AlbumIconItem *currItem = dynamic_cast<AlbumIconItem*>(d->iconView->currentItem());
--- trunk/extragear/graphics/digikam/digikam/digikamview.h #632070:632071
 @ -101,6 +101,7  @
     void slotNewAdvancedSearch();
 
     // Image action slots
+    void slotSlideShow();
     void slotImagePreview();
     void slotImageEdit();
     void slotImageExifOrientation(int orientation);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From caulier.gilles kdemail net  2007-02-11 10:22 -------
Frank,

SlideShow Preview Pre-loading have been commited into svn by Marcel yesterday.

Please checkout svn trunk and try again...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From hugelmopf web de  2007-02-11 14:15 -------
Hi Gilles,

thanks a lot, preloading of the next image works fine, and even slideshow'ing raw files is reasonably fast.

Thanks,
Frank
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=140303         




------- Additional Comments From hugelmopf web de  2007-02-14 22:43 -------
Errrm, not that I want to get on your nerves, but it seems, like one of the recent commits has broken the preloading of next images in slideshow. Now only the second image gets preloaded, and all further images don't. If this is something which you cannot reproduce yourself, please tell me, and I will test further and provide more info (and file a separate bug).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel