------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From caulier.gilles kdemail net 2006-12-15 11:11 ------- (:=)))... Well let's me hear when all will ready to commit on svn... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From anaselli linux it 2006-12-15 11:18 ------- > (:=)))... Well let's me hear when all will ready to commit on svn... Gilles, kipi's already released it ;) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From fabien.ubuntu gmail com 2006-12-15 16:16 ------- I tried it (with checks with and without exiv2) and it works fine. So, I think it's ready and you can commit it... _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 caulier.gilles kdemail net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From caulier.gilles kdemail net 2006-12-15 16:32 ------- SVN commit 613892 by cgilles: digikam from trunk : patch about Exiv2 0.12 version detection from Angelo. BUG: 138616 M +2 -10 configure.in.in M +1 -1 digikam/Makefile.am M +3 -3 kioslave/Makefile.am M +1 -1 showfoto/Makefile.am --- trunk/extragear/graphics/digikam/configure.in.in #613891:613892 @ -215,19 +215,11 @ #------------------------------------------------------------------ have_exiv2='no' -AC_PATH_PROG(EXIV2_CONFIG,exiv2-config) -if test -n "${EXIV2_CONFIG}"; then - EXIV2_CFLAGS="`$EXIV2_CONFIG --cflags`" - AC_SUBST(EXIV2_CFLAGS) - LIB_EXIV2="`$EXIV2_CONFIG --libs`" - AC_SUBST(LIB_EXIV2) - KDE_PKG_CHECK_MODULES(EXIV2, exiv2 >= 0.12, have_exiv2=yes,have_exiv2=no) +if test "$PKGCONFIGFOUND" = "yes" ; then + KDE_PKG_CHECK_MODULES(EXIV2, exiv2 >= 0.12, have_exiv2=yes,have_exiv2=no) fi if test "x$have_exiv2" != "xyes"; then - if test -n "${EXIV2_CONFIG}"; then - AC_MSG_RESULT($have_exiv2) - fi AC_MSG_WARN([Exiv2 library not found, digiKam will not be compiled.]) DO_NOT_COMPILE="digikam digikamimageplugins $DO_NOT_COMPILE" fi --- trunk/extragear/graphics/digikam/digikam/Makefile.am #613891:613892 @ -91,7 +91,7 @ upgradedb_sqlite2tosqlite3.cpp libdigikam_la_LIBADD = $(LIB_KIO) $(LIB_SQLITE3) $(LIB_KABC) \ - $(LIBKIPI_LIBS) $(LIB_KUTILS) $(LIB_EXIV2) \ + $(LIBKIPI_LIBS) $(LIB_KUTILS) $(EXIV2_LIBS) \ $(top_builddir)/digikam/sqlite/libsqlite.la \ $(top_builddir)/digikam/libs/thumbbar/libthumbbar.la \ $(top_builddir)/digikam/libs/themeengine/libthemeengine.la \ --- trunk/extragear/graphics/digikam/kioslave/Makefile.am #613891:613892 @ -21,7 +21,7 @ kio_digikamthumbnail_la_SOURCES = digikamthumbnail.cpp -kio_digikamthumbnail_la_LIBADD = $(LIB_KIO) $(LIBJPEG) $(LIBPNG) $(LIB_EXIV2) \ +kio_digikamthumbnail_la_LIBADD = $(LIB_KIO) $(LIBJPEG) $(LIBPNG) $(EXIV2_LIBS) \ $(top_builddir)/digikam/libs/dimg/libdimg.la kio_digikamthumbnail_la_LDFLAGS = -module -avoid-version $(KDE_PLUGIN) $(all_libraries) @ -30,7 +30,7 @ kio_digikampreview_la_SOURCES = digikampreview.cpp -kio_digikampreview_la_LIBADD = $(LIB_KIO) $(LIB_EXIV2) \ +kio_digikampreview_la_LIBADD = $(LIB_KIO) $(EXIV2_LIBS) \ $(top_builddir)/digikam/libs/dimg/libdimg.la kio_digikampreview_la_LDFLAGS = -module -avoid-version $(KDE_PLUGIN) $(all_libraries) @ -48,7 +48,7 @ kio_digikamalbums_la_SOURCES = digikamalbums.cpp sqlitedb.cpp kio_digikamalbums_la_LIBADD = $(top_builddir)/digikam/libs/jpegutils/libjpegutils.la \ - $(LIB_KIO) $(LIB_SQLITE3) $(LIB_EXIV2) \ + $(LIB_KIO) $(LIB_SQLITE3) $(EXIV2_LIBS) \ $(top_builddir)/digikam/libs/dimg/libdimg.la kio_digikamalbums_la_LDFLAGS = -module -avoid-version $(all_libraries) $(KDE_PLUGIN) --- trunk/extragear/graphics/digikam/showfoto/Makefile.am #613891:613892 @ -32,7 +32,7 @ $(top_builddir)/digikam/utilities/splashscreen/libsplashscreen.la \ $(top_builddir)/digikam/libs/threadimageio/libthreadimageio.la \ $(LIB_QT) $(LIB_KDECORE) $(LIB_KDEUI) $(LIB_KUTILS) \ - $(LIB_KFILE) $(LIB_KPARTS) $(LIBJPEG) $(LIB_EXIV2) + $(LIB_KFILE) $(LIB_KPARTS) $(LIBJPEG) $(EXIV2_LIBS) showfoto_LDFLAGS = $(KDE_RPATH) $(all_libraries) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From marnold ez-net com 2006-12-18 16:53 ------- The error message should be made more clear. I had exiv2 0.11 installed and ./configure kept telling me that I did not have exiv2 installed at all. It should say "Exiv2 library => 0.12 not found". _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 marnold ez-net com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marnold ez-net com _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From anaselli linux it 2006-12-18 21:58 ------- > The error message should be made more clear. I had exiv2 0.11 installed > and ./configure kept telling me that I did not have exiv2 installed > at all. It should say "Exiv2 library => 0.12 not found". Ok I see what you mean, not configure output but the final message, so it should be configure.in.bot Can you check the attached patch please? Created an attachment (id=18971) --> (http://bugs.kde.org/attachment.cgi?id=18971&action=view) configure.in.bot.patch _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From mikmach wp pl 2006-12-18 22:37 ------- Works OK for me. One thought. There is plenty of 0.12 there. Maybe some variable for easier future upgrade? _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
> ------- Additional Comments From mikmach wp pl 2006-12-18 22:37 -------
> Works OK for me. One thought. There is plenty of 0.12 there. Maybe some > variable for easier future upgrade? Yep I thought to it too, but you saw exiv2, there are libkipi, sqlite, libpng,... as well. I believe the problem is due to a missing stable (and working) exiv on most distro by now, maybe next digikam/kipi-plugins release won't be affected by this problem... Angelo P.S. Gilles wake up and commit ;) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel attachment0 (196 bytes) Download Attachment |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From anaselli linux it 2006-12-18 22:46 ------- > ------- Additional Comments From mikmach wp pl 2006-12-18 22:37 ------- > Works OK for me. One thought. There is plenty of 0.12 there. Maybe some > variable for easier future upgrade? Yep I thought to it too, but you saw exiv2, there are libkipi, sqlite, libpng,... as well. I believe the problem is due to a missing stable (and working) exiv on most distro by now, maybe next digikam/kipi-plugins release won't be affected by this problem... Angelo P.S. Gilles wake up and commit ;) _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From caulier.gilles kdemail net 2006-12-19 07:41 ------- Angelo, I have do it yesterday on both : digiKam and kipi-plugins (:=)))... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From anaselli linux it 2006-12-19 09:23 ------- Alle 07:41, martedì 19 dicembre 2006, Gilles Caulier ha scritto: [bugs.kde.org quoted mail] yep, i saw it after. I wonder why it didn't svn up it first.... bah. Angelo _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From marnold ez-net com 2006-12-21 18:10 ------- I'm not a programmer per se, so I'm not sure what to do with that attachment. My comments were directed at the patch for configure.in.in in #41. The error message is "Exiv2 library not found, digiKam will not be compiled." It would be better worded the way it is in the patch in #43. I hope I'm making sense. The long and short of it is that at the end of the ./configure output, it shouldn't say that Exiv2 is not found but rather that Exiv2 => 0.12 is not found. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
so it is, in svn.
Angelo _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel attachment0 (196 bytes) Download Attachment |
In reply to this post by Bugzilla from mikmach@wp.pl
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=138616 ------- Additional Comments From anaselli linux it 2006-12-21 18:13 ------- so it is, in svn. Angelo _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |