[Digikam-devel] [Bug 138616] New: cannot compile: cannot verify exiv2 version

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-13 15:25 -------
Created an attachment (id=18912)
 --> (http://bugs.kde.org/attachment.cgi?id=18912&action=view)
patch for exiv2 (kipi-plugins)

> EXIV2_LIBS
You're right i changed EXIV2_LIBS to LIB_EXIV2 to maintain Gilles Makefile.am
but I believe this patch should be right and enough ;)

Gilles this patch is for kipi-plugins, I haven't digikam here, so I cannot
provide
one untill tonight.
Can you test this one and see if it's ok?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From caulier.gilles kdemail net  2006-12-13 15:30 -------
Fabien,

I'm busy until tomorrow. Can you check if all is ok ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-13 15:42 -------
> I'm busy until tomorrow. Can you check if all is ok ?

Good, I'll provide a digkam pach tonight then...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-13 18:20 -------
I just tried and it looks good, at least on my system :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From mikmach wp pl  2006-12-13 18:42 -------
> Gilles, I can't see the problem, the reporter doesn't want pkg-config
> while Andreas said it's a must. I cannot fix it in the way the reporter


Hey, hey, hey. I want it to *work*, I don't want some exact solution.
I suggested getting rid of pkg-config because I know it was causing
problems also in some other programs. If Andreas et al. can make it work
with pkg-config - fine by me :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-13 18:55 -------
Mikolaj, could you check if you have another exiv2 version on your computer ?

Please also try to do :
pkg-config --debug  --exists "exiv2 >= 0.12"
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From mikmach wp pl  2006-12-13 19:40 -------
OK, I see the problem (at least for Mandriva).

Pkg doesn't by default look for alternative locations of .pc files.

So, when I've had exiv2.pc in /usr/local/lib/pkgconfig pkg-config
couldn't find it there because it was looking only in
/usr/lib/pkgconfig.

I've had to create $PKG_CONFIG_PATH variable to include
/usr/local/lib/pkgconfig directory and now it works.

Now, from one side I understand that when someone wants to use sources
he makes it on his own risk but this situation doesn't feel good. On the
other side not everyone using bleeding edge software needs to know all
tricks of system.

Please at least add more info for configure output, something like:

exiv2 not found. Maybe pkg-config couldn't find data file. Check
location of exiv2.pc file and value of $PKG_CONFIG_PATH.

This is not complete info, but should give enough info for proper
googling - configure output isn't manual.
With such info added to configure scripts I can accept closing of this
bug (or close it myself).

m.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-14 08:47 -------
Alle 19:40, mercoledì 13 dicembre 2006, Mikolaj Machowski ha scritto:
[bugs.kde.org quoted mail]
No, it's general.
for mandriva 2007 you can get it (by now waiting a Gilles/Andreas answer)
here: http://www.linux.it/~anaselli/kipi-plugins/

> I've had to create $PKG_CONFIG_PATH variable to include
> /usr/local/lib/pkgconfig directory and now it works.


Well that's the way to, I don't know if it's pkg-config or configure or system
related, but in linux/unix systems, environment variables changes the behaviour,
and that's it. I believe you can find documents on it googling somewhere, I know
it's not easy for a user, but compiling sources neither... and who changes the
normal behavior of a distro should be aware of what he's doing.
I'm in a hurry by now, so i hope not to be misunderstood in what i said.
Regards,
        Angelo
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-14 18:40 -------
Created an attachment (id=18932)
 --> (http://bugs.kde.org/attachment.cgi?id=18932&action=view)
Patch for exiv2 checks in digikam

This is a patch to modify how exiv2 is checked by digikam configure.
It uses the same method as for kipi-plugins (by Angelo).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-14 18:42 -------
Ok, I just uploaded a patch for digikam. I tested it, recompiled everything and it looks fine.

I may solve as well the problem Mikolaj has.
Mikolaj, could you try it against latest svn version ?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From thorsten.schnebeck gmx net  2006-12-14 20:47 -------
Am Do Dez 14 2006 schrieb Fabien:
> Ok, I just uploaded a patch for digikam. I tested it, recompiled
> everything and it looks fine.


--- digikam/configure.in.in (revision 613686)
+++ digikam/configure.in.in (working copy)
 @ -215,23 +215,19  @
 [...]
-  AC_MSG_WARN([Exiv2 library not found, digiKam will not be compiled.])
-  DO_NOT_COMPILE="digikam digikamimageplugins $DO_NOT_COMPILE"
+  AC_MSG_ERROR([Exiv2 library is required by kipi-plugins.])
+  DO_NOT_COMPILE="$DO_NOT_COMPILE kipi-plugins"
 fi

^^^^
Is this correct?? IMHO Exiv2 is also required by digikam &
digikamimageplugins.

Bye

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Am Do Dez 14 2006 schrieb Fabien:
> Ok, I just uploaded a patch for digikam. I tested it, recompiled
> everything and it looks fine.

--- digikam/configure.in.in (revision 613686)
+++ digikam/configure.in.in (working copy)
@@ -215,23 +215,19 @@
 [...]
-  AC_MSG_WARN([Exiv2 library not found, digiKam will not be compiled.])
-  DO_NOT_COMPILE="digikam digikamimageplugins $DO_NOT_COMPILE"
+  AC_MSG_ERROR([Exiv2 library is required by kipi-plugins.])
+  DO_NOT_COMPILE="$DO_NOT_COMPILE kipi-plugins"
 fi

^^^^
Is this correct?? IMHO Exiv2 is also required by digikam &
digikamimageplugins.

Bye

  Thorsten

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From mikmach wp pl  2006-12-14 21:11 -------
> Mikolaj, could you try it against latest svn version ?


OK, with two remarks. First, This text:

    Exiv2 library is required by kipi-plugins.

Should mention digikam, digikamimageplugins not kipi-plugins. Second,
I would add mention about pkg-config:

    Exiv2 library is required by digikam, digikamimageplugins. Check if
    exiv2.pc is in path of pkg-config.

m.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         
anaselli linux it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18932|0                           |1
        is obsolete|                            |
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-14 22:40 -------
Created an attachment (id=18935)
 --> (http://bugs.kde.org/attachment.cgi?id=18935&action=view)
patch for exiv2 (digikam)

The attached one should work.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-14 22:43 -------
about comment #31, can you explain better what you mean with
"Check if exiv2.pc is in path of pkg-config"?
I mean the check should be consistent:
[anaselli proj9 digikam]$ pkg-config sqlite3 --libs
-lsqlite3
[anaselli proj9 digikam]$ pkg-config sqlite2 --libs
Package sqlite2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `sqlite2.pc'
to the PKG_CONFIG_PATH environment variable
No package 'sqlite2' found

If xxxx.pc is not in the path the check fails.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-14 22:48 -------
about the patch (comment #32)
there's something i don't like though, if you're compiling under svn all graphics, missing exiv2 or sqlite3 could be ok because digikam is not
the only project under. But if you're packaging those checks should make
failing configure, a warning message and "$DO_NOT_COMPILE digikam digikamimageplugins" is not enough, I believe. You could have a pretty empty
package ;)
Gilles please take care of testing and commit it,
   Angelo
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From caulier.gilles kdemail net  2006-12-15 07:33 -------
>Gilles please take care of testing and commit it

sure...

I'm waiting feedback at this moment. I wil commit that later.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-15 09:52 -------
About comments #30 and #31
Sorry, next time I'll do a bit more that just copy & paste :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138616         




------- Additional Comments From anaselli linux it  2006-12-15 11:06 -------
Fabien, never mind thanks for your help anyway
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel