[Digikam-devel] [Bug 133359] New: WISH: Google maps support to show satellite images of the photos

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-26 13:38 -------
SVN commit 588569 by cgilles:

kipi-plugins from trunk : GPSSync tool : improve GPS position editor dialog with a better precision. Don't use a KDoubleNumInput widget but a KLineEdit instead to be able to cut and paste easily position coordinate from konqueror. Added buttons to clear GPS position entries.

CCMAIL: gerhard kulzer net

CCBUGS: 133359, 111560

 M  +70 -21    gpseditdialog.cpp  
 M  +1 -0      gpseditdialog.h  
 M  +3 -3      gpslistviewitem.cpp  


--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.cpp #588568:588569
 @ -24,6 +24,7  @
 #include <qlayout.h>
 #include <qcombobox.h>
 #include <qpushbutton.h>
+#include <qvalidator.h>
 
 // KDE includes.
 
 @ -31,7 +32,8  @
 #include <kdebug.h>
 #include <kiconloader.h>
 #include <kapplication.h>
-#include <knuminput.h>
+#include <klineedit.h>
+#include <kmessagebox.h>
 
 // Local includes.
 
 @ -62,13 +64,13  @
         gpsCombo       = 0;
     }
 
-    QPushButton    *gpsButton;
+    QPushButton *gpsButton;
 
-    QComboBox      *gpsCombo;
+    QComboBox   *gpsCombo;
 
-    KDoubleSpinBox *altitudeInput;
-    KDoubleSpinBox *latitudeInput;
-    KDoubleSpinBox *longitudeInput;
+    KLineEdit   *altitudeInput;
+    KLineEdit   *latitudeInput;
+    KLineEdit   *longitudeInput;
 };
 
 GPSEditDialog::GPSEditDialog(QWidget* parent, GPSDataContainer gpsData,
 @ -82,21 +84,28  @
     setHelp("gpssync", "kipi-plugins");
     setButtonText(User1, i18n("Delete"));
 
-    QGridLayout* grid = new QGridLayout(plainPage(), 3, 1, 0, spacingHint());
+    QGridLayout* grid = new QGridLayout(plainPage(), 3, 2, 0, spacingHint());
 
     QLabel *altitudeLabel  = new QLabel(i18n("Altitude:"), plainPage());
     QLabel *latitudeLabel  = new QLabel(i18n("Latitude:"), plainPage());
     QLabel *longitudeLabel = new QLabel(i18n("Longitude:"), plainPage());
-    d->altitudeInput       = new KDoubleSpinBox(plainPage());
-    d->latitudeInput       = new KDoubleSpinBox(plainPage());
-    d->longitudeInput      = new KDoubleSpinBox(plainPage());
-    d->altitudeInput->setRange(-20000.0, 20000.0, 1.0, 1);
-    d->latitudeInput->setRange(-90.0, 90.0, 1E-6, 6);
-    d->longitudeInput->setRange(-180.0, 180.0, 1E-6, 6);
-    d->altitudeInput->setValue(gpsData.altitude());
-    d->latitudeInput->setValue(gpsData.latitude());
-    d->longitudeInput->setValue(gpsData.longitude());
 
+    d->altitudeInput       = new KLineEdit(plainPage());
+    d->latitudeInput       = new KLineEdit(plainPage());
+    d->longitudeInput      = new KLineEdit(plainPage());
+
+    QPushButton *altResetButton = new QPushButton(SmallIcon("clear_left"), QString::null, plainPage());
+    QPushButton *latResetButton = new QPushButton(SmallIcon("clear_left"), QString::null, plainPage());
+    QPushButton *lonResetButton = new QPushButton(SmallIcon("clear_left"), QString::null, plainPage());
+
+    d->altitudeInput->setValidator(new QDoubleValidator(-20000.0, 20000.0, 1, this));
+    d->latitudeInput->setValidator(new QDoubleValidator(-90.0, 90.0, 8, this));
+    d->longitudeInput->setValidator(new QDoubleValidator(-180.0, 180.0, 8, this));
+
+    d->altitudeInput->setText(QString::number(gpsData.altitude(),   'g', 12));
+    d->latitudeInput->setText(QString::number(gpsData.latitude(),   'g', 12));
+    d->longitudeInput->setText(QString::number(gpsData.longitude(), 'g', 12));
+
     d->gpsCombo  = new QComboBox( false, plainPage() );
     d->gpsButton = new QPushButton(i18n("Get GPS Coordinates..."), plainPage());
     d->gpsCombo->insertItem(QString("Capelinks"), GPSEditDialogDialogPrivate::CapeLinks);
 @ -110,12 +119,24  @
     grid->addMultiCellWidget(d->altitudeInput, 0, 0, 1, 1);
     grid->addMultiCellWidget(d->latitudeInput, 1, 1, 1, 1);
     grid->addMultiCellWidget(d->longitudeInput, 2, 2, 1, 1);
-    grid->addMultiCellWidget(d->gpsCombo, 3, 3, 0, 0 );
-    grid->addMultiCellWidget(d->gpsButton, 3, 3, 1, 1 );
+    grid->addMultiCellWidget(altResetButton, 0, 0, 2, 2);
+    grid->addMultiCellWidget(latResetButton, 1, 1, 2, 2);
+    grid->addMultiCellWidget(lonResetButton, 2, 2, 2, 2);
+    grid->addMultiCellWidget(d->gpsCombo, 3, 3, 0, 0);
+    grid->addMultiCellWidget(d->gpsButton, 3, 3, 1, 2);
 
     connect(d->gpsButton, SIGNAL(clicked()),
             this, SLOT(slotGPSLocator()));
 
+    connect(altResetButton, SIGNAL(clicked()),
+            d->altitudeInput, SLOT(clear()));
+
+    connect(latResetButton, SIGNAL(clicked()),
+            d->latitudeInput, SLOT(clear()));
+
+    connect(lonResetButton, SIGNAL(clicked()),
+            d->longitudeInput, SLOT(clear()));
+
     adjustSize();
 }
 
 @ -126,12 +147,40  @
 
 GPSDataContainer GPSEditDialog::getGPSInfo()
 {
-    return GPSDataContainer(d->altitudeInput->value(),
-                            d->latitudeInput->value(),
-                            d->longitudeInput->value(),
+    return GPSDataContainer(d->altitudeInput->text().toDouble(),
+                            d->latitudeInput->text().toDouble(),
+                            d->longitudeInput->text().toDouble(),
                             false);
 }
 
+void GPSEditDialog::slotOk()
+{
+    bool ok;
+
+    d->altitudeInput->text().toDouble(&ok);
+    if (!ok)
+    {
+        KMessageBox::error(this, i18n("Altitude value is not correct!"), i18n("GPS Sync"));    
+        return;
+    }        
+
+    d->latitudeInput->text().toDouble(&ok);
+    if (!ok)
+    {
+        KMessageBox::error(this, i18n("Latitude value is not correct!"), i18n("GPS Sync"));    
+        return;
+    }        
+
+    d->longitudeInput->text().toDouble(&ok);
+    if (!ok)
+    {
+        KMessageBox::error(this, i18n("Longitude value is not correct!"), i18n("GPS Sync"));    
+        return;
+    }        
+
+    accept();
+}
+
 void GPSEditDialog::slotUser1()
 {
     done(-1);
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.h #588568:588569
 @ -48,6 +48,7  @
 
 protected slots:
 
+    void slotOk();
     void slotUser1();
     void slotGPSLocator();
 
--- trunk/extragear/libs/kipi-plugins/gpssync/gpslistviewitem.cpp #588568:588569
 @ -93,9 +93,9  @
     setEnabled(true);
     d->dirty   = dirty;
     d->gpsData = gpsData;
-    setText(2, QString::number(d->gpsData.altitude()));
-    setText(3, QString::number(d->gpsData.latitude()));
-    setText(4, QString::number(d->gpsData.longitude()));
+    setText(2, QString::number(d->gpsData.altitude(),  'g', 12));
+    setText(3, QString::number(d->gpsData.latitude(),  'g', 12));
+    setText(4, QString::number(d->gpsData.longitude(), 'g', 12));
 
     QString status;
     if (isDirty())
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-27 10:52 -------
SVN commit 588865 by cgilles:

kipi-plugins from trunk : GPSSync tool : use a KHTMLPart widget to embed web locator page in GPS positions editor dialog

CCMAIL: gerhard kulzer net

CCBUGS: 133359, 111560

 M  +1 -1      Makefile.am  
 M  +22 -16    gpseditdialog.cpp  
 M  +1 -1      gpseditdialog.h  
 M  +5 -0      gpssyncdialog.cpp  


--- trunk/extragear/libs/kipi-plugins/gpssync/Makefile.am #588864:588865
 @ -14,7 +14,7  @
 
 # Libs needed by the plugin
 kipiplugin_gpssync_la_LIBADD = $(top_builddir)/kipi-plugins/common/exiv2iface/libexiv2iface.la \
-       $(LIBKIPI_LIBS) $(LIB_KDEUI) $(LIB_KDECORE) $(LIB_QT)
+       $(LIBKIPI_LIBS) $(LIB_KDEUI) $(LIB_KHTML) $(LIB_KDECORE) $(LIB_QT)
 
 # LD flags for the plugin
 kipiplugin_gpssync_la_LDFLAGS = -module $(KDE_PLUGIN) $(all_libraries)
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.cpp #588864:588865
 @ -21,6 +21,7  @
 // Qt includes.
 
 #include <qlabel.h>
+#include <qframe.h>
 #include <qlayout.h>
 #include <qcombobox.h>
 #include <qpushbutton.h>
 @ -34,6 +35,8  @
 #include <kapplication.h>
 #include <klineedit.h>
 #include <kmessagebox.h>
+#include <khtml_part.h>
+#include <khtmlview.h>
 
 // Local includes.
 
 @ -60,17 +63,17  @
         altitudeInput  = 0;
         latitudeInput  = 0;
         longitudeInput = 0;
-        gpsButton      = 0;
         gpsCombo       = 0;
+        worldMap       = 0;
     }
 
-    QPushButton *gpsButton;
-
     QComboBox   *gpsCombo;
 
     KLineEdit   *altitudeInput;
     KLineEdit   *latitudeInput;
     KLineEdit   *longitudeInput;
+
+    KHTMLPart   *worldMap;
 };
 
 GPSEditDialog::GPSEditDialog(QWidget* parent, GPSDataContainer gpsData,
 @ -84,7 +87,7  @
     setHelp("gpssync", "kipi-plugins");
     setButtonText(User1, i18n("Delete"));
 
-    QGridLayout* grid = new QGridLayout(plainPage(), 3, 2, 0, spacingHint());
+    QGridLayout* grid = new QGridLayout(plainPage(), 4, 3, 0, spacingHint());
 
     QLabel *altitudeLabel  = new QLabel(i18n("Altitude:"), plainPage());
     QLabel *latitudeLabel  = new QLabel(i18n("Latitude:"), plainPage());
 @ -106,8 +109,12  @
     d->latitudeInput->setText(QString::number(gpsData.latitude(),   'g', 12));
     d->longitudeInput->setText(QString::number(gpsData.longitude(), 'g', 12));
 
+    d->worldMap = new KHTMLPart(plainPage());
+    /*d->worldMap->openURL(KURL("/home/gilles/Documents/Devel/SVN/trunk/extragear/libs/kipi-plugins/gpssync/getlonlat.html"));*/
+    d->worldMap->view()->resize(640, 480);
+    d->worldMap->show();
+
     d->gpsCombo  = new QComboBox( false, plainPage() );
-    d->gpsButton = new QPushButton(i18n("Get GPS Coordinates..."), plainPage());
     d->gpsCombo->insertItem(QString("Capelinks"), GPSEditDialogDialogPrivate::CapeLinks);
     d->gpsCombo->insertItem(QString("MapKi"), GPSEditDialogDialogPrivate::MapKi);
 
 @ -123,10 +130,12  @
     grid->addMultiCellWidget(latResetButton, 1, 1, 2, 2);
     grid->addMultiCellWidget(lonResetButton, 2, 2, 2, 2);
     grid->addMultiCellWidget(d->gpsCombo, 3, 3, 0, 0);
-    grid->addMultiCellWidget(d->gpsButton, 3, 3, 1, 2);
+    grid->addMultiCellWidget(d->worldMap->view(), 0, 4, 3, 3);
+    grid->setColStretch(3, 10);
+    grid->setRowStretch(4, 10);
 
-    connect(d->gpsButton, SIGNAL(clicked()),
-            this, SLOT(slotGPSLocator()));
+    connect(d->gpsCombo, SIGNAL(activated(int)),
+            this, SLOT(slotGPSLocator(int)));
 
     connect(altResetButton, SIGNAL(clicked()),
             d->altitudeInput, SLOT(clear()));
 @ -138,6 +147,7  @
             d->longitudeInput, SLOT(clear()));
 
     adjustSize();
+    slotGPSLocator(d->gpsCombo->currentItem());
 }
 
 GPSEditDialog::~GPSEditDialog()
 @ -186,28 +196,24  @
     done(-1);
 }
 
-void GPSEditDialog::slotGPSLocator()
+void GPSEditDialog::slotGPSLocator(int i)
 {
-    QString val, url;
-
-    switch( d->gpsCombo->currentItem() )
+    switch(i)
     {
         case GPSEditDialogDialogPrivate::CapeLinks:
         {
-            url.append("http://www.capelinks.com/cape-cod/maps/gps");
+            d->worldMap->openURL(KURL("http://www.capelinks.com/cape-cod/maps/gps"));
             break;
         }
 
         case GPSEditDialogDialogPrivate::MapKi:
         {
-            url.append("http://mapki.com/getLonLat.php");
+            d->worldMap->openURL(KURL("http://mapki.com/getLonLat.php"));
             break;
         }
 
         // TODO : Added here others web GPS coordinates locator
     }
-    
-    KApplication::kApplication()->invokeBrowser(url);
 }
 
 }  // namespace KIPIGPSSyncPlugin
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.h #588864:588865
 @ -50,7 +50,7  @
 
     void slotOk();
     void slotUser1();
-    void slotGPSLocator();
+    void slotGPSLocator(int);
 
 private:
 
--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.cpp #588864:588865
 @ -427,6 +427,8  @
 
 void GPSSyncDialog::slotApply()
 {
+    KURL::List images;
+
     QListViewItemIterator it( d->listView );
     while ( it.current() )
     {
 @ -434,12 +436,15  @
         d->listView->setSelected(item, true);
         d->listView->ensureItemVisible(item);
         item->writeGPSInfoToFile();
+        images.append(item->getUrl());
 
         // TODO : new libkipi method to store GPS info in host database.
 
         ++it;
         kapp->processEvents();
     }
+    
+    d->interface->refreshImages(images);
 }
 
 }  // NameSpace KIPIGPSSyncPlugin
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-27 11:37 -------
fresh screenshot : http://digikam3rdparty.free.fr/Screenshots/newkipigpssyncplugin.png

I have a solution to set the GPS positions to map at startup, but this is require to have a dedicaced web page for the plugin.

Also, i would to get automaticly the longitude and latitude values from the google javascript when user right clic with mouse. I need some help here to get the values from the script to the dialog.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-27 14:27 -------
SVN commit 589005 by cgilles:

kipi-plugins from trunk : GPSSync tool : added capabilty to add/remove GPS position manually to more than one pictures at the same time. Just take your pictures selection on the list using SHIFT/CTRL keys and push "Edit Coordinates" button.

CCMAIL: gerhard kulzer net

CCBUGS: 133359, 111560

 M  +4 -8      gpslistviewitem.cpp  
 M  +1 -1      gpslistviewitem.h  
 M  +32 -6     gpssyncdialog.cpp  


--- trunk/extragear/libs/kipi-plugins/gpssync/gpslistviewitem.cpp #589004:589005
 @ -93,6 +93,7  @
     setEnabled(true);
     d->dirty   = dirty;
     d->gpsData = gpsData;
+    d->erase   = false;
     setText(2, QString::number(d->gpsData.altitude(),  'g', 12));
     setText(3, QString::number(d->gpsData.latitude(),  'g', 12));
     setText(4, QString::number(d->gpsData.longitude(), 'g', 12));
 @ -187,16 +188,11  @
     return d->dirty;
 }
 
-void GPSListViewItem::eraseGPSInfo(bool e)
+void GPSListViewItem::eraseGPSInfo()
 {
-    d->erase = e;
+    d->erase = true;
     d->dirty = true;
-
-    if (e)
-        setText(6, i18n("Deleted!"));
-    else
-        setText(6, "");
-
+    setText(6, i18n("Deleted!"));
     repaint();
 }
 
--- trunk/extragear/libs/kipi-plugins/gpssync/gpslistviewitem.h #589004:589005
 @ -57,7 +57,7  @
 
     void setGPSInfo(GPSDataContainer gpsData, bool dirty=true, bool addedManually=false);
     GPSDataContainer getGPSInfo();
-    void eraseGPSInfo(bool e);
+    void eraseGPSInfo();
 
     void setDateTime(QDateTime date);
     QDateTime getDateTime();
--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.cpp #589004:589005
 @ -150,7 +150,7  @
     d->listView->setAllColumnsShowFocus(true);
     d->listView->setSorting(-1);
     d->listView->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
-    d->listView->setSelectionMode(QListView::Single);
+    d->listView->setSelectionMode(QListView::Extended);
     d->listView->setMinimumWidth(450);
 
     // ---------------------------------------------------------------
 @ -401,7 +401,7  @
                              .arg(itemsUpdated), i18n("GPS Sync"));    
 }
 
-// Launch the GPS coordinates editor.
+// Start the GPS coordinates editor dialog.
 void GPSSyncDialog::slotUser2()
 {
     if (!d->listView->currentItem())
 @ -417,11 +417,37  @
     switch (dlg.exec())
     {
         case KDialogBase::Accepted:
-            item->setGPSInfo(dlg.getGPSInfo(), true, true);
-        break;
+        {
+            QListViewItemIterator it(d->listView);
+
+            while (it.current())
+            {
+                if (it.current()->isSelected())
+                {
+                    GPSListViewItem *selItem = (GPSListViewItem*)it.current();
+                    selItem->setGPSInfo(dlg.getGPSInfo(), true, true);
+                }
+                ++it;
+            }
+
+            break;
+        }
         case(-1):   // Erase all GPS tags
-            item->eraseGPSInfo(true);
-        break;
+        {
+            QListViewItemIterator it(d->listView);
+
+            while (it.current())
+            {
+                if (it.current()->isSelected())
+                {
+                    GPSListViewItem *selItem = (GPSListViewItem*)it.current();
+                    selItem->eraseGPSInfo();
+                }
+                ++it;
+            }
+
+            break;
+        }
     }
 }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-27 16:21 -------
SVN commit 589056 by cgilles:

kipi-plugins from trunk : GPSSync tool : remember the GPS position editor dialog settings between sessions.

CCMAIL: gerhard kulzer net

CCBUGS: 133359, 111560

 M  +34 -2     gpseditdialog.cpp  
 M  +10 -0     gpseditdialog.h  


--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.cpp #589055:589056
 @ -30,6 +30,7  @
 // KDE includes.
 
 #include <klocale.h>
+#include <kconfig.h>
 #include <kdebug.h>
 #include <kiconloader.h>
 #include <kapplication.h>
 @ -147,8 +148,7  @
     connect(lonResetButton, SIGNAL(clicked()),
             d->longitudeInput, SLOT(clear()));
 
-    adjustSize();
-    slotGPSLocator(d->gpsCombo->currentItem());
+    readSettings();
 }
 
 GPSEditDialog::~GPSEditDialog()
 @ -156,6 +156,38  @
     delete d;
 }
 
+void GPSEditDialog::closeEvent(QCloseEvent *e)
+{
+    if (!e) return;
+    saveSettings();
+    e->accept();
+}
+
+void GPSEditDialog::slotClose()
+{
+    saveSettings();
+    KDialogBase::slotClose();
+}
+
+void GPSEditDialog::readSettings()
+{
+    KConfig config("kipirc");
+    config.setGroup("GPS Sync Settings");
+    d->gpsCombo->setCurrentItem(config.readNumEntry("GPS Locator",
+                                GPSEditDialogDialogPrivate::CapeLinks));
+    resize(configDialogSize(config, QString("GPS Edit Dialog")));
+    slotGPSLocator(d->gpsCombo->currentItem());
+}
+
+void GPSEditDialog::saveSettings()
+{
+    KConfig config("kipirc");
+    config.setGroup("GPS Sync Settings");
+    config.writeEntry("GPS Locator", d->gpsCombo->currentItem());
+    saveDialogSize(config, QString("GPS Edit Dialog"));
+    config.sync();
+}
+
 GPSDataContainer GPSEditDialog::getGPSInfo()
 {
     return GPSDataContainer(d->altitudeInput->text().toDouble(),
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.h #589055:589056
 @ -49,11 +49,21  @
 protected slots:
 
     void slotOk();
+    void slotClose();
     void slotUser1();
     void slotGPSLocator(int);
 
+protected:
+
+    void closeEvent(QCloseEvent *);
+
 private:
 
+    void readSettings();
+    void saveSettings();
+
+private:
+
     GPSEditDialogDialogPrivate * d;
 };
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-28 08:48 -------
SVN commit 589488 by cgilles:

kipi-plugins from trunk : GPSSync tool : "Remove" button to delete GPS data from picture is now on main dialog.

CCMAIL: gerhard kulzer net

CCBUGS: 133359, 111560

 M  +6 -12     gpseditdialog.cpp  
 M  +0 -1      gpseditdialog.h  
 M  +41 -31    gpssyncdialog.cpp  
 M  +1 -0      gpssyncdialog.h  


--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.cpp #589487:589488
 @ -68,25 +68,24  @
         worldMap       = 0;
     }
 
-    QComboBox   *gpsCombo;
+    QComboBox *gpsCombo;
 
-    KLineEdit   *altitudeInput;
-    KLineEdit   *latitudeInput;
-    KLineEdit   *longitudeInput;
+    KLineEdit *altitudeInput;
+    KLineEdit *latitudeInput;
+    KLineEdit *longitudeInput;
 
-    KHTMLPart   *worldMap;
+    KHTMLPart *worldMap;
 };
 
 GPSEditDialog::GPSEditDialog(QWidget* parent, GPSDataContainer gpsData,
                              const QString& fileName)
              : KDialogBase(Plain, i18n("%1 - Edit GPS coordinates").arg(fileName),
-                           Help|User1|Ok|Cancel, Ok,
+                           Help|Ok|Cancel, Ok,
                            parent, 0, true, true)
 {
     d = new GPSEditDialogDialogPrivate;
 
     setHelp("gpssync", "kipi-plugins");
-    setButtonText(User1, i18n("Delete Coordinates"));
 
     QGridLayout* grid = new QGridLayout(plainPage(), 4, 3, 0, spacingHint());
 
 @ -224,11 +223,6  @
     accept();
 }
 
-void GPSEditDialog::slotUser1()
-{
-    done(-1);
-}
-
 void GPSEditDialog::slotGPSLocator(int i)
 {
     switch(i)
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.h #589487:589488
 @ -50,7 +50,6  @
 
     void slotOk();
     void slotClose();
-    void slotUser1();
     void slotGPSLocator(int);
 
 protected:
--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.cpp #589487:589488
 @ -100,16 +100,23  @
 
 GPSSyncDialog::GPSSyncDialog( KIPI::Interface* interface, QWidget* parent)
              : KDialogBase(Plain, i18n("GPS Sync"),
-                           Help|User1|User2|Apply|Close, Close,
+                           Help|User1|User2|User3|Apply|Close, Close,
                            parent, 0, true, true )
 {
     d = new GPSSyncDialogPriv;
     d->interface = interface;
 
     setButtonText(User1, i18n("Correlate"));
-    setButtonText(User2, i18n("Edit Coordinates..."));
+    setButtonText(User2, i18n("Edit..."));
+    setButtonText(User3, i18n("Remove"));
+
+    setButtonTip(User1, i18n("Correlate GPX file data with all pictures from the list."));
+    setButtonTip(User2, i18n("Edit manually GPS coordinates of selected pictures form the list."));
+    setButtonTip(User3, i18n("Remove GPS coordinates of selected pictures form the list."));
+
     enableButton(User1, false);
     enableButton(User2, true);
+    enableButton(User3, true);
 
     QGridLayout *mainLayout = new QGridLayout(plainPage(), 3, 1, 0, marginHint());
 
 @ -364,7 +371,7  @
     config.sync();
 }
 
-// Start to correlate the GPS positions and Pictures
+// Correlate the GPS positions from Pictures using a GPX file data.
 void GPSSyncDialog::slotUser1()
 {
     int itemsUpdated = 0;
 @ -406,48 +413,51  @
 {
     if (!d->listView->currentItem())
     {
-        KMessageBox::information(this, i18n("Please, select a picture from "
-                     "the list to edit GPS coordinate manually."), i18n("GPS Sync"));    
+        KMessageBox::information(this, i18n("Please, select pictures from "
+                     "the list to edit GPS coordinates manually."), i18n("GPS Sync"));    
         return;
     }
 
     GPSListViewItem* item = (GPSListViewItem*)d->listView->currentItem();
 
     GPSEditDialog dlg(this, item->getGPSInfo(), item->getUrl().fileName());
-    switch (dlg.exec())
+
+    if (dlg.exec() == KDialogBase::Accepted)
     {
-        case KDialogBase::Accepted:
+        QListViewItemIterator it(d->listView);
+
+        while (it.current())
         {
-            QListViewItemIterator it(d->listView);
-
-            while (it.current())
+            if (it.current()->isSelected())
             {
-                if (it.current()->isSelected())
-                {
-                    GPSListViewItem *selItem = (GPSListViewItem*)it.current();
-                    selItem->setGPSInfo(dlg.getGPSInfo(), true, true);
-                }
-                ++it;
+                GPSListViewItem *selItem = (GPSListViewItem*)it.current();
+                selItem->setGPSInfo(dlg.getGPSInfo(), true, true);
             }
-
-            break;
+            ++it;
         }
-        case(-1):   // Erase all GPS tags
-        {
-            QListViewItemIterator it(d->listView);
+    }
+}
 
-            while (it.current())
-            {
-                if (it.current()->isSelected())
-                {
-                    GPSListViewItem *selItem = (GPSListViewItem*)it.current();
-                    selItem->eraseGPSInfo();
-                }
-                ++it;
-            }
+// Remove GPS coordinates from pictures.
+void GPSSyncDialog::slotUser3()
+{
+    if (!d->listView->currentItem())
+    {
+        KMessageBox::information(this, i18n("Please, select pictures from "
+                     "the list to remove GPS coordinates."), i18n("GPS Sync"));    
+        return;
+    }
 
-            break;
+    QListViewItemIterator it(d->listView);
+
+    while (it.current())
+    {
+        if (it.current()->isSelected())
+        {
+            GPSListViewItem *selItem = (GPSListViewItem*)it.current();
+            selItem->eraseGPSInfo();
         }
+        ++it;
     }
 }
 
--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.h #589487:589488
 @ -60,6 +60,7  @
     void slotClose();
     void slotUser1();
     void slotUser2();
+    void slotUser3();
 
 private slots:
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles free fr  2006-09-28 12:52 -------
SVN commit 589554 by cgilles:

kipi-plugins from trunk : GPSSync tool : The GPS location editor dialognow use a dediced Google Maps to select the right place where have been taken the pictures.

Improvements :

- If the current picture already have GPS coordinates, the map will pan to the right place automaiticly at session startup!

- The GPS coordinates are automaticly captured by the dialog when the user right click on the map ! There is nothing to do manually to set the GPS location...

Angelo: with this plugin, i'm using a little php script to handle the google map with is interfaced with the plugin dialog ! This php script is hosted actually in a 3rd party digikam page. I would to host this page in the new kipi-plugins web project page. Can you help me ?

Noe : there is a copy of php script in svn.

CCMAIL: gerhard kulzer net, kde-imaging ke org

BUG: 133359
CCBUGS: 111560

 M  +2 -1      Makefile.am  
 A             getlonlat.php  
 M  +35 -61    gpseditdialog.cpp  
 M  +2 -3      gpseditdialog.h  
 A             gpsmapwidget.cpp   [License: GPL]
 A             gpsmapwidget.h   [License: GPL]


--- trunk/extragear/libs/kipi-plugins/gpssync/Makefile.am #589553:589554
 @ -10,7 +10,8  @
 
 # Srcs for the plugin
 kipiplugin_gpssync_la_SOURCES = plugin_gpssync.cpp gpssyncdialog.cpp gpslistviewitem.cpp \
-                            gpsbabelbinary.cpp gpsdataparser.cpp gpseditdialog.cpp
+                            gpsbabelbinary.cpp gpsdataparser.cpp gpseditdialog.cpp \
+                            gpsmapwidget.cpp
 
 # Libs needed by the plugin
 kipiplugin_gpssync_la_LIBADD = $(top_builddir)/kipi-plugins/common/exiv2iface/libexiv2iface.la \
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.cpp #589553:589554
 @ -21,9 +21,7  @
 // Qt includes.
 
 #include <qlabel.h>
-#include <qframe.h>
 #include <qlayout.h>
-#include <qcombobox.h>
 #include <qpushbutton.h>
 #include <qvalidator.h>
 
 @ -36,11 +34,11  @
 #include <kapplication.h>
 #include <klineedit.h>
 #include <kmessagebox.h>
-#include <khtml_part.h>
 #include <khtmlview.h>
 
 // Local includes.
 
+#include "gpsmapwidget.h"
 #include "gpseditdialog.h"
 #include "gpseditdialog.moc"
 
 @ -52,33 +50,22  @
 
 public:
 
-    enum WebGPSLocator
-    {
-        CapeLinks = 0,
-        MapKi
-        // TODO : Added here others web GPS coordinates locator
-    };
-
     GPSEditDialogDialogPrivate()
     {
         altitudeInput  = 0;
         latitudeInput  = 0;
         longitudeInput = 0;
-        gpsCombo       = 0;
         worldMap       = 0;
     }
 
-    QComboBox *gpsCombo;
+    KLineEdit    *altitudeInput;
+    KLineEdit    *latitudeInput;
+    KLineEdit    *longitudeInput;
 
-    KLineEdit *altitudeInput;
-    KLineEdit *latitudeInput;
-    KLineEdit *longitudeInput;
-
-    KHTMLPart *worldMap;
+    GPSMapWidget *worldMap;
 };
 
-GPSEditDialog::GPSEditDialog(QWidget* parent, GPSDataContainer gpsData,
-                             const QString& fileName)
+GPSEditDialog::GPSEditDialog(QWidget* parent, GPSDataContainer gpsData, const QString& fileName)
              : KDialogBase(Plain, i18n("%1 - Edit GPS coordinates").arg(fileName),
                            Help|Ok|Cancel, Ok,
                            parent, 0, true, true)
 @ -89,6 +76,10  @
 
     QGridLayout* grid = new QGridLayout(plainPage(), 4, 3, 0, spacingHint());
 
+    QLabel *message = new QLabel(i18n("<p>Use the map on the left to select the right place where "
+                                      "have been taken the picture. Click with right mouse button "
+                                       "on the map to get the GPS coordinates.<p>"), plainPage());
+
     QLabel *altitudeLabel  = new QLabel(i18n("Altitude:"), plainPage());
     QLabel *latitudeLabel  = new QLabel(i18n("Latitude:"), plainPage());
     QLabel *longitudeLabel = new QLabel(i18n("Longitude:"), plainPage());
 @ -109,35 +100,23  @
     d->latitudeInput->setText(QString::number(gpsData.latitude(),   'g', 12));
     d->longitudeInput->setText(QString::number(gpsData.longitude(), 'g', 12));
 
-    d->worldMap = new KHTMLPart(plainPage());
-    /*d->worldMap->openURL(KURL("/home/gilles/Documents/Devel/SVN/trunk/extragear/libs/kipi-plugins/gpssync/getlonlat.html"));*/
-    d->worldMap->view()->resize(640, 480);
-    d->worldMap->setJScriptEnabled(true);
+    d->worldMap = new GPSMapWidget(plainPage(), d->latitudeInput->text(), d->longitudeInput->text());
     d->worldMap->show();
 
-    d->gpsCombo  = new QComboBox( false, plainPage() );
-    d->gpsCombo->insertItem(QString("Capelinks"), GPSEditDialogDialogPrivate::CapeLinks);
-    d->gpsCombo->insertItem(QString("MapKi"), GPSEditDialogDialogPrivate::MapKi);
-
-    // TODO : Added here others web GPS coordinates locator
-    
-    grid->addMultiCellWidget(altitudeLabel, 0, 0, 0, 0);
-    grid->addMultiCellWidget(latitudeLabel, 1, 1, 0, 0);
-    grid->addMultiCellWidget(longitudeLabel, 2, 2, 0, 0);
-    grid->addMultiCellWidget(d->altitudeInput, 0, 0, 1, 1);
-    grid->addMultiCellWidget(d->latitudeInput, 1, 1, 1, 1);
-    grid->addMultiCellWidget(d->longitudeInput, 2, 2, 1, 1);
-    grid->addMultiCellWidget(altResetButton, 0, 0, 2, 2);
-    grid->addMultiCellWidget(latResetButton, 1, 1, 2, 2);
-    grid->addMultiCellWidget(lonResetButton, 2, 2, 2, 2);
-    grid->addMultiCellWidget(d->gpsCombo, 3, 3, 0, 0);
+    grid->addMultiCellWidget(message, 0, 0, 0, 2);
+    grid->addMultiCellWidget(altitudeLabel, 1, 1, 0, 0);
+    grid->addMultiCellWidget(latitudeLabel, 2, 2, 0, 0);
+    grid->addMultiCellWidget(longitudeLabel, 3, 3, 0, 0);
+    grid->addMultiCellWidget(d->altitudeInput, 1, 1, 1, 1);
+    grid->addMultiCellWidget(d->latitudeInput, 2, 2, 1, 1);
+    grid->addMultiCellWidget(d->longitudeInput, 3, 3, 1, 1);
+    grid->addMultiCellWidget(altResetButton, 1, 1, 2, 2);
+    grid->addMultiCellWidget(latResetButton, 2, 2, 2, 2);
+    grid->addMultiCellWidget(lonResetButton, 3, 3, 2, 2);
     grid->addMultiCellWidget(d->worldMap->view(), 0, 4, 3, 3);
     grid->setColStretch(3, 10);
     grid->setRowStretch(4, 10);
 
-    connect(d->gpsCombo, SIGNAL(activated(int)),
-            this, SLOT(slotGPSLocator(int)));
-
     connect(altResetButton, SIGNAL(clicked()),
             d->altitudeInput, SLOT(clear()));
 
 @ -147,6 +126,9  @
     connect(lonResetButton, SIGNAL(clicked()),
             d->longitudeInput, SLOT(clear()));
 
+    connect(d->worldMap, SIGNAL(signalMouseReleased()),
+            this, SLOT(slotGetGPSLocationFromMap()));
+
     readSettings();
 }
 
 @ -172,17 +154,13  @
 {
     KConfig config("kipirc");
     config.setGroup("GPS Sync Settings");
-    d->gpsCombo->setCurrentItem(config.readNumEntry("GPS Locator",
-                                GPSEditDialogDialogPrivate::CapeLinks));
     resize(configDialogSize(config, QString("GPS Edit Dialog")));
-    slotGPSLocator(d->gpsCombo->currentItem());
 }
 
 void GPSEditDialog::saveSettings()
 {
     KConfig config("kipirc");
     config.setGroup("GPS Sync Settings");
-    config.writeEntry("GPS Locator", d->gpsCombo->currentItem());
     saveDialogSize(config, QString("GPS Edit Dialog"));
     config.sync();
 }
 @ -223,23 +201,19  @
     accept();
 }
 
-void GPSEditDialog::slotGPSLocator(int i)
+void GPSEditDialog::slotGetGPSLocationFromMap()
 {
-    switch(i)
+    QString status = d->worldMap->jsStatusBarText();
+    
+    if (status.startsWith(QString("(lat:")))
     {
-        case GPSEditDialogDialogPrivate::CapeLinks:
-        {
-            d->worldMap->openURL(KURL("http://www.capelinks.com/cape-cod/maps/gps"));
-            break;
-        }
-
-        case GPSEditDialogDialogPrivate::MapKi:
-        {
-            d->worldMap->openURL(KURL("http://mapki.com/getLonLat.php"));
-            break;
-        }
-
-        // TODO : Added here others web GPS coordinates locator
+        status.remove(0, 5);
+        status.truncate(status.length()-1);
+        QString lat = status.section(",", 0, 0);
+        QString lon = status.section(",", 1, 1);
+        lon.remove(0, 5);
+        d->latitudeInput->setText(lat);
+        d->longitudeInput->setText(lon);
     }
 }
 
--- trunk/extragear/libs/kipi-plugins/gpssync/gpseditdialog.h #589553:589554
 @ -40,8 +40,7  @
 
 public:
 
-    GPSEditDialog(QWidget* parent, GPSDataContainer gpsData,
-                  const QString& fileName);
+    GPSEditDialog(QWidget* parent, GPSDataContainer gpsData, const QString& fileName);
     ~GPSEditDialog();
 
     GPSDataContainer getGPSInfo();
 @ -50,7 +49,7  @
 
     void slotOk();
     void slotClose();
-    void slotGPSLocator(int);
+    void slotGetGPSLocationFromMap();
 
 protected:
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-28 13:16 -------
And finally, the last version of the GPSSync kipi-plugin in action with google map :

http://digikam3rdparty.free.fr/Screenshots/newkipigpssyncplugin.png 
 
Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Hello,

This plugin is better and better every day :)

It works great !

I would just propose 2 small cosmetic changes (let me know if you want
me to put them on b.k.o) :

* coordonates numbers in edit window. See here :
<http://fabien.ubuntu.googlepages.com/gpssync_edit_screenshot.jpg>
There are too many numbers to fit in the box. It would be great to
increase the box size and to show less numbers...


* Load GPX button

The buttons stays depressed after the 1st time you click on it, whatever
you do after...
http://fabien.ubuntu.googlepages.com/gpssync_load-gpx-button_screenshot.jpg


BTW: have you seen my proposed patch for a more precise correlation ?
It's here :
http://bugs.kde.org/show_bug.cgi?id=134747
;-)

Gilles Caulier wrote:

> ------- Additional Comments From caulier.gilles free fr  2006-09-28
> 12:52 ------- SVN commit 589554 by cgilles:
>
> kipi-plugins from trunk : GPSSync tool : The GPS location editor
> dialognow use a dediced Google Maps to select the right place where
> have been taken the pictures.
>
> Improvements :
>
> - If the current picture already have GPS coordinates, the map will
> pan to the right place automaiticly at session startup!
>
> - The GPS coordinates are automaticly captured by the dialog when the
> user right click on the map ! There is nothing to do manually to set
> the GPS location...

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Thursday 28 September 2006 15:38, Fabien wrote:

> Hello,
>
> This plugin is better and better every day :)
>
> It works great !
>
> I would just propose 2 small cosmetic changes (let me know if you want
> me to put them on b.k.o) :
>
> * coordonates numbers in edit window. See here :
> <http://fabien.ubuntu.googlepages.com/gpssync_edit_screenshot.jpg>
> There are too many numbers to fit in the box. It would be great to
> increase the box size and to show less numbers...

fixed in svn

>
>
> * Load GPX button
>
> The buttons stays depressed after the 1st time you click on it, whatever
> you do after...
> http://fabien.ubuntu.googlepages.com/gpssync_load-gpx-button_screenshot.jpg

fixed in svn

>
>
> BTW: have you seen my proposed patch for a more precise correlation ?
> It's here :
> http://bugs.kde.org/show_bug.cgi?id=134747
> ;-)

not yet

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From aironmail gmail com  2006-09-28 19:05 -------
Gilles, I love it, great stuff! It's really good. I just have a comment: can we make the default size of the "Edit GPS coordinates" window a bit bigger? The default size is too small and most people will have to resize it. Probably the best is a size where the map would fit completelly.

Thank you very much for this plugin ;-).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=133359         




------- Additional Comments From caulier.gilles free fr  2006-09-28 19:12 -------
Antonio,

yes, we can. Note that the dialog will remember the size between session.

Gilles

PS: Now we will continue this thread about to add a possible google maps into digiKam GPS side bar tab. What do you think about ?

I don't want to do in digiKam for 0.9.0 but later. Won't touch anymore the code in digiKam code. It's time to stabilize all (0.9.0-beta3 is planed to october, and final release just before Christmast)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia czwartek, 28 września 2006 15:38, Fabien napisał:
> Hello,
>
> This plugin is better and better every day :)

Full ACK :)

One point: you cannot remove coordinates from image, only zero them.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 28 Septembre 2006 10:12 PM, Mikolaj Machowski a écrit :
> Dnia czwartek, 28 września 2006 15:38, Fabien napisał:
> > Hello,
> >
> > This plugin is better and better every day :)
>
> Full ACK :)
>
> One point: you cannot remove coordinates from image, only zero them.

What ? Are  you tried the 'Remove' button from the main dialog ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Gilles Caulier wrote:
>
> ------- Additional Comments From caulier.gilles free fr  2006-09-28
> 19:12 ------- Antonio,
>
> yes, we can. Note that the dialog will remember the size between
> session.

Well, that's fine. I would be happy to also be able to keep it small.
Rember we don't always have internet connection when we use digikam :)


> PS: Now we will continue this thread about to add a possible google
> maps into digiKam GPS side bar tab. What do you think about ?

IMHO, that would be great (as far as it's still possible to also choose
the static image map, when not connected to the internet - yes again :) -).

> I don't want to do in digiKam for 0.9.0 but later. Won't touch
> anymore the code in digiKam code. It's time to stabilize all
> (0.9.0-beta3 is planed to october, and final release just before
> Christmast)

I agree. The only modification that would be great (for me at least :) )
is to have real values and not fractions in the side bar for GPS
positions (Metadata/GPS), eg Altitude = 1739.64m  instead of 4349107/2500

Gilles, do you want me to open a wish on b.k.o about that ?

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia piątek, 29 września 2006 22:42, Caulier Gilles napisał:
> > One point: you cannot remove coordinates from image, only zero them.
>
> What ? Are  you tried the 'Remove' button from the main dialog ?

Today SVN works OK.

Few more things:

1. In "Edit GPS coordinates" dialog is phrase - Use the map on the left.
   Map is on the right side of the dialog.
2. Not everyone is non stop on-line. Maybe Digikam map could be used to
   determine coordinates when not online? It is not very precise but
   better than nothing and would speed up corrections with web based
   services.
3. "Edit GPS coordinates" - these coordinates are normal geographical
   coordinates. This apply to all dialogs and naming.
4. When exiting main dialog with "Close" button changes are silently
   ignored. IMO this is in conflict with common behaviour of KDE
   desktop. I would suggest giving dialog: You changed geo data of
   several images. Do you want to apply changes? Yes/No.

Not KIPI related:

Digikam:

1. In Metadata panel buttons don't have tooltips. While Print/Save are
   obvious the rest isn't (Copy to clipboard?,shortened view,full view).
2. Maybe in shortened view of coordinates data could be made human
   readable? Eg. instead of: "GPSLatitude 45/1 0/100 0/1" make it:
   "Latitude 45°"

TIA

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Friday 29 September 2006 14:12, Mikolaj Machowski wrote:

> Dnia piątek, 29 września 2006 22:42, Caulier Gilles napisał:
> > > One point: you cannot remove coordinates from image, only zero them.
> >
> > What ? Are  you tried the 'Remove' button from the main dialog ?
>
> Today SVN works OK.
>
> Few more things:
>
> 1. In "Edit GPS coordinates" dialog is phrase - Use the map on the left.
>    Map is on the right side of the dialog.

oups. i'm dislectic  (:=))) Fixed

> 2. Not everyone is non stop on-line. Maybe Digikam map could be used to
>    determine coordinates when not online? It is not very precise but
>    better than nothing and would speed up corrections with web based
>    services.

There is not a GPS editor into digiKam, because there is a plugin for that.

In fact i would untouch the digiKam core now until 0.9.0 release. Later we
will certainly implement something like that. The subject is open in B.K.O
file 133359.

> 3. "Edit GPS coordinates" - these coordinates are normal geographical
>    coordinates. This apply to all dialogs and naming.

Fixed.

> 4. When exiting main dialog with "Close" button changes are silently
>    ignored. IMO this is in conflict with common behaviour of KDE
>    desktop. I would suggest giving dialog: You changed geo data of
>    several images. Do you want to apply changes? Yes/No.

Yes, It's in my TODO list.

>
> Not KIPI related:
>
> Digikam:
>
> 1. In Metadata panel buttons don't have tooltips. While Print/Save are
>    obvious the rest isn't (Copy to clipboard?,shortened view,full view).

Press Shift+F1 and select a button : you have tooltips. Item about metadata
list view content.

I suspect than you use left button of mouse to get tooltip (like under Win32).
if fact this way work fine with KDialog but not with KMainWindow ! To have
checked the code in KDE 4, this behaviour will be fixed (i think)

> 2. Maybe in shortened view of coordinates data could be made human
>    readable? Eg. instead of: "GPSLatitude 45/1 0/100 0/1" make it:
>    "Latitude 45°"

All metadata list view contents strings come from Exiv2, not digiKam. i'm
agree view you than rational values given by Exiv2 are not human readble.
If you want to change it, please report a bug in Exiv2 bugzilla.

http://dev.robotbattle.com/bugs/main_page.php

Else the readable coordinate strings are displayed under the world map, just
below the metadata list view.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Gilles Caulier wrote:
> On Friday 29 September 2006 14:12, Mikolaj Machowski wrote:
>
 > [...]
 >
>>2. Maybe in shortened view of coordinates data could be made human
>>   readable? Eg. instead of: "GPSLatitude 45/1 0/100 0/1" make it:
>>   "Latitude 45°"
>
> All metadata list view contents strings come from Exiv2, not digiKam. i'm
> agree view you than rational values given by Exiv2 are not human readble.
> If you want to change it, please report a bug in Exiv2 bugzilla.
>
> http://dev.robotbattle.com/bugs/main_page.php

Good to know that. I will report it if it's not already the case, or
will vote for it...

> Else the readable coordinate strings are displayed under the world map, just
> below the metadata list view.

Yes, but not the altitude. And knowing altitude is cool, especially when
looking at hiking pictures :)


--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

On Friday 29 September 2006 15:29, Fabien wrote:
> Yes, but not the altitude. And knowing altitude is cool, especially when
> looking at hiking pictures :)

Please report it to B.K.O. Il will do it later

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Fabien wrote:

> Gilles Caulier wrote:
>
>>On Friday 29 September 2006 14:12, Mikolaj Machowski wrote:
>>
>
>  > [...]
>  >
>
>>>2. Maybe in shortened view of coordinates data could be made human
>>>  readable? Eg. instead of: "GPSLatitude 45/1 0/100 0/1" make it:
>>>  "Latitude 45°"
>>
>>All metadata list view contents strings come from Exiv2, not digiKam. i'm
>>agree view you than rational values given by Exiv2 are not human readble.
>>If you want to change it, please report a bug in Exiv2 bugzilla.
>>
>>http://dev.robotbattle.com/bugs/main_page.php
>
>
> Good to know that. I will report it if it's not already the case, or
> will vote for it...

Ok, I added it to exiv2 :
http://dev.robotbattle.com/bugs/view.php?id=488

But, I'm not sure they will accept it. Here is an extract from man page :
<<
The EXIF standard stipulates that the GPSLatitude  tag  consists
of three Rational numbers for the degrees, minutes and seconds
of the latitude and GPSLatitudeRef contains either N or S
for north or south latitude respectively.
 >>

So, it's not surprising they just output the exact values from exif
header, isn't it ?

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel