digiKam › digikam-devel

[Digikam-devel] [Bug 133359] New: WISH: Google maps support to show satellite images of the photos

Classic

List

Threaded

86 messages Options

12345

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-22 14:18 -------
Antonio,

I'm not sure if the GPSSync plugin is the right place to a manual GPS position editing.

This plugin is dedicaced to synchronize only pictures metadata with a GPX file.

I think it can be confuse to have a manual GPS position editing in the plugin. We can do it directly in digiKam, to select a picture and use the Metadata/GPS sidebar tab. We must add a new button in this area to set the GPS position value.

Your viewpoints please...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from Julien.Narboux@inria.fr

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From Julien.Narboux inria fr 2006-09-22 14:23 -------
I agree with you Gilles.

My 2 cents

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-22 15:17 -------
Hey guy !

I don't have a GPS device to test. Interpolation method is just implemented, not tested indeep.

Gerhard, i have used your algorithm to compute interpolated GPS positions. Take a look into GPSDataParser::matchDate() method from gpsdataparser.cpp :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/gpssync/gpsdataparser.cpp?rev=587348&view=auto

Please give me a feedback. Thanks in advance

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-22 15:25 -------
A fresh screenshot of the plugin :

http://digikam3rdparty.free.fr/Screenshots/newkipigpssyncplugin.png

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from Julien.Narboux@inria.fr

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From Julien.Narboux inria fr 2006-09-22 15:43 -------
I did not test, I just read the code.
Why not use the same interpolation formula for the altitude ?

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-22 15:50 -------
This is have a sence to interpolate altitude value ?

If yes, well why not (:=))). it just 3 source code lines to add...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from Julien.Narboux@inria.fr

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From Julien.Narboux inria fr 2006-09-22 16:02 -------
The same meaning as interpolating longitiude and latitude I guess. It is just a third dimension in a special coordinate system.

We assume that I you are at sea level at 12 oclock and your are at 1000m high at 12:30 then you may be at 500 at 12:15... Of course it may be false, but the same applies to latitude and longitude.

In the future the interpolation could be improved by taking into account more than two points. But it is more complicated and imho not needed.
What I mean by taking into account more that two points is to compute a nice curve going through the points (a spline for instance) and then interpolate on this spline.

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-25 14:54 -------
SVN commit 588251 by cgilles:

kipi-plugins from trunk : GPSSync tool :

- New options :
* to set GPS coordinates manually.
* to remove all GPS info from file.

- Bug fix (relevant of EXIV2 library ?) : we need to clean up all GPS info from file before to rewrite it.
Andreas, i have seen that if a picture has already GPS infos, if i don't process a clean up of all Exif.GPSInfo tags,
the lattitude and altitude values are set to 0.

CCMAIL: kde-imaging kde org, alexios.beveratos gmail com, gerhard kulzer net, ahuggel gmx net

CCBUGS: 133359, 111560

M +1 -1 Makefile.am
A gpseditdialog.cpp [License: GPL]
A gpseditdialog.h [License: GPL]
M +39 -8 gpslistviewitem.cpp
M +3 -1 gpslistviewitem.h
M +31 -10 gpssyncdialog.cpp
M +7 -0 gpssyncdialog.h

--- trunk/extragear/libs/kipi-plugins/gpssync/Makefile.am #588250:588251
@ -10,7 +10,7 @

# Srcs for the plugin
kipiplugin_gpssync_la_SOURCES = plugin_gpssync.cpp gpssyncdialog.cpp gpslistviewitem.cpp \
- gpsbabelbinary.cpp gpsdataparser.cpp
+ gpsbabelbinary.cpp gpsdataparser.cpp gpseditdialog.cpp

# Libs needed by the plugin
kipiplugin_gpssync_la_LIBADD = $(top_builddir)/kipi-plugins/common/exiv2iface/libexiv2iface.la \
--- trunk/extragear/libs/kipi-plugins/gpssync/gpslistviewitem.cpp #588250:588251
@ -44,12 +44,14 @

GPSListViewItemPriv()
{
- enabled = false;
- dirty = false;
+ enabled = false;
+ dirty = false;
+ erase = false;
}

bool enabled;
bool dirty;
+ bool erase;

QDateTime date;

@ -86,7 +88,7 @
delete d;
}

-void GPSListViewItem::setGPSInfo(GPSDataContainer gpsData, bool dirty)
+void GPSListViewItem::setGPSInfo(GPSDataContainer gpsData, bool dirty, bool addedManually)
{
d->dirty = dirty;
d->gpsData = gpsData;
@ -100,7 +102,12 @
if (d->gpsData.isInterpolated())
status = i18n("Interpolated");
else
- status = i18n("Found");
+ {
+ if (addedManually)
+ status = i18n("Added");
+ else
+ status = i18n("Found");
+ }
}
setText(6, status);

@ -147,10 +154,13 @
{
setPixmap(1, SmallIcon("run"));
KIPIPlugins::Exiv2Iface exiv2Iface;
- exiv2Iface.load(d->url.path());
- bool ret = exiv2Iface.setGPSInfo(d->gpsData.altitude(),
- d->gpsData.latitude(),
+ bool ret = exiv2Iface.load(d->url.path());
+ ret &= exiv2Iface.removeGPSInfo();
+ if (!d->erase)
+ {
+ ret &= exiv2Iface.setGPSInfo(d->gpsData.altitude(), d->gpsData.latitude(),
d->gpsData.longitude());
+ }
ret &= exiv2Iface.save(d->url.path());
if (ret)
setPixmap(1, SmallIcon("ok"));
@ -175,11 +185,24 @
return d->dirty;
}

+void GPSListViewItem::eraseGPSInfo(bool e)
+{
+ d->erase = e;
+ d->dirty = true;
+
+ if (e)
+ setText(6, i18n("Deleted!"));
+ else
+ setText(6, "");
+
+ repaint();
+}
+
void GPSListViewItem::paintCell(QPainter *p, const QColorGroup &cg, int column, int width, int alignment)
{
if (d->enabled)
{
- if ( isDirty() && column >=2 && column <=4 )
+ if ( isDirty() && !d->erase && column >= 2 && column <= 4 )
{
QColorGroup _cg( cg );
QColor c = _cg.text();
@ -187,6 +210,14 @
KListViewItem::paintCell( p, _cg, column, width, alignment );
_cg.setColor( QColorGroup::Text, c );
}
+ else if ( isDirty() && d->erase && column == 6)
+ {
+ QColorGroup _cg( cg );
+ QColor c = _cg.text();
+ _cg.setColor( QColorGroup::Text, Qt::red );
+ KListViewItem::paintCell( p, _cg, column, width, alignment );
+ _cg.setColor( QColorGroup::Text, c );
+ }
else
KListViewItem::paintCell(p, cg, column, width, alignment);
}
--- trunk/extragear/libs/kipi-plugins/gpssync/gpslistviewitem.h #588250:588251
@ -55,9 +55,11 @
GPSListViewItem(KListView *view, QListViewItem *after, const KURL& url);
~GPSListViewItem();

- void setGPSInfo(GPSDataContainer gpsData, bool dirty=true);
+ void setGPSInfo(GPSDataContainer gpsData, bool dirty=true, bool addedManually=false);
GPSDataContainer getGPSInfo();
+ void eraseGPSInfo(bool e);

+
void setDateTime(QDateTime date);
QDateTime getDateTime();

--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.cpp #588250:588251
@ -54,6 +54,7 @

#include "gpslistviewitem.h"
#include "pluginsversion.h"
+#include "gpseditdialog.h"
#include "gpssyncdialog.h"
#include "gpssyncdialog.moc"

@ -98,15 +99,16 @

GPSSyncDialog::GPSSyncDialog( KIPI::Interface* interface, QWidget* parent)
: KDialogBase(Plain, i18n("GPS Sync"),
- Help|User1|Apply|Close, Close,
+ Help|User1|User2|Apply|Close, Close,
parent, 0, true, true )
{
d = new GPSSyncDialogPriv;
d->interface = interface;

setButtonText(User1, i18n("Correlate"));
- enableButton(Apply, false);
+ setButtonText(User2, i18n("Edit Coordinates..."));
enableButton(User1, false);
+ enableButton(User2, true);

QGridLayout *mainLayout = new QGridLayout(plainPage(), 3, 1, 0, marginHint());

@ -158,9 +160,6 @

QPushButton *loadGPXButton = new QPushButton(i18n("Load GPX File..."), settingsBox);

- connect(loadGPXButton, SIGNAL(pressed()),
- this, SLOT(slotLoadGPXFile()));
-
QLabel *gpxFileLabel = new QLabel(i18n("Current GPX file:"), settingsBox);
d->gpxFileName = new KSqueezedTextLabel(i18n("No GPX file"), settingsBox);
d->gpxPointsLabel = new QLabel(settingsBox);
@ -255,6 +254,9 @

// ---------------------------------------------------------------

+ connect(loadGPXButton, SIGNAL(pressed()),
+ this, SLOT(slotLoadGPXFile()));
+
connect(d->interpolateBox, SIGNAL(toggled(bool)),
d->maxTimeLabel, SLOT(setEnabled(bool)));

@ -299,7 +301,6 @
{
KMessageBox::error(this, i18n("Cannot parse %1 GPX file!")
.arg(loadGPXFile.fileName()), i18n("GPS Sync"));
- enableButton(Apply, false);
enableButton(User1, false);
return;
}
@ -308,14 +309,12 @
{
KMessageBox::sorry(this, i18n("The %1 GPX file do not have a date-time track to use!")
.arg(loadGPXFile.fileName()), i18n("GPS Sync"));
- enableButton(Apply, false);
enableButton(User1, false);
return;
}

d->gpxFileName->setText(loadGPXFile.fileName());
d->gpxPointsLabel->setText(i18n("Points parsed: %1").arg(d->gpxParser.numPoints()));
- enableButton(Apply, true);
enableButton(User1, true);
slotUser1();
}
@ -392,7 +391,6 @
{
KMessageBox::sorry(this, i18n("Cannot find pictures to correlate with GPX file data."),
i18n("GPS Sync"));
- enableButton(Apply, false);
return;
}

@ -400,9 +398,32 @
"the list using the GPX data file.\n"
"Press Apply button to update picture(s) metadata.")
.arg(itemsUpdated), i18n("GPS Sync"));
- enableButton(Apply, true);
}

+// Launch the GPS coordinates editor.
+void GPSSyncDialog::slotUser2()
+{
+ if (!d->listView->currentItem())
+ {
+ KMessageBox::information(this, i18n("Please, select a picture from "
+ "the list to edit GPS coordinate manually."), i18n("GPS Sync"));
+ return;
+ }
+
+ GPSListViewItem* item = (GPSListViewItem*)d->listView->currentItem();
+
+ GPSEditDialog dlg(this, item->getGPSInfo(), item->getUrl().fileName());
+ switch (dlg.exec())
+ {
+ case KDialogBase::Accepted:
+ item->setGPSInfo(dlg.getGPSInfo(), true, true);
+ break;
+ case(-1): // Erase all GPS tags
+ item->eraseGPSInfo(true);
+ break;
+ }
+}
+
void GPSSyncDialog::slotApply()
{
QListViewItemIterator it( d->listView );
--- trunk/extragear/libs/kipi-plugins/gpssync/gpssyncdialog.h #588250:588251
@ -35,8 +35,11 @

#include "gpsdataparser.h"

+class QListViewItem;
+
namespace KIPIGPSSyncPlugin
{
+
class GPSSyncDialogPriv;

class GPSSyncDialog :public KDialogBase
@ -60,6 +63,10 @
void slotHelp();
void slotClose();
void slotUser1();
+ void slotUser2();
+
+private slots:
+
void slotLoadGPXFile();

private:
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-25 16:30 -------
Fresh screenshot of GPSSync kipi-plugin updated :

http://digikam3rdparty.free.fr/Screenshots/newkipigpssyncplugin.png

I'm waiting new GPS coordinates locator urls...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from aironmail@gmail.com

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From aironmail gmail com 2006-09-25 20:01 -------
The screenshot is really nice. It's getting a really cool feature.

I can't compile the lastest trunk from today at 19:00. I get this:

if /bin/sh ../../libtool --silent --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../libkipi/libkipi -I../../kipi-plugins/common/include -I../../kipi-plugins/common/exiv2iface -I../../libkipi -I../../libkipi -I/usr/kde/3.5/include -I/usr/qt/3/include -I. -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT plugin_gpssync.lo -MD -MP -MF ".deps/plugin_gpssync.Tpo" -c -o plugin_gpssync.lo plugin_gpssync.cpp; \
then mv -f ".deps/plugin_gpssync.Tpo" ".deps/plugin_gpssync.Plo"; else rm -f ".deps/plugin_gpssync.Tpo"; exit 1; fi
gpsdatacontainer.h:43: error: extra qualification 'KIPIGPSSyncPlugin::GPSDataContainer::' on member 'operator='
make: *** [plugin_gpssync.lo] Error 1
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-25 20:24 -------
Antonio,

Broken compilation with gcc 4.1 is now fixed on svn. Please try again

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from aironmail@gmail.com

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From aironmail gmail com 2006-09-26 00:34 -------
Thanks Gilles. I've tried it and now it compiles fine.

I found a problem entering manually the coordinates:

The format that seems to use the spinners is 0,######, which means only 6 decimal digits. In the capelinks web we can get more accurated coordinates, like for example: Latitude: 41.95949009892464, Longitude: -70.3619384765625.

Now if I try to enter a value with that amount of decimal numbers the spinner doesn't work, as it just go back to the previous valid value (of 6 decimal digits) when I press enter. It doesn't even round the value. Probably the editor should use a smaller step size: 0.0000000000001

I don't know if can be done, but it could be good if when the get gps coordinates button is hit, the map could be opened in the coordinates that are edited if they exist, and if the doesn't just opened in the last validated coordinates. It's just an idea.

It's getting really nice Gilles. Thank you ;-).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=133359

------- Additional Comments From caulier.gilles free fr 2006-09-26 07:32 -------
Yes, Antonio, i have already this problem in my minds. The plugin need to be polished again (:=))

About the Capelinks (google map in fact) links, this is what i would to do : i not satisfied by the way to copy and paste the coordinate between konqueror and the plugin. A better way is to run the google map script into the plugin and capture automaticly the values returned by google.

I'm not sure if we can do it using google maps api. Normally, the script need to be hosted in a web site, not an application.

The only thing that i can do (i think) is to embbed the konqueror session in the dialog with start an external window)

If somebody have a better idea, let's me hear.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Fabien-5

Re: [Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

Hello,

Gilles Caulier wrote:

> ------- Additional Comments From caulier.gilles free fr 2006-09-26 07:32 -------
> Yes, Antonio, i have already this problem in my minds. The plugin need to be polished again (:=))
>
> About the Capelinks (google map in fact) links, this is what i would to do : i not satisfied by the way to copy and paste the coordinate between konqueror and the plugin. A better way is to run the google map script into the plugin and capture automaticly the values returned by google.
>
> I'm not sure if we can do it using google maps api. Normally, the script need to be hosted in a web site, not an application.
>
> The only thing that i can do (i think) is to embbed the konqueror session in the dialog with start an external window)
>
> If somebody have a better idea, let's me hear.

Not sure there are better propositions, but here is a quote of my
previous email :

<<
But, I wonder if it's a good idea to hardcode these urls in digikam.
These links may change eventually and could be broken at any time.
I'm thinking of 2 possibilities :
- be able to add/modify these parameters in some configuration menu (ie
provides by default some URLs but let users modify/remove/add links)
- use digikam.org website as a redirector for these URLs so they can be
changed quickly without annoying users
and why not host an API to google map on digikam.org ?
>>

IMHO, it's important to have the choice between different map engines.
There is not only google maps, and this one is not always the most
precise in all countries.
Another important point : I think digikam must work even without any
internet connection, and I hope it will still be the case if you add
this (great) possibility...
Finally, it's important to still be able to enter manually these GPS
values. You don't always need a web service to get them.
E.g: I use some (unfortunately) proprietary map softwares with wine
(Topos, etc...) and I can get very precise coordonates (1/25000)...
It's also possible to get these values with some printed maps (any topo
maps)...

Just my 2 cents :)

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

Gilles Caulier

[Digikam-devel] [Bug 133359] WISH: Google maps support to show satellite images of the photos

In reply to this post by Bugzilla from aironmail@gmail.com

12345