[Digikam-devel] [Bug 130906] New: Allow user to click text of tags to tag an image (not checkbox only).

classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 12:42 -------
Yes, double click is ignored to collapse tree.

To do it, use the "+" or "-" symbols from tree view branch to collapse/expand.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 12:44 -------
There is another solution to unbreak colapse/expand tree view branch with double click : using middle mouse button to perform tag selection/deselection. What do you think about ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Bugzilla from andi.clemens@gmx.net
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-07 13:02 -------
Hmm don't know, this is a very unusual behavior. I guess most users will not like it and we must inform users somehow that they have to select tags with middle mouse button now. I guess this will even be true for the little checkbox widget, and this is definitely a strange way to select a checkbox...
I will play around with the event filter later that day... if nothing will work we have to discuss this over again.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25895|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-07-07 13:28 -------
Created an attachment (id=25898)
 --> (http://bugs.kde.org/attachment.cgi?id=25898&action=view)
new version using middle button to select tag

Andi,

This version include several mouse buttons behaviours changes:

1/ Use middle mouse button to select/uselect tag when user click on tag text
(and only tag text)
2/ Single Right mouse button click expand/collapse treeview. This behaviour is
ask on this report: http://bugs.kde.org/show_bug.cgi?id=126871. This way is
already used in K3b to expand/collapse treeview faster. I think it's really an
usability improvement. Of course, this change must be done in other treeview as
Albumview, Dateview an Tagview from left sidebar.
3/ Double Right mouse click always work as default. No change here.

We cannot mix single/double right mouse button click to select/unselect tag and
expand/collapse treeview. Also, middle button to select/uselect tags is not too
wrong. It's a special case from digiKam taht all. In my patch, i have improved
the FoldeView::mouseInItemRect() to only handle text area without checkbox.
User can continue to use (+) and (-) to expand/collapse and the checkbox to
select/unselect tag.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Bugzilla from andi.clemens@gmx.net
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-07 13:41 -------
This looks exactly like my patch, and it behaves the same... maybe you uploaded the wrong version?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25898|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-07-07 14:09 -------
Created an attachment (id=25899)
 --> (http://bugs.kde.org/attachment.cgi?id=25899&action=view)
right version patch using middle button to select tag
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-07-08 12:41 -------
SVN commit 829376 by cgilles:

digiKam from KDE3 branch : toggle on/of tag check box item using middle mouse button.
BUGS: 130906


 M  +12 -5     folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=829376
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 130906] Allow user to click text of tags to tag an image (not checkbox only).

Gilles Caulier-4
In reply to this post by K Robinson
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-08 13:35 -------
SVN commit 829399 by cgilles:

backport commit #829376 from KDE3 branch
CCBUGS: 130906


 M  +11 -5     folderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=829399
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12