[Digikam-devel] [Bug 130906] New: Allow user to click text of tags to tag an image (not checkbox only).

[K Robinson]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
           Summary: Allow user to click text of tags to tag an image (not
                    checkbox only).
           Product: digikam
           Version: 0.8.1
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: kjr99044 yahoo com


Version:           0.8.1 (using KDE KDE 3.5.3)
Installed from:    Fedora RPMs
OS:                Linux

In the "Edit image comments and tags" dialog, the user has to click inside each checkbox for the tags.   It would be much more nice to be able to click on the tag text as well.  That way the user doesn't have to aim directly at the check box to choose which tags to apply to each image.

Best wishes to the developers,
K Robinson
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[K Robinson]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From kjr99044 yahoo com  2006-07-17 05:45 -------
Perhaps installEventListener on the TAlbumListView or on each tag's TAlbumCheckListItem for a mouse click (or a Shift-click), upon which the relevant tag will be toggled?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Tags
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From congyiwu gmail com  2007-06-21 01:39 -------
I like this idea.  Single click could lead to mistakes, so shift clicking is a good idea.  Double clicking might work too, since shift clicking is normally associated with selecting multiple items.

Also, right now the space bar seems to go to the next picture in the album, yet it doesn't show up in the configure shortcuts dialog...  I think it might also make sense to allow selecting multiple tags with ctrl or shift click, and toggling with the space bar.  This might be easier to implement as well.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From moelles gmx net  2008-04-23 10:32 -------
there is definitely a need for improvement => usability rules!

(doubleclick would annoy me when is was to tag 1000pictures..)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From arnd.baecker web de  2008-04-23 10:59 -------
Jens, sure;  patches, i.e code contributions, are very welcome! ;-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-05 01:01 -------
Created an attachment (id=25847)
 --> (http://bugs.kde.org/attachment.cgi?id=25847&action=view)
patch #1

Hi, just wrote a little patch for the described problem. But it doesn't work
well yet. Clicking on the CheckListItem in general works fine, but if you click
the little checkbox, it doesn't work anymore.
Gilles, Arnd, Marcel... is it possible to filter where the user has clicked?

Another question: is a TAlbumListView object also used in the left tags
sidebar? If so, does this additional slot affect it in a negative way?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-05 01:45 -------
Hmm it seems to be impossible to fix this, well at least I can't find a good solution. One possibility would be to double-click on the tag, just replace the signal in the connect statement with doubleClicked().
The problem with this is that the users have to be informed about this, because normally you don't double-click on such items...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-05 08:39 -------
Andi,

Like it's said in comment #1 you need to add an eventFilter. Look my code as exemple from adjust level plugin dialog AdjustLevelDialog::eventFilter().

More info from Qt api :

http://doc.trolltech.com/3.3/qobject.html#installEventFilter
http://doc.trolltech.com/3.3/qobject.html#eventFilter

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25847|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-07-06 15:19 -------
Created an attachment (id=25877)
 --> (http://bugs.kde.org/attachment.cgi?id=25877&action=view)
patch #2

Now it works fine...
Gilles, ready to commit?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25877|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-07-06 19:53 -------
Created an attachment (id=25884)
 --> (http://bugs.kde.org/attachment.cgi?id=25884&action=view)
patch #3

There was a problem with the second patch, you were not able to collapse the
CheckListItems anymore, only by double click, which also resulted in assigning
a tag, although not wanted.
To fix this, I used the mouseInItemRect() function from TAlbumViewList class.
The problem here: it is private. I had to change access to public to use it. Is
there a problem with that? TAlbumListView seems to be no part in any lib in
digiKam so changing its access rights isn't a too big problem, right?

Gilles, what do you think?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 08:13 -------
Andi,

No problem to change access of this method. I will test your patch soon.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-07 08:33 -------
Gilles,

the mentioned function is also defined in FolderView, with exactly the same code as defined in TAlbumView. The only difference are the access rights, in FolderView the function is protected.
It would be even better to set the method in FolderView to public and completely remove it in TAlbumView. But FolderView is a member of libdigikam. Would this change have side effects on the lib?
If so, changing only TAlbumView is fine...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 08:37 -------
Oh. nice. I take a look.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 11:10 -------
Andi,

About your comment #11, we must use parent class code. FolderView::mouseInItemRect() must be set as public and TAlbumViewList::mouseInItemRect() removed.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25884|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-07-07 11:21 -------
Created an attachment (id=25895)
 --> (http://bugs.kde.org/attachment.cgi?id=25895&action=view)
patch #4 (final?)

Ok, now the function is removed completely from TAlbumView...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 11:27 -------
>patch #4 (final?)

No (:=))

I can see one problem with the new behaviour.

1/ one click => tag selected. work fine (great)
2/ one double click => tag selected => no. this must collapse/uncollapse childs treeview only. this is the default behaviour without your patch and it must be preserved.

Note: a similar patch must be applied to tagfilter view to be homogenous, else you will see a new bug report about in the future (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-07 11:56 -------
I guess this is not possible, I tried it before... A double click also is handled as a normal click... there is no way (at least for me right now) to handle such situations. Even if the very first line in the eventFilter is

if (e->type() == QEvent::MouseButtonDblClick)
  return false;

the "normal" click action will be called. Do you know a way to do this?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From caulier.gilles gmail com  2008-07-07 12:33 -------
Andi,

Yes, it's ound like impossible to separate single and double click behaviours

This is my proposal : always handle single click and ignore double like this:

bool ImageDescEditTab::eventFilter(QObject* obj, QEvent* e)
{
    if (obj == d->tagsView->viewport())
    {
        if (e->type() == QEvent::MouseButtonDblClick)
            return true;

        if (e->type() == QEvent::MouseButtonPress)
        {
...
}

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130906         




------- Additional Comments From andi.clemens gmx net  2008-07-07 12:41 -------
Ok, but now double-click will not collapse the tree anymore... Maybe there is another way... but right now I'm too busy to think about it, maybe later...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel