[Digikam-devel] [Bug 128231] New: A way to view pictures recursively in albums and sub-albums at the same time would be cool

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From aironmail gmail com  2007-11-20 23:33 -------
Well, it's ready. I had a little problem applying the patch (after updating the svn), in particular for the file digikam/albumsettings.cpp. The rejected piece is:

cat digikam/albumsettings.cpp.rej
***************
*** 177,183 ****
                                    "*.png *.gif *.bmp *.xpm *.ppm *.pnm *.xcf *.pcx";

      d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
-                                 "*.avi *.mov *.wmf *.asf *.mp4";

      d->defaultAudioFilefilter   = "*.ogg *.mp3 *.wma *.wav";

--- 179,185 ----
                                    "*.png *.gif *.bmp *.xpm *.ppm *.pnm *.xcf *.pcx";

      d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
+                                   "*.avi *.mov *.wmf *.asf *.mp4";

      d->defaultAudioFilefilter   = "*.ogg *.mp3 *.wma *.wav";



As you see something really minour, caused because the latest svn version includes the addition of '*.3gp' in the movie filters, so the lines are:

    d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
                                  "*.avi *.mov *.wmf *.asf *.mp4 *.3gp";


Well, that was the only patching problem, I checked manually that the rest was OK.

Now the testing. I found the two toggle buttons that you have mentioned.

When turning on "Include Album Sub-Tree", it displayes correctly the subalbums. They're correctly listed when sorting by date of by name.

The option that I think that doesn't work is the one about the Include Tag Sub-Tree.

I have the albums:

Album1
+SubAlbum1

And the Tags:
Tag1
+SubTag1

In Album1 I apply SubTag1 to one image.
In SubAlbum1 I apply SubTag1 to one image and Tag1 to another.

Experiment 1:
- I click in SubAlbum1 to display its images. I turn on the "Include Tag Sub-Tree" and I keep disabled the "Include Album Sub-Tree" option.
- I select Tag1.
Result: Only one image is displayed, the one tagged with Tag1, but no the other one with SubTag1.
Expected: Two images listed, one tagged with Tag1 and another with SubTag1.

Experiment 2:
- I click on the same album (SubAlbum1)
- I select the two tags.
Result: All tagged images are displayed.

Experiment 3:
- I click on Album1.
- I select SubTag1.
- I turn on the two toggle buttons.
Result: The two tagged images with SubTag1 are listed.

Experiment 4:
- I click on Album1.
- I select Tag1.
- I turn on the two toggle buttons.
Result: Only one image is displayed, the one tagged with Tag1.
Expected: Three images, the one tagged with Tag1 and the two ones tagged with SubTag1.


So, there are some problems displaying recursively the sub tags. But for the sub albums, without using tags, everything works nicely.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From aironmail gmail com  2007-11-20 23:35 -------
I suppose that my patching problem is the one that Mikolaj described and fixed by Arnd.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-21 00:06 -------
Works OK.

On my system it wasn't turned on default. Not sure if this is case of
existing configuration files. It should be turned on by default.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-21 05:44 -------
Mik,

I'm not agree, the deafult behaviours must be the same than old version (i think)

this is not really a problem : settings is saved between digiKam session...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-11-21 08:39 -------
Antonio, Mikolaj, thanks a lot for testing!

For the tags sub-tree the default should
be activated (because that corresponds to the previous behaviour). I will
change that in the final iteration of the patch.

Antonio, when you write "I select Tag1.", do you mean you select that
tag in the tags-filter in the right sidebar?
The recursive display of tags (more precisely: of images which are associated
with  a tag) only applies to selecting tags in the left side-bar.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From aironmail gmail com  2007-11-21 09:48 -------
Arnd, yes, exactly, on the right sidebar. I didn't know that it only was applied to the left one. I can try again this evening with the left side bar if you need it.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-22 07:42 -------
Mik, Gerhard,

The new actions from View menu don't have a default shortcuts. It can be nice to have one. Any suggestions ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         
baumhaus691 onlinehome de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From baumhaus691 onlinehome de  2007-11-22 16:15 -------
*** This bug has been confirmed by popular vote. ***
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-11-22 20:39 -------
SVN commit 740197 by abaecker:

New feature: Recursive display of sub-albums and sub-tags,
which can be selected by the user.

CCBUGS: 128231
TODO:KDE4PORT



 M  +2 -1      NEWS  
 M  +22 -2     digikam/albumlister.cpp  
 M  +3 -0      digikam/albumlister.h  
 M  +6 -3      digikam/albummanager.cpp  
 M  +31 -0     digikam/albumsettings.cpp  
 M  +6 -0      digikam/albumsettings.h  
 M  +41 -0     digikam/digikamapp.cpp  
 M  +3 -0      digikam/digikamapp.h  
 M  +4 -0      digikam/digikamappprivate.h  
 M  +3 -1      digikam/digikamui.rc  
 M  +2 -0      digikam/dio.cpp  
 M  +1 -0      digikam/welcomepageview.cpp  
 M  +112 -59   kioslave/digikamalbums.cpp  
 M  +4 -0      kioslave/digikamdates.cpp  
 M  +4 -0      kioslave/digikamsearch.cpp  
 M  +30 -10    kioslave/digikamtags.cpp  
 M  +3 -1      utilities/batch/imageinfojob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=740197
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles,

Personally I don't think that things would be changed very often.

IMO better thing would be auxiliary menu/tool bar (a la FotoStation and
AFAIR IMatch) at the top of album view with album gui options: sorting,
sub-(tags|albums). Maybe move filtering there in future or exactly
reverse: put those mini-menus in status bar.

here is the screenshot:

http://mac.softpedia.com/screenshots/10-489_1.png

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-22 23:19 -------
Gilles,

Personally I don't think that things would be changed very often.

IMO better thing would be auxiliary menu/tool bar (a la FotoStation and
AFAIR IMatch) at the top of album view with album gui options: sorting,
sub-(tags|albums). Maybe move filtering there in future or exactly
reverse: put those mini-menus in status bar.

here is the screenshot:

http://mac.softpedia.com/screenshots/10-489_1.png
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From gerhard kulzer net  2007-11-23 09:36 -------
I propose Ctrl+B as a short-cut.
Contrary to Mikolaj I will use it often. This is mainly due to my organizing the albums with subdirs JPG and RAW, as configured in the camera CUI.

But I would suggest (even more so if there's a short-cut) to reduce the menu to 1 entry that works both on tags and albums. Otherwise we'd need two short-cuts
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From marcel.wiesweg gmx de  2007-11-25 22:23 -------
SVN commit 741557 by mwiesweg:

Forward-port the backend part of Arnd's recursive listing patch

CCBUGS: 128231


 M  +66 -34    imagelister.cpp  
 M  +13 -5     imagelister.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=741557
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From marcel.wiesweg gmx de  2007-11-25 22:24 -------
SVN commit 741558 by mwiesweg:

Forward port the frontend part of Arnd's recursive listing patch

CCBUGS: 128231


 M  +30 -17    digikam/albumlister.cpp  
 M  +4 -0      digikam/albumlister.h  
 M  +6 -3      digikam/albummanager.cpp  
 M  +31 -1     digikam/albumsettings.cpp  
 M  +6 -0      digikam/albumsettings.h  
 M  +28 -0     digikam/digikamapp.cpp  
 M  +3 -0      digikam/digikamapp.h  
 M  +4 -0      digikam/digikamappprivate.h  
 M  +3 -1      digikam/digikamui.rc  
 M  +5 -1      kioslave/digikamalbums.cpp  
 M  +3 -0      kioslave/digikamtags.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=741558
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-12-02 22:29 -------
About the recursive view of albums and recursive view of tags:

Somehow I have the feeling that the interface is not done as intuitive
as it could be. Namely, for the list of albums (left side-bar),
and recursive view activated, consider
a)
  - Album 1
    - Subalbum A
    - Subalbum B

  clicking on Album1 will show the contents of Album 1 and Subalbum A and B.
   Visually, wouldn't it make sense, to also mark Subalbum A and Subalbum B
   as selected?
b) For the collapsed situation
  + Album 1
  clicking on Album1, wouldn't it make sense to always display
  the contenta of Album 1 and Subalbum A and B, even if the recursive view
  is not active?
The same approach would also apply to the selection of tags.

Somehow this would mean to move this from a way the view works
to the way in which the selection is done.
Note that this is to some extent also related to
http://bugs.kde.org/show_bug.cgi?id=140743
http://bugs.kde.org/show_bug.cgi?id=144337
http://bugs.kde.org/show_bug.cgi?id=126871
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[lamyseba]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From lamyseba hotmail com  2007-12-03 14:01 -------
Arnd Baecker a écrit :
[bugs.kde.org quoted mail]
If you to this, you have to be sure you will still be able to select
easily subalbumA after Having selected Album1. (sometimes it is
difficult to select an item that belong to a group already selected)

> b) For the collapsed situation
>   + Album 1
>   clicking on Album1, wouldn't it make sense to always display
>   the contenta of Album 1 and Subalbum A and B, even if the recursive view
>   is not active?
> The same approach would also apply to the selection of tags.
>
> Somehow this would mean to move this from a way the view works
> to the way in which the selection is done.
> Note that this is to some extent also related to
> http://bugs.kde.org/show_bug.cgi?id=140743
> http://bugs.kde.org/show_bug.cgi?id=144337
> http://bugs.kde.org/show_bug.cgi?id=126871
>
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-12-05 19:15 -------
Created an attachment (id=22364)
 --> (http://bugs.kde.org/attachment.cgi?id=22364&action=view)
Enable Go To, if the destination album is different

When the recursive album view is activated, it should be possible
to go to the album (to which an image belongs), if it is different
from the currently selected album.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-12-05 19:19 -------
Arnd,

Your patch only support PAlbum... But TAlbum support also reccursive mode, and goto operation can be done in this case...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-12-05 20:07 -------
Yes, but currently the "Go To Tags" is only
disabled, if there are no tags at all.
So this is a bit different (more complicated?),
because essentially the currently selected Tag
has to be taken out of the list of displayed tags.

Is this worth the effort?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From Julien.Narboux inria fr  2007-12-06 09:37 -------
There are still a few bugs, with current svn (kde3 branch rev 745513)
When this is enabled ("include album sub tree" is clicked).

- If I move a picture to a sub folder using drag and drop then the view is not updated.
- If I move a picture form a subfolder to another brother subfolder then the view is not updated.
- If I try to move a picture from a subfolder to itself it is possible and says file already exist. I think this should be impossible.
- Wish : I would be nice to be able to move pictures from subfolders to subfolders by drag and drop inside the album view.

Anyway it is nice work ! thanks all.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel