[Digikam-devel] [Bug 128231] New: A way to view pictures recursively in albums and sub-albums at the same time would be cool

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-17 17:01 -------
> I'm agree for the default behaviour... but i think we need a new option
> from setup to change it. Right ?

I am not sure. But if it has to be configurable it should be done from
one of setup dialogs to not clutter menus.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-17 19:07 -------
1:1 in opinions, developer wins ;)

Let it be in menus.

Still think it should go into main configuration. Especially when in
future there will be possibility to merge subalbums in one virtual
folder. This should be all configurable. IMO it would be easier to
manage all combinations when they would be put in one place, not
dispersed between various menus.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-11-17 20:22 -------
Mikolaj, I don't distinguish between between developers or users
opinions (I consider myself more of a user ...); of course in the end
someone has to write the code, which might lead to one instead of
the other solution ;-).

Still, it is important to do things "right", so let me explain
my reasons for having a menu entry in a bit more detail:
When it comes to the configurability of features/appearance it
is in my opinion important to distinguish between settings which are
a) only changed very infrequently
b) changed more often.
Those which are changed more often should be quickly accessible via menus
and not hidden in the configuration dialogue.

Showing (or not showing) sub-albums and sub-tags is for me definitively an example of a setting, which I would really change frequently.
E.g., consider an event, where some friends also took images.
One way of organizing images is Event/IMG_????.jpg (own images) Event/Friend1/img_????.png Event/YouKnowWho/img_????.cr2
Depending on what I want to show, I would like to display all images, including
those in the sub-folders, or just my images.
Therefore I would prefer to have a quick way of changing this.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-17 20:27 -------
Mik,

I'm agree with Arn. Look like it's the same behaviour with Tag pop-up menu from Caption & Tags side bar. You have a settings to "Toogle Auto" tags selection.

Also, in Tags Filter sidebar pop-up menu, you have a "Matching Condition" settings.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[lamyseba]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From lamyseba hotmail com  2007-11-18 11:46 -------
Created an attachment (id=22104)
 --> (http://bugs.kde.org/attachment.cgi?id=22104&action=view)
screenshot of the place where suggested to put the button for switching

As I saw this kind of UI on other software and I find it great:
Just click a little button at the bottom of the folder list to switch between
recursive and non-recursive behaviour.
This does not forbid putting this feature also in a menu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-18 14:26 -------
Sebastien,

This position will not respect the layout between the status bar and the album folderview. Also, in current implementation, there are new filters on status bar :

- rating filter
- type mime filter
- text filter (under construction on my computer - see B.K.O file #110136)

A fresh screenshot here :

http://digikam3rdparty.free.fr/Screenshots/searchbarconcept.png

A better place for a button is on the top of folder view, on the right of sidebar tab title where you can already seen "My Albums".

Also, like Arnd said previously, we can do the same for tags view.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From marcel.wiesweg gmx de  2007-11-18 15:58 -------
For the KDE4 branch, the patch applies at a different place (libs/database/imagelister.cpp) and will be shorter, it's fine for me, I can port it.
The config option (regardless what you decide on where and how) can probably be ported straightforward to  KDE4, I would want to have this information in AlbumLister::openAlbum() so it can be passed to the IO job.

For tags, there is no real change there, or did I miss something? Tags are listed recursively already.

Note that the wish "merge all in one view, no categories" addresses a different level, that is a problem of the icon view class.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-11-18 16:20 -------
> For tags, there is no real change there, or did I miss something? Tags are listed recursively already.


In the commented out code in digikamtags.cpp one
has the opposite variant of just showing images precisely
matching a tag.
This gives both for tags and for folders the options
of either showing them recursively or not.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-18 21:17 -------
OK, I accept arguments.

Unfortunately I have to report bug.

Let's create three albums on the same level, not nested:
Paris, Paris 2005, Paris 2007.

If I choose "Paris" I see pictures from all three albums.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22098|0                           |1
        is obsolete|                            |



------- Additional Comments From arnd.baecker web de  2007-11-18 21:45 -------
Created an attachment (id=22110)
 --> (http://bugs.kde.org/attachment.cgi?id=22110&action=view)
corrected patch

Thanks a lot for finding that bug (good test case!).
The attached patch should solve it.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From arnd.baecker web de  2007-11-19 12:35 -------
There is maybe one issue with that solution: it uses "/" in the path
separator. According to the Qt docs this is ok, if "/" is throughout the code.

Another option would be:
       urlWithTrailingSlash = QDir::cleanDirPath(kurl.path(1));
however, the previous line does not work, because cleanDirPath
removes the trailing / again ...
   
This following one works (for me), but there must have been a reason
to use url = QDir::cleanDirPath(kurl.path()); instead
of url = kurl.path() ??    
    urlWithTrailingSlash = kurl.path(1);

To me this sounds like the best approach
(but this is in ignornance of why cleanDirPath would be relevant here).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-19 17:28 -------
Second patch works for me.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-19 21:37 -------
Found another problem. At least for me this is strange behaviour:

We have tree:

Balbum
 Aalbum
 Calbum

In all three are images. When you click on Balbum you will see contents of all three albums as requested. But they will be sorted in order:

Aalbum
Balbum
Calbum

Seeing structure of files I would expect to see order:

Balbum
Aalbum
Calbum

Hmm, it goes more messy with deep structure. Would it be easier to find album when sorted alphabetically according to their name, or sorted alphabetically by branch?

I think this is worth some discussion
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22110|0                           |1
        is obsolete|                            |



------- Additional Comments From arnd.baecker web de  2007-11-20 21:10 -------
Created an attachment (id=22133)
 --> (http://bugs.kde.org/attachment.cgi?id=22133&action=view)
major revision of the patch withfull GUI integration

Now the option for the recursive view of albums/tags
is also integrated in the GUI (thanks a lot to Gilles for a nice patch
ping-pong).

Please test thorougly and report any issues!
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-20 21:17 -------
To all in this room,

This is URGENT. If you want to see this great feature implemented in 0.9.3 final release, please test.

i18n freeze is not yet done, but if we can finalize this patch before that, we cannot integrate it in svn...

We have delayed a little i18n freeze for that, but we cannot re-iterate this to infine. Release plan must be respected (:=)))

Thanks in advance for your help

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-20 21:20 -------
if we can finalize this patch before that ==> if we cannot finalize this patch before that (:=))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From aironmail gmail com  2007-11-20 22:09 -------
I'm applying the patch now and recompiling, I'll let you know how it works for me as soon as possible.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From caulier.gilles gmail com  2007-11-20 22:14 -------
Antonio,

Go to View menu from Album gui. there is 2 new option to toogle on/off settings to display recursive albums or tags folders contents...

Look these screenshot :

http://digikam3rdparty.free.fr/Screenshots/subalbumsandsubtagssupport.png

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From mikmach wp pl  2007-11-20 22:58 -------
Trying to apply patch but:

patching file digikam/albumsettings.cpp
Hunk #2 FAILED at 179.
1 out of 6 hunks FAILED -- saving rejects to file
digikam/albumsettings.cpp.rej

mikolaj localhost extragear/graphics/digikam $ svn info
digikam/albumsettings.cpp
Version: 739339

OK. Checked albumsettings.cpp.rej. This is  just stuff about default
formats. Nothing crucial for   this patch. Compiling.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22133|0                           |1
        is obsolete|                            |



------- Additional Comments From arnd.baecker web de  2007-11-20 23:10 -------
Created an attachment (id=22138)
 --> (http://bugs.kde.org/attachment.cgi?id=22138&action=view)
corrected patch

not sure why this got screwed...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel