[Digikam-devel] [Bug 127377] New: Restoration filter (CIMG) does not function properly

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         
           Summary: Restoration filter (CIMG) does not function properly
           Product: digikamimageplugins
           Version: 0.9.0-svn
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: mwieser gmx de


Version:           0.9.0-svn (using KDE 3.5.2 Level "a" , SUSE 10.0 UNSUPPORTED)
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.13-15.8-default

I use digikam svn.
If I open an image and select "Fix/Restoration" the restoration plugin appears.
The preview shows a strong smear and denoise effect. Selecting another preset "Reduce jpeg artefacts", "reduce uniform noise",... and pressing "Try" does not change anything. The values in the "smoothing" tab still are the same.
Reducing the smoothing factor by a factor of ten leads to usable denoising effects.

So I think there are actually two bugs:
- The presets do not work
- and if they would work the default should be reduce uniform noise" or "Reduce jpeg artefacts" but not "none".
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         




------- Additional Comments From mwieser gmx de  2006-05-23 22:36 -------
Additional Comment:

Newer versions of the cimg lib have much improved image restoration capabilities. How difficult is it to update this plugin to the algorithms from the cimg 1.13 lib?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Restoration
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         




------- Additional Comments From arnd.baecker web de  2007-03-07 09:47 -------
There was just a longer thread on slashdot
http://slashdot.org/articles/07/03/06/0018252.shtml
The examples shown at http://www.greyc.ensicaen.fr/~dtschump/greycstoration/
are indeed impressive.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         




------- Additional Comments From caulier.gilles gmail com  2007-03-07 09:56 -------
Arnd,

I have been contacted yesterday by CIMg author (he is a French guy) to ping me about the new GreyCStoration 2.5 algorithm released recently. This one is used by Restoration, Inpainting, and Blowup image editor plugins.

I have planed to update it with digiKam 0.9.2. It's not a trivial task, but like i have already do that in the past, it's not really a problem, but just a question of time...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127377         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2007-03-12 16:06 -------
SVN commit 641768 by cgilles:

digiKam from trunk : new version of Photograph Restoration tool using the new version of CImg library (1.1.9)

- Add a new CImg interface dedicaced to Greycstoration algorithm, based on the old CImgIface class. The code do not include the Greycstoration algorithm. This one in included into CImg library now. It more simple and more easy to update for the future.
- Code polish everywhere. add a new container to store greycstoration settings.
- Added a new Greycstoration widgets. It's used by Restoration, and later by Inpainting and Blowup plugins.
- The Greycstoration algorithm is more fast and more optimized to reduce memory allocation.

TODO :

- The settings have changed. In restoration the 3 presets of settings are disable because we need to investiguate witch values we must use with this settings. To remeber the Restoration presets shortcuts to end-users about specific restoration jobs : Reduce Uniform Noise, Reduce JPEG Artefacts, and Reduce Texturing. Help require !
- The document of Restoration plugin need a big update, especially about the settings descriptions.
- The Inpainting and Blowup plugins must be ported to the new Greycstoration interface.

NOTA: important urls to read :

Greycstoration algorithm settings descriptions : http://www.greyc.ensicaen.fr/~dtschump/greycstoration/guide.html
Greycstoration algorithm demonstration : http://www.greyc.ensicaen.fr/~dtschump/greycstoration/demonstration.html

David, Gerhard, Mike, please help me to find the right settings to use with Restoration presets. Thanks in advance

CCMAIL: David.Tschumperle greyc ensicaen fr
CCMAIL: mvoorberg yahoo com
CCMAIL: gerhard kulzer net
CCMAIL: digikam-devel kde org

BUG: 127377


 M  +1 -1      common/Makefile.am  
 M  +2 -2      common/cimgiface/Makefile.am  
 A             common/greycstoration (directory)  
 AM            common/greycstoration/CImg.h   [POSSIBLY UNSAFE: scanf,system] [License: UNKNOWN]
 AM            common/greycstoration/LICENSE.txt  
 A             common/greycstoration/Makefile.am  
 AM            common/greycstoration/greycstoration.h   [License: UNKNOWN]
 AM            common/greycstoration/greycstorationiface.cpp   [License: GPL]
 AM            common/greycstoration/greycstorationiface.h   [License: GPL]
 AM            common/greycstoration/greycstorationsettings.h   [License: GPL]
 AM            common/greycstoration/greycstorationwidget.cpp   [License: GPL]
 AM            common/greycstoration/greycstorationwidget.h   [License: GPL]
 M  +2 -4      restoration/Makefile.am  
 M  +65 -225   restoration/imageeffect_restoration.cpp  
 M  +14 -40    restoration/imageeffect_restoration.h
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel