[Digikam-devel] [Bug 127112] New: digikam: Tools -> 'Gamma Adjustment...' fails silently when kgamma is not installed

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127112         
           Summary: digikam: Tools -> 'Gamma Adjustment...' fails silently
                    when kgamma is not installed
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: ach mpe mpg de


Version:           0.8.2-rc1 (using KDE 3.5.2, Kubuntu Package 4:3.5.2-0ubuntu14 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-22-686

At least kde 3.5.2 kcmshell returns no error when a kcm module is not found:

$ kcmshell kgamma && echo okay
kcmshell (kdelibs): WARNING: Could not find module 'kgamma'.
okay

Therefore Tools -> 'Gamma Adjustment...' gives no error msg
when kgamma is not installed, because the return status
check is okay.

Achim
P.S. FWIW: in Kubuntu, kgamma is replaced by the displayconfig
module from guidance
 http://www.simonzone.com/software/guidance/#screenshots
therefore kgamma is not installed by default.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127112         




------- Additional Comments From ach mpe mpg de  2006-05-11 01:40 -------
See also: https://launchpad.net/products/digikam/+bug/44122
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127112         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Albums GUI
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=127112         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles kdemail net  2006-12-12 09:04 -------
SVN commit 612662 by cgilles:

digikam from trunk : fix kgamma to display module from KDE control center
BUG: 127112

 M  +7 -7      digikamapp.cpp  
 M  +1 -1      digikamapp.h  
 M  +2 -2      digikamui.rc  


--- trunk/extragear/graphics/digikam/digikam/digikamapp.cpp #612661:612662
 @ -753,13 +753,13  @
                                    actionCollection(),
                                    "help_tipofday");
 
-    mGammaAdjustmentAction = new KAction(i18n("Gamma Adjustment..."),
+    mGammaAdjustmentAction = new KAction(i18n("Display Adjustment..."),
                                    "kgamma",
                                    0,
                                    this,
-                                   SLOT(slot_gammaAdjustment()),
+                                   SLOT(slotDisplayAdjustment()),
                                    actionCollection(),
-                                   "gamma_adjustment");
+                                   "display_adjustment");
 
     // -- Rating actions ---------------------------------------------------------------
 
 @ -1056,18 +1056,18  @
     mImageExifOrientationActionMenu->setEnabled(val);
 }
 
-void DigikamApp::slot_gammaAdjustment()
+void DigikamApp::slotDisplayAdjustment()
 {
    QStringList args;
    QString *perror = 0;
    int *ppid = 0;
 
-   args << "kgamma";
+   args << "display";
    int ValRet = KApplication::kdeinitExec(QString::fromLatin1("kcmshell"), args, perror, ppid);
 
    if ( ValRet != 0 )
-      KMessageBox::error(this, i18n("Cannot start \"KGamma\" extension from KDE control center;\n"
-                                 "please check your installation."));
+      KMessageBox::error(this, i18n("Cannot start \"Display\" configuration panel from KDE control center;\n"
+                                    "please check your installation."));
 }
 
 void DigikamApp::slot_exit()
--- trunk/extragear/graphics/digikam/digikam/digikamapp.h #612661:612662
 @ -135,7 +135,7  @
     void slot_exit();
     void slotShowTip();
     void slotShowKipiHelp();
-    void slot_gammaAdjustment();
+    void slotDisplayAdjustment();
 
     void slotAboutToShowForwardMenu();
     void slotAboutToShowBackwardMenu();
--- trunk/extragear/graphics/digikam/digikam/digikamui.rc #612661:612662
 @ -1,5 +1,5  @
 <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
-<kpartgui version="10" name="digikam" >
+<kpartgui version="11" name="digikam" >
 
  <MenuBar>
 
 @ -73,7 +73,7  @
       <Separator/>
         <ActionList name="album_actions"/>
       <Separator/>
-        <Action name="gamma_adjustment" />
+        <Action name="display_adjustment" />
         <ActionList name="tool_actions"/>
       <Menu name="BatchProcesses"><text>&amp;Batch Processes</text>
         <ActionList name="batch_actions"/>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel