[Digikam-devel] [Bug 121370] New: Can't save images sometimes after some modifications

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         
           Summary: Can't save images sometimes after some modifications
           Product: digikam
           Version: unspecified
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: krienke uni-koblenz de


Version:           0.9 (using KDE KDE 3.5.0)
Installed from:    SuSE RPMs
Compiler:          gcc 4
OS:                Linux

In digikam 0.9 Revision 505718 after some image modifications its not possible  to save the image. I get an error dialog "Faild to save image <name> to folder <foldername>".

I saw this after applying Fix->Colors->Autocorrection->Normalize.

Other modifications like fliping the photo will not lead to this problem. The same photo can be saved then.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From caulier.gilles free fr  2006-02-04 18:15 -------
Give me more informations to start digiKam from a console.

Note : I cannot accept any bug report about 0.9.0 alpha because the code is under development !!!

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rainer Krienke-2]

Am Samstag, 4. Februar 2006 18:15 schrieb Gilles Caulier:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=121370

This is the console output when trying to save the photo:

igikam: SharedLoadingTask
0x85e2468: /home/family/photos/rainer/tmp/dsc_0877.jpg neither in cache nor
loading, loading it now.
digikam: /home/family/photos/rainer/tmp/dsc_0877.jpg : JPEG file identified
digikam: Reading JPEG metadata: APP1 (size=36618)
digikam: SharedLoadingTask 0x85e2468: image loaded, false
/* ----> Here I pressed the save icon */
digikam: Saving to :/home/family/photos/rainer/tmp/K9lRYb.tmp ()
digikam: Dirty: /rainer/tmp
digikam: WARNING: error saving image
'/home/family/photos/rainer/tmp/K9lRYb.tmp
digikam: Dirty: /


> Note : I cannot accept any bug report about 0.9.0 alpha because the code is
> under development !!!

Ok, just for my information: If I find something like the bug above should I
simply post it to this list and use BKO only when 0.90 has left alpha state?

Thanks
Rainer

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From caulier.gilles free fr  2006-02-04 21:17 -------
Give me a copy of your original image to test on my computer (put it on the web to download)

Witch kde/qt release you use ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From krienke uni-koblenz de  2006-02-05 10:50 -------
Am Samstag, 4. Februar 2006 21:17 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

KDE 3.5.0-29 (SuSE-RPMS on suse10.0)
qt  3.3.5-22 (      "     )

Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From krienke uni-koblenz de  2006-02-05 10:53 -------
Am Samstag, 4. Februar 2006 21:17 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

Sorry forgot the link to the photo....

http://www.uni-koblenz.de/~krienke/tmp/dsc_0877.jpg

Have a nice day
Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From krienke uni-koblenz de  2006-02-07 09:27 -------
In between I did an upgrade from KDE 3.5.0 to 3.5.1. The bug is still there so it does not seem to depend on the KDE version.

Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[F.J.Cruz]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From fj.cruz supercable es  2006-02-07 17:06 -------
El S�bado, 4 de Febrero de 2006 21:17, Gilles Caulier escribi�:
[bugs.kde.org quoted mail]
Hi Gilles, I have the same issue. If an image is modified with some transforms
(no all transforms), then I can not save the image.


Paco.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[F.J.Cruz]

El Sábado, 4 de Febrero de 2006 21:17, Gilles Caulier escribió:

> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=121370
>
>
>
>
> ------- Additional Comments From caulier.gilles free fr  2006-02-04 21:17
> ------- Give me a copy of your original image to test on my computer (put
> it on the web to download)
>
> Witch kde/qt release you use ?
>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

Hi Gilles, I have the same issue. If an image is modified with some transforms
(no all transforms), then I can not save the image.


Paco.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From mikmach wp pl  2006-02-07 17:32 -------
Have the same problem in trunk. After core mods (not digikamimageplugins) images are saved, after others - not.


----------------------------------------------------
Harry Potter i Ksi��� P�krwi
NIEZIEMSKI KONKURS i czarodziejskie gad�ety!
http://klik.wp.pl/?adr=http%3A%2F%2Fwww.harrypotter.wp.pl&sid=653

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 7 Février 2006 17:10, F.J.Cruz a écrit :

> El Sábado, 4 de Febrero de 2006 21:17, Gilles Caulier escribió:
> > ------- You are receiving this mail because: -------
> > You are the assignee for the bug, or are watching the assignee.
> >
> > http://bugs.kde.org/show_bug.cgi?id=121370
> >
> >
> >
> >
> > ------- Additional Comments From caulier.gilles free fr  2006-02-04 21:17
> > ------- Give me a copy of your original image to test on my computer (put
> > it on the web to download)
> >
> > Witch kde/qt release you use ?
> >
> > Gilles
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> Hi Gilles, I have the same issue. If an image is modified with some
> transforms (no all transforms), then I can not save the image.
>

Yes, i can reproduce it... I will trying to fix it... but actually i'm sick...
Sorry (:=)))

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 7 Février 2006 17:32, Mikolaj Machowski a écrit :
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=121370
>
>

Something is wrong in savingcontextcontainer class about save operation, not
saveas (somebody can confirm that ?).

The tmp file created to save image is empty. I'm suspect an uninitialized
member of the class. this is why sometime it's working, sometime no... There
is no depency between save code and plugin.

Marcel can you check that please...

Gilles (who going to bed... too sick...)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From krienke uni-koblenz de  2006-02-08 09:20 -------
Yes "save as" does work whereas a simple "save" does not.

But for me it happens every time I apply the Autocorrection->Normalize filter but it happened never when I tried to flip the photo. So there seems to be some kind of dependency on the tool beeing used. It does not look like random behaviour.

Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From marcel.wiesweg gmx de  2006-02-09 21:03 -------
SVN commit 507673 by mwiesweg:

First part of the fix for 121370, only curing symptoms

- try harder finding a mimetype in DImgInterface
- remove const char usage, use QString (not part of the fix)

CCBUG: 121370


 M  +7 -5      libs/dimg/dimg.cpp  
 M  +1 -1      libs/dimg/dimg.h  
 M  +1 -1      libs/threadimageio/loadsavetask.cpp  
 M  +16 -6     utilities/imageeditor/canvas/dimginterface.cpp  


--- trunk/extragear/graphics/digikam/libs/dimg/dimg.cpp #507672:507673
 @ -238,14 +238,16  @
     return false;
 }
 
-bool DImg::save(const QString& filePath, const char* format, DImgLoaderObserver *observer)
+bool DImg::save(const QString& filePath, const QString& format, DImgLoaderObserver *observer)
 {
     if (isNull())
         return false;
-    
-    QString frm = QString::fromLatin1(format);
-    frm = frm.upper();
-    
+
+    if (format.isEmpty())
+        return false;
+
+    QString frm = format.upper();
+
     if (frm == "JPEG" || frm == "JPG")
     {
         JPEGLoader loader(this);
--- trunk/extragear/graphics/digikam/libs/dimg/dimg.h #507672:507673
 @ -109,7 +109,7  @
     bool        load(const QString& filePath, DImgLoaderObserver *observer = 0,
                      RawDecodingSettings rawDecodingSettings=RawDecodingSettings());
                     
-    bool        save(const QString& filePath, const char* format, DImgLoaderObserver *observer = 0);
+    bool        save(const QString& filePath, const QString& format, DImgLoaderObserver *observer = 0);
 
     bool        isNull()     const;
     uint        width()      const;
--- trunk/extragear/graphics/digikam/libs/threadimageio/loadsavetask.cpp #507672:507673
 @ -325,7 +325,7  @
 
 void SavingTask::execute()
 {
-    bool success = m_img.save(m_filePath, m_format.ascii(), this);
+    bool success = m_img.save(m_filePath, m_format, this);
     m_thread->taskHasFinished();
     QApplication::postEvent(m_thread, new SavedEvent(m_filePath, success));
 };
--- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/dimginterface.cpp #507672:507673
 @ -433,7 +433,7  @
 }
 
 void DImgInterface::saveAs(const QString& file, IOFileSettingsContainer *iofileSettings,
-                           const QString& mimeType)
+                           const QString& givenMimeType)
 {
     d->cmod.reset();
     d->cmod.setGamma(d->gamma);
 @ -443,17 +443,27  @
 
     d->needClearUndoManager = false;
 
+    // Try hard to find a mimetype.
+    QString mimeType = givenMimeType;
+    // This is possibly empty
     if (mimeType.isEmpty())
-        saveAction(file, iofileSettings, d->image.attribute("format").toString());
-    else
-        saveAction(file, iofileSettings, mimeType);
+    {
+        mimeType = d->image.attribute("format").toString();
+        // It is a bug if format attribute is not given
+        if (mimeType.isEmpty())
+        {
+            kdWarning() << "DImg object does not contain attribute \"format\"" << endl;
+            mimeType = QImageIO::imageFormat(d->filename);
+        }
+    }
+    saveAction(file, iofileSettings, mimeType);
 }
 
 void DImgInterface::saveAction(const QString& fileName, IOFileSettingsContainer *iofileSettings,
                                const QString& mimeType)
 {
     kdDebug() << "Saving to :" << QFile::encodeName(fileName).data() << " ("
-              << mimeType.ascii() << ")" << endl;
+              << mimeType << ")" << endl;
 
     if ( mimeType.upper() == QString("JPG") || mimeType.upper() == QString("JPEG") )
        d->image.setAttribute("quality", iofileSettings->JPEGCompression);
 @ -465,7 +475,7  @
        d->image.setAttribute("compress", iofileSettings->TIFFCompression);
 
     d->savingFilename = fileName;
-    d->thread->save(d->image, fileName, mimeType.ascii());
+    d->thread->save(d->image, fileName, mimeType);
 }
 
 void DImgInterface::slotImageSaved(const QString& filePath, bool success)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         




------- Additional Comments From krienke uni-koblenz de  2006-02-10 11:17 -------
Now saving the image works again, but after it has been saved all the EXIF infos are lost.  

Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121370         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From marcel.wiesweg gmx de  2006-02-13 19:21 -------
Commits 508640 and 508653 should have fixed this. Now metadata is always preserved in DImg.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel