Coverty Reports traces...
Locked
12
12
 
|
Hi all, Recently, I receive from Laurent Montel a set of traces about source code analys done with a tool named Coverty Report. This tool, which is not open-source have been aquired by Red Hat to check all implementation include will whole projects from the distro. RH has started to analyse KDE source code, and especially digiKam. I sorted huge trace to remove unsuitable parts and cut digiKam, kipi-plugins, and extralibs reports in separated files. All files are there :
Coverty check if all class members are initialized in constructors, if data or members are used before to be initialized, and if data are used after to be free from memory. The error list found in reports are listed in this PDF: Where sometime reports are not really understable, i found some bugs discovered during source code analyse... I recommend highly to read all report and to fix source code relevant. The analyse have been done against digiKam 3.0.0-RC tarball source code.
I already started to check digiKam source code and fixed some entries. I recommend to all developers to do the same quickly. Thanks in advance Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
Uninitialized variables etc can also be found with the open source tool
cppcheck as well the code analysis tools included in eclipse. Andi On Thu, 24 Jan 2013 18:06:44 +0100, Gilles Caulier <[hidden email]> wrote: > Hi all, > > Recently, I receive from Laurent Montel a set of traces about source code > analys done with a tool named Coverty Report. > > http://www.coverity.com/ > > This tool, which is not open-source have been aquired by Red Hat to check > all implementation include will whole projects from the distro. RH has > started to analyse KDE source code, and especially digiKam. I sorted huge > trace to remove unsuitable parts and cut digiKam, kipi-plugins, and > extralibs reports in separated files. All files are there : > > https://projects.kde.org/projects/extragear/graphics/digikam/digikam-software-compilation/repository/revisions/master/show/project/reports > > Coverty check if all class members are initialized in constructors, if > data > or members are used before to be initialized, and if data are used after > to > be free from memory. The error list found in reports are listed in this > PDF: > > http://www.coverity.com/library/pdf/Coverity_DS_CWMapping_cpp.pdf > > Where sometime reports are not really understable, i found some > bugs discovered during source code analyse... > > I recommend highly to read all report and to fix source code relevant. > The > analyse have been done against digiKam 3.0.0-RC tarball source code. > > I already started to check digiKam source code and fixed some entries. I > recommend to all developers to do the same quickly. > > Thanks in advance > > Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
In reply to this post by Gilles Caulier-4
Hi,
2013/1/24 Gilles Caulier <[hidden email]>: > I recommend highly to read all report and to fix source code relevant. The > analyse have been done against digiKam 3.0.0-RC tarball source code. > > I already started to check digiKam source code and fixed some entries. I > recommend to all developers to do the same quickly. Done (fixes for the panorama plugin where only cleanups in the code). Note that there remain several errors in /tmp/ about the panorama plugin. Those errors do not come from digiKam or Kipi, but from the files generated by the parser GNU Bison or the lexer GNU Flex. Those shouldn't be a problem. Cheers, -- Benjamin. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Thanks Benjamin... Important : 3.0.0 release, planed initialy today is delayed to 6 february, as KDE 4.10... It still free time to continue to review code accordingly with Coverty reports...
Gilles 2013/1/26 Benjamin Girault <[hidden email]> Hi, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
Hi all, as for the ImageShack export plugin the cleanup is done. Victor.
On Sun, Jan 27, 2013 at 11:04 AM, Gilles Caulier <[hidden email]> wrote:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Also, FlashExport clean-up is complete.
It was mostly clean-up, but I've found and fixed 2 undefined behaviors that could lead to unexpected results or crash. -- Veaceslav _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Andi, Do you see that a lots of reports are relevant of Advance Rename tool from digiKam core ? Gilles 2013/1/29 Veaceslav Munteanu <[hidden email]> Also, FlashExport clean-up is complete. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Smit, There are few report about DNLAExport tool and Hupnp libraries... Gilles
2013/1/29 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Marcel, Idem about database implementation from digiKam core. I already started to fixed some issue, but task is huge. Some help are welcome... Gilles
2013/1/29 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
In reply to this post by Gilles Caulier-4
I can not find this anywhere in the digiKam report...?
Andi On Tue, 29 Jan 2013 17:31:39 +0100, Gilles Caulier <[hidden email]> wrote: > Andi, > > Do you see that a lots of reports are relevant of Advance Rename tool > from > digiKam core ? > > Gilles > > > 2013/1/29 Veaceslav Munteanu <[hidden email]> > >> Also, FlashExport clean-up is complete. >> >> It was mostly clean-up, but I've found and fixed 2 undefined behaviors >> that could lead to unexpected results or crash. >> >> >> -- >> Veaceslav >> _______________________________________________ >> Digikam-devel mailing list >> [hidden email] >> https://mail.kde.org/mailman/listinfo/digikam-devel >> _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Andi, Sorry, i'm wrong here, i want mean RemoveRedeyes tool from kipi-plugins, not AdvanceRename from digiKam core... Gilles 2013/1/29 Andi Clemens <[hidden email]> I can not find this anywhere in the digiKam report...? _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
In reply to this post by Gilles Caulier-4
About kipi-plugins reports, i sorted all traces by tools, for a better analyse by developers : It will be nice if each assigned tool will be review before 3.0.0 final release planed on 6 February. We have important trace about : - DLNA export, - RajceExport, - VKontakteExport - PrintImages - ImgurExport - PiwigoExport - PhotoLayoutEditor
- VideoSlideshow - RemoveRedEyes - ExpoBlending - FlickrExport I can personalty manage RawConverter, DNGConverter, and all other few tools reports, but i cannot do at all...
Please review code. Thanks in advance for your help. Gilles 2013/1/24 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
Hi,
2013/1/30 Gilles Caulier <[hidden email]>: > About kipi-plugins reports, i sorted all traces by tools, for a better > analyse by developers : > > https://projects.kde.org/projects/extragear/graphics/digikam/digikam-software-compilation/repository/revisions/master/changes/project/reports/kipiplugins-3.0.0-0.14.rc.fc19.CovertyReport.log > > It will be nice if each assigned tool will be review before 3.0.0 final > release planed on 6 February. > > We have important trace about : > > - DLNA export, > - RajceExport, > - VKontakteExport > - PrintImages > - ImgurExport > - PiwigoExport > - PhotoLayoutEditor > - VideoSlideshow > - RemoveRedEyes > - ExpoBlending > - FlickrExport > > > I can personalty manage RawConverter, DNGConverter, and all other few tools > reports, but i cannot do at all... > > Please review code. Thanks in advance for your help. I've applied changes to libkipiplugins (the last coverty "bug" doesn't look like one). I'll try to fix "bugs" of ExpoBlending since I am already familiar with that part of the code. -- Benjamin. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
Thanks Benjamin... Gilles 2013/1/31 Benjamin Girault <[hidden email]> Hi, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: Coverty Reports traces...
|
|
In reply to this post by Benjamin Girault
Hi,
2013/1/31 Benjamin Girault <[hidden email]>: > I'll try to fix "bugs" of ExpoBlending since I am > already familiar with that part of the code. Done. Cheers, -- Benjamin. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
Thanks Benjamin, It still : - FlickrExport ==> (me) - RajceExport ==> (Lukas Krejci ?)
- GalleryExport ==> (me) - VKontakteExport ==> (Alexander Potashev ?) - PrintImages ==> (Angelo Naselli ?) - ImgurExport ==> (Marius Orcsik)
- PiwigoExport ==> (Frederic Coiffier ?) - DLNAExport ==> (Smit Mehta ?) - RemoveRedEyes ==> (Andi Clemens ?)
- VideoSlideshow ==> (me) - BatchProcessImages ==> (me if time permits) Gilles
2013/2/3 Benjamin Girault <[hidden email]> Hi, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
Hi Gilles,
I have some time today. Would you like me to take a look at BatchProcessImages? Andrew On 03/02/13 17:33, Gilles Caulier wrote: > Thanks Benjamin, > > It still : > > - FlickrExport ==> (me) > - RajceExport ==> (Lukas Krejci ?) > - GalleryExport ==> (me) > - VKontakteExport ==> (Alexander Potashev ?) > - PrintImages ==> (Angelo Naselli ?) > - ImgurExport ==> (Marius Orcsik) > - PiwigoExport ==> (Frederic Coiffier ?) > - DLNAExport ==> (Smit Mehta ?) > - RemoveRedEyes ==> (Andi Clemens ?) > - VideoSlideshow ==> (me) > - BatchProcessImages ==> (me if time permits) > > Gilles > > > 2013/2/3 Benjamin Girault <[hidden email] > <mailto:[hidden email]>> > > Hi, > > 2013/1/31 Benjamin Girault <[hidden email] > <mailto:[hidden email]>>: > > I'll try to fix "bugs" of ExpoBlending since I am > > already familiar with that part of the code. > > Done. > > Cheers, > > -- > Benjamin. > _______________________________________________ > Kde-imaging mailing list > [hidden email] <mailto:[hidden email]> > https://mail.kde.org/mailman/listinfo/kde-imaging > > > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel > Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
Andrew, Yes, please. This will save time for me... (:=))) Thanks in advance Gilles 2013/2/5 Andrew Goodbody <[hidden email]> Hi Gilles, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
Note to all,
I checked other static code parser over digiKam 3.0.0-RC tarball, especially in open source as ccpcheck, Clang, Codan, etc... to see if i can found similar report than Coverity, and i can said that none can be compared to this closed source parser.
Yes, using a closed source program to check open source code can be a strange approach, but analisys results are really good.
Coverity has a Scan opensource program which is used now by all major project that you know, as whole Linux kernel ! so why not to use it too... Note : I plan to buy a Coverity licence at work to parse all old code of project managed in my office (where a lots of developers are left). I have seen that Coverity is used in high level and critical process, as Nuclear plan, Research center as CERN (to found Boson stuff), Bank, etc... It's serious parser/analyser. And i can confirm that reports are sometimes very instructive to found real bugs...
Gilles 2013/2/5 Gilles Caulier <[hidden email]>
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: [Kde-imaging] Coverty Reports traces...
|
|
In reply to this post by Gilles Caulier-4
Done. Let me know if there are any problems.
Andrew On 05/02/13 09:55, Gilles Caulier wrote: > Andrew, > > Yes, please. This will save time for me... (:=))) > > Thanks in advance > > Gilles > > > 2013/2/5 Andrew Goodbody <[hidden email] > <mailto:[hidden email]>> > > Hi Gilles, > > I have some time today. Would you like me to take a look at > BatchProcessImages? > > Andrew > > > On 03/02/13 17:33, Gilles Caulier wrote: > > Thanks Benjamin, > > It still : > > - FlickrExport ==> (me) > - RajceExport ==> (Lukas Krejci ?) > - GalleryExport ==> (me) > - VKontakteExport ==> (Alexander Potashev ?) > - PrintImages ==> (Angelo Naselli ?) > - ImgurExport ==> (Marius Orcsik) > - PiwigoExport ==> (Frederic Coiffier ?) > - DLNAExport ==> (Smit Mehta ?) > - RemoveRedEyes ==> (Andi Clemens ?) > - VideoSlideshow ==> (me) > - BatchProcessImages ==> (me if time permits) > > Gilles > > > 2013/2/3 Benjamin Girault <[hidden email] > <mailto:[hidden email]> > <mailto:[hidden email] > <mailto:[hidden email]>>> > > > Hi, > > 2013/1/31 Benjamin Girault <[hidden email] > <mailto:[hidden email]> > <mailto:[hidden email] > <mailto:[hidden email]>>>: > > > I'll try to fix "bugs" of ExpoBlending since I am > > already familiar with that part of the code. > > Done. > > Cheers, > > -- > Benjamin. > _________________________________________________ > Kde-imaging mailing list > [hidden email] <mailto:[hidden email]> > <mailto:[hidden email] <mailto:[hidden email]>> > https://mail.kde.org/mailman/__listinfo/kde-imaging > <https://mail.kde.org/mailman/listinfo/kde-imaging> > > > > > > _________________________________________________ > Digikam-devel mailing list > [hidden email] <mailto:[hidden email]> > https://mail.kde.org/mailman/__listinfo/digikam-devel > <https://mail.kde.org/mailman/listinfo/digikam-devel> > > Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
«
Return to digikam-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |