[Bug 307885] New: PreviewList not correctly alligned when starting an imageplugin

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

            Bug ID: 307885
          Severity: minor
           Version: 3.0.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: PreviewList not correctly alligned when starting an
                    imageplugin
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Compiled Sources
            Status: NEW
         Component: Auto-Colors
           Product: digikamimageplugins

When I start an imageplugin, e.g. color correction, the preview items in the
filter list are not correctly alligned. Also I'm not able to click on some of
the preview items.

When I resize the toolpanel, the items get re-aligned and I can click on all
the items.

Reproducible: Always

Steps to Reproduce:
1. Open an image in the editor, make sure it has portrait orientation
2. Open "Color->Auto Correction"
Actual Results:  
The filter preview items are not aligned correctly and some items are not
click-able

Expected Results:  
The filter preview items should be aligned correctly

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PreviewList not correctly   |PreviewList not correctly
                   |alligned when starting an   |aligned when starting an
                   |imageplugin                 |imageplugin

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Auto-Colors                 |general

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #1 from Andi Clemens <[hidden email]> ---
Created attachment 74352
  --> https://bugs.kde.org/attachment.cgi?id=74352&action=edit
example

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Image Editor
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Andi,

Widget relevant is in image editor :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/widgets/previewlist.cpp

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #3 from Andi Clemens <[hidden email]> ---
I know, but I haven't found the problem yet so I added the bugreport... :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #4 from Gilles Caulier <[hidden email]> ---
I can reproduce the problem here, and i tried to found the origin.

I force icon size to listview to force layout of icon before to render and plug
thumbs, which are computed by separated thread. This want mean that list view
is show empty before to render preview.

I don't touch yet sizeHintxxx() methods to re-implemented. Perhaps it's the
godd way. What do you think about ?

Or it's a Qt4 bug. I don't know...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #5 from Andi Clemens <[hidden email]> ---
Yes maybe re-implementing the sizeHint method will work... onResize the list is
drawn correctly, so this might be a good way to fix the issue

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |n

--- Comment #6 from Pravesh Gupta <[hidden email]> ---
I am also able to reproduce the bug.

In my mind, a simple solution to this is to make iconSize and gridSize smaller.
I have tried with different combinations and i think the previewList in the
attachment(named 'resizedPreviewList' ) is good to view.
Should it be done?

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #7 from Pravesh Gupta <[hidden email]> ---
Created attachment 79549
  --> https://bugs.kde.org/attachment.cgi?id=79549&action=edit
resizedPreviewList

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #8 from Gilles Caulier <[hidden email]> ---
But it sound like a Qt icon-view canvas refesh which is not call at the right
time... No ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #9 from Gilles Caulier <[hidden email]> ---
If your solution is a turn around the dysfunction, why not...

dysfunction disappear for all tool sidebar size, when you close and reopen it ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #10 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

Please can you elaborate comment 9.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #11 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

It disappears for Auto Correction tool.
And for White Balance Tool it makes more use of the space by displaying 2
images in a row.
But the current problem then comes in White Balance Tool i.e. the 2 consecutive
rows are not wholly displayed.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #12 from Gilles Caulier <[hidden email]> ---
1 / Open tool including PreviewList
2/ Change width of sidebar including tool settings (reduce, increase)
3/ close tool
4/ re-open tool and check if preview icon are aligned.
5/ try again to 1/

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Don't forget one point.

preview are computed outside GUI thread. It's invoke tool filter algorithms to
apply on image and reducing result as thumb.

Of course, depending of complexity of algorithm used, preview can take more and
less time...

This want mean that during thumb computation icon size can be not very well
defined. I suspect a race condition somewhere.

Note : this preview widget is used also in B&W tool... Can you reproduce  ?
It's i think the tool which have the most of thumbs to compute.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #14 from Pravesh Gupta <[hidden email]> ---
Created attachment 79551
  --> https://bugs.kde.org/attachment.cgi?id=79551&action=edit
Auto Correction after Sidebar Resize

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #15 from Pravesh Gupta <[hidden email]> ---
Created attachment 79552
  --> https://bugs.kde.org/attachment.cgi?id=79552&action=edit
Black & White Tool Preview List

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #16 from Pravesh Gupta <[hidden email]> ---
Created attachment 79553
  --> https://bugs.kde.org/attachment.cgi?id=79553&action=edit
Black & White Tool Preview List after Sidebar Resize

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel