[Bug 307885] New: PreviewList not correctly alligned when starting an imageplugin

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #17 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

I have attached attachments of changes in previewList after changing gridSize
and iconSize.
Auto Correction after Sidebar Resize
Black & White Tool Preview List
Black & White Tool Preview List after Sidebar Resize

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79549|resizedPreviewList          |resizedPreviewList(Auto
        description|                            |Correction after change)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79549|resizedPreviewList(Auto     |resizedPreviewList(Auto
        description|Correction after change)    |Correction Tool Preview
                   |                            |List)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #18 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

Image thumbnails in the preview List does not resize when width of sidebar is
changed.
But if we set imageThumbnail size to 96*96, even then whole previews of B&W
Tool can not be represented in single view, so to view other previews of B&W we
have to scroll down . The height of the grid Area in B&W preview is to be
increased some more or images should be around size 90*90, so that at least 2
rows can be displayed at a time.
But if we do this, then Image Previews in the Auto ColorCorrection Tool becomes
very small as compared to the area allocated to them and thus looks somewhat
odd.

So I think icon size (96*96), and gridSize as (125, 96+font().height()) is
fine. At least preview List  for Auto Correction Tool is good to view.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #19 from Pravesh Gupta <[hidden email]> ---
Sorry, In my previous comment 18, I told that to view at least 4 images with
their name at around iconSize 90* 90 is required, but it is 70*70.
This size makes Auto Correction Preview List Grid Space not correctly
utitilized, and looks odd.

Is there any other way?

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #20 from Gilles Caulier <[hidden email]> ---
Pravesh,

Please attach a patch of your changes given the best results.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #21 from Pravesh Gupta <[hidden email]> ---
Created attachment 79852
  --> https://bugs.kde.org/attachment.cgi?id=79852&action=edit
Preview List Patch

Hi Gilles,

I am attaching the patch which changes the image icon and grid size. This
corrects preview list for Auto-Corrrection Tool.
Preview List for Black & White Tool is more good to view but still cannot
completely show all the previews in the small space allocated to it.

Please review it.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PreviewList not correctly   |PreviewList not correctly
                   |aligned when starting an    |aligned when starting an
                   |imageplugin                 |imageplugin [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |3.2.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/956d2657180398480bc4f6f
                   |                            |720941edbf7331ef3

--- Comment #22 from Gilles Caulier <[hidden email]> ---
Git commit 956d2657180398480bc4f6f720941edbf7331ef3 by Gilles Caulier.
Committed on 12/05/2013 at 18:31.
Pushed by cgilles into branch 'master'.

apply patch #79852 from Pravesh Gupta
FIXED-IN: 3.2.0

M  +2    -2    utilities/imageeditor/widgets/previewlist.cpp

http://commits.kde.org/digikam/956d2657180398480bc4f6f720941edbf7331ef3

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #23 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

I want to notify that as was in the patch submitted by me setGridSize method
should have QRect of width 125 as it will result in better previewList region
utilization when Black & White Tool is called.

setGridSize(QSize(125, 100 + fontMetrics().height()));

While according to the commit, this objective is not reached.
Please review and correct asap.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=307885

--- Comment #24 from Gilles Caulier <[hidden email]> ---
Git commit 348c231cd6dd50039f3fdc0e065fbc4a8bcfc862 by Gilles Caulier.
Committed on 12/05/2013 at 19:13.
Pushed by cgilles into branch 'master'.

polish icon size

M  +1    -1    utilities/imageeditor/widgets/previewlist.cpp

http://commits.kde.org/digikam/348c231cd6dd50039f3fdc0e065fbc4a8bcfc862

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=307885

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PreviewList not correctly   |PreviewList not correctly
                   |aligned when starting an    |aligned when starting an
                   |imageplugin [patch]         |image editor tool [patch]

--
You are receiving this mail because:
You are the assignee for the bug.