[Bug 307467] New: Missing slide show button in digiKam 3.0.0 beta1

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] New: Missing slide show button in digiKam 3.0.0 beta1

nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

            Bug ID: 307467
          Severity: normal
           Version: 3.0.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Missing slide show button in digiKam 3.0.0 beta1
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: UNCONFIRMED
         Component: general
           Product: digikam

Slide show toolbar button is missing in digiKam 3.0.0 beta1.

Reproducible: Always

Actual Results:  
The only way to run slideshow is from View menu where it still available.

Expected Results:  
Using slide show toolbar button is more convenient than running slideshow from
View menu.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=307467

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |SlideShow

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Do you talk about digiKam simple Slideshow or Advanced Slideshow kipi plugin ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #2 from nucleo <[hidden email]> ---
There is drop down menu appears with both Slideshow and Advanced Slideshow when
pressing on Slideshow button in digiKam 2.9 but in 3.0 this button missing and
both Slideshow and Advanced Slideshow available only in menu View - Slideshow.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Victor Dodon
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

Victor Dodon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Victor Dodon <[hidden email]> ---
Can you try now and mark this as solved? Thank you.

Victor Dodon.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #4 from nucleo <[hidden email]> ---
(In reply to comment #3)
> Can you try now and mark this as solved? Thank you.

You mean there is some particular commit that fixes bug?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED

--- Comment #5 from Gilles Caulier <[hidden email]> ---
Victor,

Just checked your last commit. It's fixed for 3.0.0-beta2

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #6 from nucleo <[hidden email]> ---
Bug not completely fixed in 3.0.0-beta2 because "Advanced slide show" missing
in drop down "Slideshow" menu as it was in 2.9.0.
"Advanced slide show" still available from View menu.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Victor Dodon
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #7 from Victor Dodon <[hidden email]> ---
@nucleo, in digiKam 3.0.0, plugins can be added to the toolbar(i.e. Advanced
Slideshow can be added directly to the toolbar).
You can see how it looks now:
http://imageshack.us/a/img594/27/shot99.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #8 from nucleo <[hidden email]> ---
By default Advanced Slideshow is not on the panel so  it should be added in
every new Digikam installation. Can it be added on panel by default? Also it
would be nice if Advanced Slideshow will be grouped in Slideshow menu as it was
in previous Digikam versions.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #9 from nucleo <[hidden email]> ---
And this is not obvious how to add plugins on panel.
At first I searched for Advanced slideshow in <digikam> panlel but it was not
there.
It added on digikam panel only when I tried to edit
<kipiplugin_advancedslideshow> panel.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Victor Dodon
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #10 from Victor Dodon <[hidden email]> ---
@nucleo, this is the way that KDE XML-GUI works: to be able to add plugin
actions to the toolbar, now each plugin is a KXmlGuiClient with own actions,
and each client has it's own toolbar, that's why you must select
kipiplugin_advancedslideshow in the Toolbar dropdown.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #11 from nucleo <[hidden email]> ---
If I didn't know that it should be possible to add Advanced slideshow on panel
then I wouldn't guess that I should edit <kipiplugin_advancedslideshow>
toolbar.
Adding plugins should be simplified for example by adding options somewhere in
Kipi-plugins Digikam settings.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Marcel Wiesweg
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #12 from Marcel Wiesweg <[hidden email]> ---
Victor: I'd say the bug is not to explain a complex way (which I for instance
dont understand spontaneously) to add kipi actions manually. We have always
placed this special action in the slide show toolbar drop down. Is it still
there?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307467] Missing slide show button in digiKam 3.0.0 beta1

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=307467

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Git commit 2481d371b619ac6e9cb3dfd7c64a6d64f5c96205 by Victor Dodon.
Committed on 24/10/2012 at 00:21.
Pushed by dodon into branch 'master'.

Add advancedslideshow action to the Slideshow menu. BUGS: 307467 FIXED-IN:
3.0.0

M  +18   -0    utilities/kipiiface/kipipluginloader.cpp

http://commits.kde.org/digikam/2481d371b619ac6e9cb3dfd7c64a6d64f5c96205

diff --git a/utilities/kipiiface/kipipluginloader.cpp
b/utilities/kipiiface/kipipluginloader.cpp
index d6ca604..9c965d2 100644
--- a/utilities/kipiiface/kipipluginloader.cpp
+++ b/utilities/kipiiface/kipipluginloader.cpp
@@ -230,6 +230,13 @@ QList<QAction*>
KipiPluginLoader::kipiActionsByCategory(Category cat) const

 void KipiPluginLoader::slotKipiPluginPlug()
 {
+    // Ugly hack. Remove "advancedslideshow" action from Slideshow menu
+    foreach(QAction* action, d->app->slideShowMenu()->menu()->actions())
+    {
+        if (action->objectName() == "advancedslideshow")
+            d->app->slideShowMenu()->removeAction(action);
+    }
+
     // Delete all action categories
     for (QMap<int, KActionCategory*>::iterator it =
d->kipiCategoryMap.begin();
          it != d->kipiCategoryMap.end();
@@ -315,6 +322,17 @@ void KipiPluginLoader::slotKipiPluginPlug()
             continue;
         }

+        // Ugly hack. Remove "advancedslideshow action from AdvancedSlideshow
plugin
+        // actionCollection() and add it to the Slideshow menu
+        if (plugin->objectName() == QString("AdvancedSlideshow"))
+        {
+            QAction* action =
plugin->actionCollection()->action("advancedslideshow");
+            if (action)
+            {
+                QAction* _action =
plugin->actionCollection()->takeAction(action);
+                d->app->slideShowMenu()->addAction(_action);
+            }
+        }
         d->app->guiFactory()->addClient(plugin);
     }

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel