[Bug 307303] New: delete group of photos problem

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] New: delete group of photos problem

Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

            Bug ID: 307303
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: [hidden email]
           Summary: delete group of photos problem
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: openSUSE RPMs
            Status: UNCONFIRMED
         Component: Albums GUI
           Product: digikam

When I have group of photos, an I use function "Move to Wastebin", group
disappear. After refresh album (go to other one and back again), other photos
from this group are visible, but ungroupped.

Reproducible: Always

Steps to Reproduce:
1. Group some files in album
2. Move group to Wastebin
3. Refresh Album
Actual Results:  
Photos are ungroupped, but only first photo from this is deleted.

Expected Results:  
I don't know what is better:
1. Deleted only first photo (need to fix album refersh)
2. Deleted all files from group (if not this function, i think it's good idea
to add this functionality)


KDE 4.8.5

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Marek Potocki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Smit Mehta
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Smit Mehta <[hidden email]> ---
Hi Marek

I am not able to reproduce it here. Just to be clear, first you open any album,
group images by some property (say format), and then select on the group name
and press "delete". Correct? Or do you do anything else? In any case, a couple
of sceenshots will be best to describe the problem. I would appreciate if you
could attach them here.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Smit Mehta
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #2 from Smit Mehta <[hidden email]> ---
Hi Marek

Sorry, no need to attach any screenshots. I understood the problem. Although I
am not sure that this is a bug or expected behaviour.

@Gilles, Marcel : What do you suggest?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Marek Potocki
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #3 from Marek Potocki <[hidden email]> ---
> I am not able to reproduce it here. Just to be clear, first you open any album,
> group images by some property (say format), and then select on the group name
> and press "delete". Correct?

Correct.
There are slideshow :)

error1.png - I have album with 6 photos
error2.png - I group them (Group selected here)
error3.png - I have one group with 5 subelements
error4.png - I delete group
error5.png - Album is empty
error6.png - I change album to other one
error7.png - I back to first album. Tere are 5 ungroupped photos.

Thats all what I can explain without movie :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Marek Potocki
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #4 from Marek Potocki <[hidden email]> ---
Created attachment 74132
  --> https://bugs.kde.org/attachment.cgi?id=74132&action=edit
error2.png

--- Comment #5 from Marek Potocki <[hidden email]> ---
Created attachment 74133
  --> https://bugs.kde.org/attachment.cgi?id=74133&action=edit
error3.png

--- Comment #6 from Marek Potocki <[hidden email]> ---
Created attachment 74134
  --> https://bugs.kde.org/attachment.cgi?id=74134&action=edit
error4.png

--- Comment #7 from Marek Potocki <[hidden email]> ---
Created attachment 74135
  --> https://bugs.kde.org/attachment.cgi?id=74135&action=edit
error5.png

--- Comment #8 from Marek Potocki <[hidden email]> ---
Created attachment 74136
  --> https://bugs.kde.org/attachment.cgi?id=74136&action=edit
error6.png

--- Comment #9 from Marek Potocki <[hidden email]> ---
Created attachment 74137
  --> https://bugs.kde.org/attachment.cgi?id=74137&action=edit
error7.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 307303] delete group of photos problem

Marcel Wiesweg
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #10 from Marcel Wiesweg <[hidden email]> ---
The bug is quite obvious, grouping is simply not handled in the context of
deletion.
The first idea is to extend DIO::del to include grouped images, but that is not
desirable as not always the whole group shall be deleted.

We must have a look at all places where DeleteDialog is used. Let us ignore
deleting a whole album for the moment, cross-album grouping is too complex to
handle.
We have
1) ImageViewUtilities called from DigikamImageView
2) ImageWindow
3) LighttableWindow

It is fast to check if a picture has grouped images. Loading the actual image
ids is an uncached db query.

Idea for 1): Delete whole group if group is collapsed, delete only selected if
group is expanded. This must be implemented on the level of the view class, as
the filter model knows about collapse/expanded state.
An idea for 2) and 3) would be to extend DeleteDialog with a checkbox (x)
Delete grouped images
and showing/hiding the relevant URLs in the dialog depending on the check
state. This could be extended to 1) as well.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

Gilles Caulier-4
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|delete group of photos      |GROUP : delete group of
                   |problem                     |photos problem

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

René Fritz <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #11 from René Fritz <[hidden email]> ---
This bug is still valid. The workflow is somewhat uncomfortable because of this
bug. Especially when you group your photos by format (jpg+raw).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #12 from [hidden email] ---
René,

Which version of digiKam do you use exactly ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #13 from René Fritz <[hidden email]> ---
Version 4.14 (I didn't try 5.x yet)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.9.0                       |4.14.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Maik Qualmann <[hidden email]> ---
Created attachment 96626
  --> https://bugs.kde.org/attachment.cgi?id=96626&action=edit
groupdelete.patch

A first attempt to solve the problem.
I think the idea 1) by Marcel actually the best. But the table view does not
provide information whether the group is open.

This patch does the following:
1.) Group is closed: All the items of the group are added to the delete list.
2.) Group is open: As 1.) if the leader of the group is selected.
3.) Group is open: The leader of the group and an item of the group is
selected, only two are in the delete list.
4.) Group is open: Item of the group is selected, only the selected item in the
delete list.

We have in digiKam-5.0.0 a nice trash, if it goes wrong.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

--- Comment #15 from [hidden email] ---
Hi Maik,

I tested the patch and it work as expected on my computer.

For the table-view, this is an another problem, more complex to fix. I'm not
sure if a file is open in TableView section about this topic to support Group
feature (and certainly other features).

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem [patch]

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GROUP : delete group of     |GROUP : delete group of
                   |photos problem              |photos problem [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem [patch]

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.0.0
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/f3949424b3e9d3032265840
                   |                            |f3ba7a7089838b71d

--- Comment #16 from Maik Qualmann <[hidden email]> ---
Git commit f3949424b3e9d3032265840f3ba7a7089838b71d by Maik Qualmann.
Committed on 14/01/2016 at 20:20.
Pushed by mqualmann into branch 'master'.

apply patch #96626 to delete all the images of a group
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +31   -2    app/items/imageviewutilities.cpp

http://commits.kde.org/digikam/f3949424b3e9d3032265840f3ba7a7089838b71d

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 307303] GROUP : delete group of photos problem [patch]

bugzilla_noreply
In reply to this post by Marek Potocki
https://bugs.kde.org/show_bug.cgi?id=307303

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|AlbumsView                  |AlbumsView-Group

--
You are receiving this mail because:
You are the assignee for the bug.