[Bug 305823] New: Digikam writes to Samsung RAW files

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

            Bug ID: 305823
          Severity: major
           Version: 2.8.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: Digikam writes to Samsung RAW files
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Archlinux Packages
            Status: UNCONFIRMED
         Component: Metadata
           Product: digikam

I noticed that Digikam writes metadata to Samsung SRW (RAW) files even though I
have the option to write to RAWs unchecked.
Canon CR2 and DNG files are handled as expected (XMP sidecar).
It seems that SRW files are not recognized as RAW.

Reproducible: Always

Steps to Reproduce:
1. Import a SRW file
2. Change metadata or assign a tag
3. Check source folder for XMP sidecar existance or use exiftool to check for
updated metadata directly in the SRW
Actual Results:  
Metadata is written directly to the RAW file which is thus altered (unwanted
behaviour).

Expected Results:  
Have the changes written to a XMP sidecar file.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=305823

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Metadata                    |libkexiv2

--- Comment #1 from Gilles Caulier <[hidden email]> ---
It can depend of which Exiv2 or/and libkexiv2 version you use. Please go to
Help/Components Info and copy & paste the contents here...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #2 from [hidden email] ---
Hello Gilles,
I am using exif2 v. 0.23 and libkexiv2 2.3.0.
I don't know if it is related, but sometimes thumbnail-view filters misbehaved
in the past. Selecting "no RAW" files would still show SOME SRW files...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #3 from Gilles Caulier <[hidden email]> ---
can you turn on KEXIV2, KDCRAW, and digiKam debug spaces into kdebugdialog and
run digikam into a console. Process tage changes to a Samsung raw file and copy
and paste here all trace relevant from the console...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #4 from [hidden email] ---
Here are the relevant parts. First case is a SRW file, the second is a CR2
file.

digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::getXmpTagStringSeq: XMP String Seq (
Xmp.digiKam.TagsList ):  ("Maya")
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::setIptcKeywords:
/home/jarda-wien/temp/exiftool/sam_3987.srw  ==> Iptc Keywords:  Maya,veverka
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: KExiv2::metadataWritingMode 3
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Will write Metadata to file
"sam_3987.srw"
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::KExiv2Priv::saveToFile: File
Extension:  "srw"  is supported for writing mode
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file
"sam_3987.srw" written to file.


digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::getXmpTagStringSeq: XMP String Seq (
Xmp.digiKam.TagsList ):  ("Maya")
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::setIptcKeywords:
/home/jarda-wien/temp/exiftool/casper_IMG_1392.CR2  ==> Iptc Keywords:
Maya,veverka
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: KExiv2::metadataWritingMode 3
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Will write Metadata to file
"casper_IMG_1392.CR2"
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::KExiv2Priv::saveToFile:
"casper_IMG_1392.CR2" is TIFF based RAW file not yet supported. Metadata not
saved.
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file
"casper_IMG_1392.CR2" written to file.
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Will write XMP sidecar for file
"casper_IMG_1392.CR2"
digikam(4063)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file '
"casper_IMG_1392.CR2" ' written to XMP sidecar.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #5 from [hidden email] ---
Created attachment 73582
  --> https://bugs.kde.org/attachment.cgi?id=73582&action=edit
patchfile

I looked at the libkexiv2 sources and found something. I hope it doesn't
introduce any regressions. Note that is is my second patch no anything and that
it's my first day of sending patches...
After applying this patch the debug now says:

digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::setIptcKeywords:
/home/jarda-wien/temp/exiftool/gallery2.SRW  ==> Iptc Keywords:  veverka
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::save: KExiv2::metadataWritingMode 3
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::save: Will write Metadata to file
"gallery2.SRW"
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::KExiv2Priv::saveToFile:
"gallery2.SRW" is TIFF based RAW file supported but writing mode is disabled.
Metadata not saved.
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file
"gallery2.SRW" written to file.
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::save: Will write XMP sidecar for
file "gallery2.SRW"
digikam(30533)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file '
"gallery2.SRW" ' written to XMP sidecar.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #6 from [hidden email] ---
FYI this is the log after ticking the write to RAW (experimental) option:

digikam(30699)/KEXIV2 KExiv2Iface::KExiv2::setIptcKeywords:
/home/jarda-wien/temp/exiftool/gallery1.SRW  ==> Iptc Keywords:  veverka
digikam(30699)/KEXIV2 KExiv2Iface::KExiv2::save: KExiv2::metadataWritingMode 3
digikam(30699)/KEXIV2 KExiv2Iface::KExiv2::save: Will write Metadata to file
"gallery1.SRW"
digikam(30699)/KEXIV2 KExiv2Iface::KExiv2::KExiv2Priv::saveToFile: File
Extension:  "srw"  is supported for writing mode
digikam(30699)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file
"gallery1.SRW" written to file.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=305823

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Štěpánek,

If you don't want to have SRW file touched through metadata, why you add this
type of file in list of support RAW files in writing mode by Exiv2 library with
your patch ?

Andreas,

SRW files are really supported in writing mode with last Exiv2 version ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #8 from [hidden email] ---
Well, my original problem was that digikam was writing metadata in the first
place with no way to disable it. It seemed that write support was there and
working plus look here: http://www.exiv2.org/whatsnew.html#item4 and the
registry in image.cpp says srw read/write support.

A quick grep search found that the srw file format is not mentioned anywhere in
the sources while other formats are so I added it. Until now, it behaves as
expected.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #9 from Marcel Wiesweg <[hidden email]> ---
Gilles: Looking at KExiv2::KExiv2Priv::saveToFile, the list of supported RAW
formats is a) static and b) at the status of exiv2 0.19.1. 0.21 added SRW, 0.23
CR2.

Andreas: Is there a way to query from libexiv2 the RAW formats supported for
writing? Or should we continue to rely on versionNumber() and our knowledge of
the files supported at that time?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #10 from Andreas Huggel <[hidden email]> ---
Marcel, Gilles,

We have this registry
http://dev.exiv2.org/projects/exiv2/repository/entry/trunk/src/image.cpp#L105

And functions ImageFactory::checkMode() and Image::checkMode() to query it.

So for a given image of any type, if Exiv2 can open it (and determine its type
in the process), the idea is that you should be able to use Image::checkMode()
to determine the level of metadata support for the image.

Without an image, you need to know the Exiv2 "image type" of a particular
format, to be able to query ImageFactory::checkMode(), which is not practical,
as it still requires the app to know about Exiv2 internals.

Andreas

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #11 from Marcel Wiesweg <[hidden email]> ---
Thanks Andreas. Two more questions:
- changelog says CR2 is supported for writing, the registry you pointed to says
it is read-only. Does it work?
- CRW does principally not support XMP?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=305823

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |exiv2/0364c48d64a4f492600f9
                   |                            |4f539324b24321a3df7

--- Comment #12 from Marcel Wiesweg <[hidden email]> ---
Git commit 0364c48d64a4f492600f94f539324b24321a3df7 by Marcel Wiesweg.
Committed on 28/09/2012 at 22:40.
Pushed by mwiesweg into branch 'master'.

Rely on Exiv2 to definitely tell us that a file is not supported for writing,
so that newly added support is not ignored, rather than
using a static list of file suffixes.

We keep a static list to apply the "do not write to raw" setting, as the image
mimetype does not reliably identify a RAW image.
The "not supported" list is not used to fail, instead we check the possible
write mode in saveOperations.

M  +47   -19   libkexiv2/kexiv2_p.cpp
M  +1    -1    libkexiv2/kexiv2_p.h

http://commits.kde.org/libkexiv2/0364c48d64a4f492600f94f539324b24321a3df7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=305823

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #13 from Andreas Huggel <[hidden email]> ---
(In reply to comment #11)
> Thanks Andreas. Two more questions:
> - changelog says CR2 is supported for writing, the registry you pointed to
> says it is read-only. Does it work?

That's a bug, the registry should include writing. It works, we have not
received any negative feedback.

> - CRW does principally not support XMP?

Apparently it does. From the exiftool tag doc: "CRW images also support the
addition of a CanonVRD trailer, which in turn supports XMP. This trailer is
created automatically if necessary when ExifTool is used to write XMP to a CRW
image."
Exiv2 does not support that.

Andreas

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #14 from [hidden email] ---
(In reply to comment #12)

I compiled libkexiv2 with the latest patch and the result is that it doesn't
work as expected yet.
This is from digikam 2.9, 3.0 beta 2 and today's git (all the same):

digikam(3660)/KEXIV2 KExiv2Iface::KExiv2::save: KExiv2::metadataWritingMode 3
digikam(3660)/KEXIV2 KExiv2Iface::KExiv2::save: Will write Metadata to file
"gallery1.SRW"
digikam(3660)/KEXIV2 KExiv2Iface::KExiv2::Private::saveToFile: "gallery1.SRW"
is a TIFF based RAW file, writing to such a file is disabled by current
settings.
digikam(3660)/KEXIV2 KExiv2Iface::KExiv2::save: Metadata for file
"gallery1.SRW" written to file.

As you can see the log mentions RAW file writing being disabled, yet it gets
written to...
With the patch that I proposed, everything worked as expected. I understand
that there is a new a approach now and I don't see any errors in the current
implementation but for some reason SRW files are handled R/W even if write to
RAW is disabled in the options.
There is a workaround, the "write to XMP sidecar only" option.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #15 from Marcel Wiesweg <[hidden email]> ---
Git commit ab6f65f2edd4463260dc3cbf4d86075f2f51ca0f by Marcel Wiesweg.
Committed on 11/10/2012 at 20:30.
Pushed by mwiesweg into branch 'master'.

Dont forget to fail if writing to RAW files is switched off

M  +1    -0    libkexiv2/kexiv2_p.cpp

http://commits.kde.org/libkexiv2/ab6f65f2edd4463260dc3cbf4d86075f2f51ca0f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[xstej70]

https://bugs.kde.org/show_bug.cgi?id=305823

--- Comment #16 from [hidden email] ---
Thanks, works like a charm!

(In reply to comment #15)
> Git commit ab6f65f2edd4463260dc3cbf4d86075f2f51ca0f by Marcel Wiesweg.
> Committed on 11/10/2012 at 20:30.
> Pushed by mwiesweg into branch 'master'.
>
> Dont forget to fail if writing to RAW files is switched off
>
> M  +1    -0    libkexiv2/kexiv2_p.cpp
>
> http://commits.kde.org/libkexiv2/ab6f65f2edd4463260dc3cbf4d86075f2f51ca0f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel