[Bug 303427] New: failed build against libgphoto2-2.5.0

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] New: failed build against libgphoto2-2.5.0

nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

            Bug ID: 303427
          Severity: normal
           Version: 2.7.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: failed build against libgphoto2-2.5.0
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Other
            Status: UNCONFIRMED
         Component: general
           Product: digikam

cd
/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu/extra/libkface/test
&& /usr/bin/c++   -D_BSD_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -DQT_NO_STL
-DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS
-DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=21 -DQT_USE_FAST_CONCATENATION
-DQT_USE_FAST_OPERATOR_PLUS -DKDE_DEFAULT_DEBUG_AREA=51005 -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables  -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef
-Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security
-fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common
-Woverloaded-virtual -fno-threadsafe-statics -fvisibility=hidden
-Werror=return-type -fvisibility-inlines-hidden -O2 -DNDEBUG -DQT_NO_DEBUG
-I/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu/extra/libkface/test
-I/builddir/build/BUILD/digikam-2.7.0/extra/libkface/test
-I/builddir/build/BUILD/digikam-2.7.0/extra/libkface
-I/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu/extra/libkface
-I/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu/extra/libkface/libface
-I/builddir/build/BUILD/digikam-2.7.0/extra/libkface/test/../libkface
-I/builddir/build/BUILD/digikam-2.7.0/extra/libkface/test/..
-I/usr/include/kde4 -I/usr/include/kde4/KDE -I/usr/include/KDE
-I/usr/include/phonon -I/usr/include/QtXmlPatterns -I/usr/include/QtXml
-I/usr/include/QtWebKit -I/usr/include/QtUiTools -I/usr/include/QtTest
-I/usr/include/QtSvg -I/usr/include/QtSql -I/usr/include/QtScriptTools
-I/usr/include/QtScript -I/usr/include/QtOpenGL -I/usr/include/QtNetwork
-I/usr/include/QtMultimedia -I/usr/include/QtHelp -I/usr/include/QtDesigner
-I/usr/include/QtDeclarative -I/usr/include/QtDBus -I/usr/include/Qt3Support
-I/usr/include/QtGui -I/usr/include/QtCore -I/usr/include/Qt
-I/usr/lib/qt4/mkspecs/default -I/usr/include/opencv    -D_GNU_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o
CMakeFiles/detect.dir/detect.cpp.o -c
/builddir/build/BUILD/digikam-2.7.0/extra/libkface/test/detect.cpp
make -f extra/libkface/test/CMakeFiles/libfaceGUI.dir/build.make
extra/libkface/test/CMakeFiles/libfaceGUI.dir/depend
/builddir/build/BUILD/digikam-2.7.0/core/utilities/cameragui/devices/gpcamera.cpp:
In member function 'virtual bool Digikam::GPCamera::uploadItem(const QString&,
const QString&, const QString&, Digikam::CamItemInfo&)':
/builddir/build/BUILD/digikam-2.7.0/core/utilities/cameragui/devices/gpcamera.cpp:1335:61:
error: cannot convert 'CameraFile* {aka _CameraFile*}' to 'const char*' for
argument '3' to 'int gp_camera_folder_put_file(Camera*, const char*, const
char*, CameraFileType, CameraFile*, GPContext*)'
make[2]: Entering directory
`/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu'
/usr/bin/cmake -E cmake_progress_report
/builddir/build/BUILD/digikam-2.7.0/i686-redhat-linux-gnu/CMakeFiles
/builddir/build/BUILD/digikam-2.7.0/core/utilities/cameragui/devices/gpcamera.cpp:
In static member function 'static void
Digikam::GPCamera::getSupportedPorts(QStringList&)':
/builddir/build/BUILD/digikam-2.7.0/core/utilities/cameragui/devices/gpcamera.cpp:1654:31:
error: request for member 'path' in 'info', which is of pointer type
'GPPortInfo {aka _GPPortInfo*}' (maybe you meant to use '->' ?)

See full log
http://kojipkgs.fedoraproject.org//work/tasks/7155/4237155/build.log

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=303427

Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Rex Dieter <[hidden email]> ---
confirmed

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #2 from nucleo <[hidden email]> ---
Note that KDE 4.8.97 used in thi build.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Import

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

Wouter de Geus
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Wouter de Geus <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Wouter de Geus <[hidden email]> ---
Just tried this on slackware64-current with KDE 4.8.4 (and libgphoto2-2.5.0)
with the same result.
Since this new libgphoto2 version finally gets rid of the silly 1024 files per
directory limit I'd say it's a very welcome upgrade.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #4 from Marcus Meissner <[hidden email]> ---
Created attachment 72725
  --> https://bugs.kde.org/attachment.cgi?id=72725&action=edit
0001-support-both-libgphoto2-2.5.0-and-2.4.0.patch

please try this patch against "core" part of digikam.

it tries to handle both 2.4 and 2.5.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Marcus Meissner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Marcus Meissner <[hidden email]> ---
(untested yet... will do this in some minutes)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|failed build against        |failed build against
                   |libgphoto2-2.5.0            |libgphoto2-2.5.0 [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

nucleo
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #6 from nucleo <[hidden email]> ---
Patch from Comment 4 fixes build but not tested how digikam works.
http://kojipkgs.fedoraproject.org//packages/digikam/2.7.0/5.fc18/data/logs/i686/build.log

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #7 from Marcus Meissner <[hidden email]> ---
it builds, but there is some GPPortInfo lifetime handling off, i need to do
some more fixes there

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Marcus Meissner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72725|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcus Meissner <[hidden email]> ---
Created attachment 73176
  --> https://bugs.kde.org/attachment.cgi?id=73176&action=edit
updated and tested libgphoto 2.5/2.4 patch

this patch should work with both 2.4 and 2.5.
i had to rewrite findConnectedUSBCamera a bit ;)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #9 from Marcus Meissner <[hidden email]> ---
(patch is against master ... if any other branch is required i can rebase it
there too if necessary ;)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Thanks Marcus.

git/master is for production. next 2.9.0 will be last stable release without
any major changes. Your current patch will be applied into.

There is another 3.0.0 branch where similar patch must be applied, and where we
working in-deep currently. Look here for details :

http://community.kde.org/Digikam/GSoC2012#Repositories_Branching_and_Dates

If you can provide a patch for this branch, it will be great.

Best

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #11 from Marcus Meissner <[hidden email]> ---
applies as-is to 3.0.0 branch, but I fail to compile the branch, error is this:

/home/marcus/projects/digikam-sc/core/digikam/utils/componentsinfo.h:81:71:
error: ‘class KIPI::PluginLoader’ has no member named ‘kipiPluginsVersion’

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Marcus Meissner-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #12 from Marcus Meissner <[hidden email]> ---
taking that back, it needs utilities/importui/backend/gpcamera.cpp not seen ...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Victor Dodon
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Victor Dodon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #13 from Victor Dodon <[hidden email]> ---
(In reply to comment #11)
> applies as-is to 3.0.0 branch, but I fail to compile the branch, error is
> this:
>
> /home/marcus/projects/digikam-sc/core/digikam/utils/componentsinfo.h:81:71:
> error: ‘class KIPI::PluginLoader’ has no member named ‘kipiPluginsVersion’
digiKam from development/3.0.0 branch requires libkipi 2.0.0 which you can get
from development/2.0.0 branch from libkipi repo.

Victor.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Islam,

I CC you about 3.0.0 branch where Marcus try to apply patch about Gphoto 2.5.0
support...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Islam Wazery
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Islam Wazery <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |commit
                   |                            |b224133f53e8428da7162c60437
                   |                            |4c7f73283d215

--- Comment #15 from Islam Wazery <[hidden email]> ---
I applied it to development/3.0.0 signed with Marcus Meissner name.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|3.0.0                       |2.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 303427] failed build against libgphoto2-2.5.0 [patch]

Gilles Caulier-4
In reply to this post by nucleo
https://bugs.kde.org/show_bug.cgi?id=303427

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Git commit 1e3fe5480e5311d4d564da79c6eee7ecf7cac774 by Gilles Caulier.
Committed on 21/08/2012 at 09:23.
Pushed by cgilles into branch 'master'.

apply patch from Marcus Meissner to support libgphoto 2.5.0 API

M  +23   -11   CMakeLists.txt
M  +5    -1    NEWS
M  +3    -0    digikam/utils/config-digikam.h.cmake
M  +60   -62   utilities/cameragui/devices/gpcamera.cpp

http://commits.kde.org/digikam/1e3fe5480e5311d4d564da79c6eee7ecf7cac774

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12