[Bug 301483] New: sigma raw files and preview (.x3f)

[Danni Coy]

https://bugs.kde.org/show_bug.cgi?id=301483

            Bug ID: 301483
          Severity: normal
           Version: 2.6.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: sigma raw files and preview (.x3f)
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Compiled Sources
            Status: UNCONFIRMED
         Component: RAW files management
           Product: digikam

Sigma raw files for newer cameras eg Sigma SD1 are not supported by dcraw or
digikam. However these files contain embedded jpeg files for previewing (which
are already used to get the image thumbnails); It would be useful if these
embedded jpegs could also be used for previewing the image to look at details
that are visible from the thumbnail.

Reproducible: Always

Steps to Reproduce:
1. click on sigma raw image (x3f) to preview.
2.
3.
Actual Results:  
image shows up looking like a bunch of noise (libkraw does not decode the image
correctly).

Expected Results:  
a reduced size preview of the image should appear.

actually I wouldn't mind if this behaviour was changed for all sigma cameras.
DCRaw has a hard time with the files it does support (the jpeg previews usually
look better than what it produces).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=301483

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
Can you provide a sample file for testing?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301483

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]
          Component|RAW files management        |libkdcraw

--- Comment #2 from Gilles Caulier <[hidden email]> ---
We don't use dcraw for RAW handling, but libraw (http://www.libraw.org)

Sound like a wish for libraw as well.

Please provide a sample file for Alex (libraw author)

Also, give us which libraw you use ? Go to Help/Components Info for details.

Marcel : We don't use Exiv2 for raw preview extraction. Right or i'm wrong ?
Both are possible (exiv2 or libraw). Typically libraw has a better support of
raw file preview than exiv2

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=301483

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
We use exiv2, it gives us a very clean API, we see which previews are available
and at which size, and can decide before loading anything if the preview is
large enough or too small etc.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301483

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Marcel

if a raw file type mime is not supported by Exiv2, libkdcraw must be used
instead. libraw from libkdcraw support X3F. I suspect that X3F is not suported
by Exiv2...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=301483

--- Comment #5 from Marcel Wiesweg <[hidden email]> ---
Git commit 14e711ba5d7146fb15d90a9609bfdbfda6dff8c4 by Marcel Wiesweg.
Committed on 19/06/2012 at 20:05.
Pushed by mwiesweg into branch 'master'.

Use libraw as a fallback for RAW preview loading in case exiv2 fails.
Some cleanups and code reuse in the code.

M  +55   -30   libs/threadimageio/previewtask.cpp

http://commits.kde.org/digikam/14e711ba5d7146fb15d90a9609bfdbfda6dff8c4

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=301483

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WAITINGFORINFO

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
The patch enables usage of libraw preview loading. Note I don't have recent
.x3f and none was provided here, thus waitingforinfo as I cannot test.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Danni Coy]

https://bugs.kde.org/show_bug.cgi?id=301483

--- Comment #7 from Danni Coy <[hidden email]> ---
I thought I had added one - but at ~40mb seems to be too big for the tracker -
I have published the fire here http://ubuntuone.com/0MiyU3Og5lyaXWoKDtQlSN

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=301483

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WAITINGFORINFO              |FIXED

--- Comment #8 from Marcel Wiesweg <[hidden email]> ---
Indeed, Exiv2 fails at this image, but with this fix, the embedded JPEG is
extracted by dcraw.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301483

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel