[Bug 301048] New: distributed watermarks

[Axel Krebs]

https://bugs.kde.org/show_bug.cgi?id=301048

            Bug ID: 301048
          Severity: wishlist
           Version: 2.5.0
          Priority: NOR
          Assignee: [hidden email]
           Summary: distributed watermarks
    Classification: Unclassified
                OS: Linux
          Reporter: [hidden email]
          Hardware: Ubuntu Packages
            Status: UNCONFIRMED
         Component: Batch Queue Manager
           Product: digikam

digikam offers "add watermark" as an option in batch queue manager.

One can choose, if watermark is a picture or a text.

Additionally, it is possible to select a position

Advantage: it is much less likely, that someone discards a distributed wm than
a single one.

Reproducible: Always

Steps to Reproduce:
1. start digikam
2. run batch queue manager
3. add watermark
Actual Results:  
the user is forced to select a specific position of a watermark.

Expected Results:  
I suggest to add an additional option to position a watermark:

1.) variation: distributed watermark (="wm"), where wm's are positioned in soem
type of pattern regularly

2.) varation: randomly distributed watermark without a possibility to position
the wm itself.

In both cases: the larger the pic, the more copies of wm's are added.

QUESTION:

Why ist it _NOT_ possible to add a file simply when reporting a bug?
If commending a bug, it is possible very easy!?!?!?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Axel Krebs]

https://bugs.kde.org/show_bug.cgi?id=301048

--- Comment #1 from Axel Krebs <[hidden email]> ---
Created attachment 71509
  --> https://bugs.kde.org/attachment.cgi?id=71509&action=edit
distributed watermark (as with google)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301048

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Batch Queue Manager         |Metadata

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301048

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Metadata                    |Batch Queue Manager
            Summary|distributed watermarks      |New tool to superimpose
                   |                            |visible watermarking over
                   |                            |images

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301048

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New tool to superimpose     |BQM Watermark tool : more
                   |visible watermarking over   |Superimpose visible
                   |images                      |watermarking options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=301048

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM Watermark tool : more   |BQM Watermark tool : more
                   |Superimpose visible         |super-impose visible
                   |watermarking options        |watermark options

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Inse
                   |                            |rtText

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

Ahmed Fathi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed@gma
                   |                            |il.com

--- Comment #2 from Ahmed Fathi <[hidden email]> ---
Created attachment 104050
  --> https://bugs.kde.org/attachment.cgi?id=104050&action=edit
water mark repetition and random placement patch

I created this patch. now you can repeat the water mark in a systematic pattern
or in a random pattern. you have both dense and sparse modes , and you can put
custom sparsity parameter as you need. It works well with the four different
rotations also. In addition , in the randomized placement mode , you can choose
to randomize the orientation of the watermark also , or constraint the
"randomness" to be the randomness of position only while the rotation is as
chosen via the combo box

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

--- Comment #3 from Ahmed Fathi <[hidden email]> ---
Created attachment 104051
  --> https://bugs.kde.org/attachment.cgi?id=104051&action=edit
the patch

forgot to mark it as patch

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM Watermark tool : more   |BQM Watermark tool : more
                   |super-impose visible        |super-impose visible
                   |watermark options [patch}   |watermark options [patch]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|BQM Watermark tool : more   |BQM Watermark tool : more
                   |super-impose visible        |super-impose visible
                   |watermark options           |watermark options [patch}

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

--- Comment #4 from [hidden email] ---
Ahmed,

Patch do not compile :

/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:
In constructor ‘Digikam::WaterMark::Private::Private()’:
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:127:22:
warning: ‘Digikam::WaterMark::Private::useTextRadioButton’ will be initialized
after [-Wreorder]
     QRadioButton*    useTextRadioButton;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:124:22:
warning:   ‘QCheckBox* Digikam::WaterMark::Private::useBackgroundCheckBox’
[-Wreorder]
     QCheckBox*       useBackgroundCheckBox;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5:
warning:   when initialized here [-Wreorder]
     Private() :
     ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:133:22:
warning: ‘Digikam::WaterMark::Private::placementPositionComboBox’ will be
initialized after [-Wreorder]
     QComboBox*       placementPositionComboBox;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:132:22:
warning:   ‘QComboBox* Digikam::WaterMark::Private::placementTypeComboBox’
[-Wreorder]
     QComboBox*       placementTypeComboBox;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5:
warning:   when initialized here [-Wreorder]
     Private() :
     ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:135:22:
warning: ‘Digikam::WaterMark::Private::sparsityFactorSpinBox’ will be
initialized after [-Wreorder]
     QDoubleSpinBox * sparsityFactorSpinBox;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:134:22:
warning:   ‘QComboBox* Digikam::WaterMark::Private::rotationComboBox’
[-Wreorder]
     QComboBox*       rotationComboBox;
                      ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5:
warning:   when initialized here [-Wreorder]
     Private() :
     ^
In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0,
                 from /usr/lib64/qt5/include/QtGui/QFont:1,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26:
/usr/lib64/qt5/include/QtCore/qstring.h: In member function ‘virtual void
Digikam::WaterMark::registerSettingsWidget()’:
/usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const
char*)’ is private
     QString(const char *ch);
     ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:322:177:
error: within this context
     d->denseRepetitionCheckBox->setWhatsThis("When you choose to have the
watermark repeated many times in the placement combo box, you can specify here
whether the repetition");
                                                                               
                                                                               
                 ^
In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0,
                 from /usr/lib64/qt5/include/QtGui/QFont:1,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26:
/usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const
char*)’ is private
     QString(const char *ch);
     ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:336:126:
error: within this context
                                                "you can check this to make the
watermark rotations random also[0,90,180,270]");
                                                                               
                                              ^
In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0,
                 from /usr/lib64/qt5/include/QtGui/QFont:1,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31,
                 from
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26:
/usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const
char*)’ is private
     QString(const char *ch);
     ^
/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:356:103:
error: within this context
                                            " typically between 1.0 and 3.0.
can also be less than 1.0");
                                                                               
                       ^
core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/build.make:518:
recipe for target
'core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/tools/decorate/watermark.cpp.o'
failed
make[2]: ***
[core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/tools/decorate/watermark.cpp.o]
Error 1
make[2]: *** Waiting for unfinished jobs....

-----

In source code i18n(" ") must be replaced by QLatin1String(" ")
Fix also indentation and alignment (coding style).
I suspect also a broken braken in last function.

Did you compile this code on your computer ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

--- Comment #5 from Ahmed Fathi <[hidden email]> ---
strange . It compiles and works perfectly well on my computer. I also reset the
branch, pulled the master , and re-applied the same patch file and it compiled
without any problems.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

--- Comment #6 from [hidden email] ---
Here digiKam is compiled with pure Qt5. No extra KDE4LibsSupport typicially
introduced if you compile digiKam with KCalCore support or another KDE desktop
dependencies.

Check these points : KF5::AkonadiContact, KF5::FileMetaData, KF5::CalendarCore

https://cgit.kde.org/digikam-software-compilation.git/tree/DEPENDENCIES

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=301048

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.5.0
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/65ef15bb4d6deb4b91d220
                   |                            |16f47b88716dfa93ba
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from [hidden email] ---
Git commit 65ef15bb4d6deb4b91d22016f47b88716dfa93ba by Gilles Caulier.
Committed on 21/02/2017 at 13:06.
Pushed by cgilles into branch 'master'.

apply patch #104050 from Ahmed Fathi to perform Watermark repetition and random
placement.
port patch to pure Qt5
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +216  -67   utilities/queuemanager/tools/decorate/watermark.cpp

https://commits.kde.org/digikam/65ef15bb4d6deb4b91d22016f47b88716dfa93ba

--
You are receiving this mail because:
You are the assignee for the bug.