[Bug 294579] New: Bug of feature ? Grouped pictures are not tagged except the first one

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=294579

           Summary: Bug of feature ? Grouped pictures are not tagged
                    except the first one
           Product: digikam
           Version: 2.5.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.5.0
OS:                Linux

When tagging a set of grouped pictures, only the first one (the one visible) is
tagged. I think that all the pictures grouped beneath the visible one should be
tagged, or at least a dialog should ask if we want to tag the complete group or
only the visible picture.

Reproducible: Always

Steps to Reproduce:
Tag a set of grouped pictures

Actual Results:  
Only the first one is tagged

Expected Results:  
By default, all the grouped pictures should be tagged when tagging a set of
grouped pictures, or may be a dialog box should ask if we want to tag the
picture or the group ?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294579


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Tags
            Summary|Bug of feature ? Grouped    |Grouped pictures are not
                   |pictures are not tagged     |tagged except the first one
                   |except the first one        |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=294579

--- Comment #1 from Marcel Wiesweg <[hidden email]> ---
IMO, intuition is not clear as to whether grouped images are affected or not.
It is possible to add additional menu entries to the popups that appear on drag
and drop, but there will be some smaller complications with details.
Alternatively, we can add a setup option if grouped images shall be affected by
operations on the lead image. This had the advantage of clearing the situation
for rating etc. as well.
It gets a bit more complex: What about the desc edit sidebar? Kipi plugins?
I believe a solution with one setup option for metadata operations can be
enough, for all other cases, only the visible images will be affected, the user
can always expand all groups in the view.
Opinions?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[philippe.quaglia]

https://bugs.kde.org/show_bug.cgi?id=294579

--- Comment #2 from [hidden email] ---
Hello,
when dragging a tag to a picture, there is a pop-up menu asking if the tag
should be applied to the current picture or to all the pictures. There may be
an additionnal question when we are above grouped pictures. I'm not skilled
enough to see the other induced complications. However your proposal of a
default setting may do the job as well.
Regards.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=294579

--- Comment #3 from Marcel Wiesweg <[hidden email]> ---
I initially planned to extend this context menu, but there are quite a few ways
to edit metadata without drag and drop, be it the right sidebar, the context
menu, or the icon view overlays for e.g. rating. For all these, the dragdrop
menu approach will not work, or even raise the question which scope the
operation actually has. There's also some implications case of a tag dragged on
empty space or on a selection of pictures, where we currently offer three
possibilities in the menu.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[tosca]

https://bugs.kde.org/show_bug.cgi?id=294579

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from [hidden email] ---
And I have the reverse problem: having removed tags from grouped pictures, it
appears that only the 'head of group' has been affected. So these tags are
still assigned to pictures that I cannot find, as they are hidden.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294579

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Grouped pictures are not    |GROUP : grouped pictures
                   |tagged except the first one |are not tagged except the
                   |                            |first one

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294579

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Gilles Caulier <[hidden email]> ---
*** Bug 249302 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294579

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GROUP : grouped pictures    |GROUP : grouped pictures
                   |are not tagged except the   |are not processed together
                   |first one                   |except the first one (Tags,
                   |                            |Metadata, Labels, etc.)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294579

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tags                        |Albums GUI

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GROUP : grouped pictures    |GROUP : grouped pictures
                   |are not processed together  |are not processed together
                   |except the first one (Tags, |except the first one
                   |Metadata, Labels, etc.)     |(Renaming, Tags, Metadata,
                   |                            |Labels, etc.)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from [hidden email] ---
*** Bug 362411 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|AlbumsView                  |AlbumsView-Group

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

--- Comment #7 from [hidden email] ---
This file still valid with last digiKam 5.0.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

--- Comment #8 from [hidden email] ---
Yes, I guess it is still valid, the behaviour is still exactly the same.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.5.0                       |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

tuxflo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from tuxflo <[hidden email]> ---
Also still valid in version 5.1.0.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=294579

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.4.0
                 CC|                            |[hidden email]
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/5f6aa8656cf333e8949b106
                   |                            |60407e8c8a0c0cc4f
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Git commit 5f6aa8656cf333e8949b10660407e8c8a0c0cc4f by Maik Qualmann.
Committed on 08/11/2016 at 21:11.
Pushed by mqualmann into branch 'master'.

apply patch #102005 from Simon Frei to adjust grouping behavior
FIXED-IN: 5.4.0

M  +2    -1    NEWS
M  +1    -1    app/items/digikamimageview.cpp
M  +29   -18   app/items/imagecategorizedview.cpp
M  +6    -3    app/items/imagecategorizedview.h
M  +0    -27   app/items/imageviewutilities.cpp
M  +12   -3    app/views/digikamview.cpp
M  +96   -49   app/views/tableview/tableview.cpp
M  +10   -4    app/views/tableview/tableview.h
M  +0    -24   app/views/tableview/tableview_model.cpp
M  +0    -2    app/views/tableview/tableview_model.h
M  +13   -0    libs/database/item/imageinfolist.cpp
M  +2    -1    libs/database/item/imageinfolist.h
M  +1    -0    libs/models/imagefiltermodel.h
M  +0    -1    libs/tags/tagslineeditoverlay.cpp

http://commits.kde.org/digikam/5f6aa8656cf333e8949b10660407e8c8a0c0cc4f

--
You are receiving this mail because:
You are the assignee for the bug.