[Bug 294105] New: Please support lcms2

https://bugs.kde.org/show_bug.cgi?id=294105

           Summary: Please support lcms2
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unspecified (using KDE 4.8.0)
OS:                Linux

Ubuntu wants to deprecate lcms1 in 12.04 and digikam currently has no lcms2
support.
https://bugs.launchpad.net/ubuntu/+source/digikam/+bug/885324

Reproducible: Always

Steps to Reproduce:
Try to build digikam with lcms2

Actual Results:  
Fails to configure

Expected Results:  
Builds fine

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]
          Component|general                     |Portability
            Version|unspecified                 |2.6.0




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2012-02-14 21:54:52 ---
Port to LCMS2 is under progress by Francesco into git/master (next 2.6.0)

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #2 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-17 15:26:53 ---
Git commit 2dd84b3847d48e16df7ec18b2191ab6727839bec by Francesco Riosa.
Committed on 17/02/2012 at 16:14.
Pushed by riosa into branch 'master'.

[lcms2] porting

here there is another step, some private functions have been imported
from lcms2, but some small changes to cietonguewidget.cpp were needed
too.

Interface is now complete (with the exception of two informational
functions), results however are still wrong and further testing is
needed (below an example).

  Digikam::CIETongueWidget::setProfile:
  lcms1: Profile white point : x= 0.312713  y= 0.32912  Y= 1
  lcms2: Profile white point : x= 0.307693  y= 0.43076  Y= 1.24611e-306

M  +63   -26   libs/dklcms/README
M  +292  -49   libs/dklcms/digikam-lcms.cpp
M  +13   -28   libs/dklcms/digikam-lcms.h
M  +25   -0    libs/widgets/iccprofiles/cietonguewidget.cpp

http://commits.kde.org/digikam/2dd84b3847d48e16df7ec18b2191ab6727839bec

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #3 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-17 22:21:46 ---
fix to the white point problem
http://commits.kde.org/digikam/e5359af735fdee3a924a81f4e6fe0ae3514fc272

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #4 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-20 21:05:51 ---
Git commit 6e81976afb1b26394650765ce8c8f77a4f929143 by Francesco Riosa.
Committed on 20/02/2012 at 21:38.
Pushed by riosa into branch 'master'.

[lcms2] working colorant triangle

but the mixmatch needed is not a good sign

M  +25   -1    libs/dklcms/digikam-lcms.cpp

http://commits.kde.org/digikam/6e81976afb1b26394650765ce8c8f77a4f929143

--- Comment #5 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-20 21:05:51 ---
Git commit 42ff13cca64e536196fe963ca37db47a9e42ff54 by Francesco Riosa.
Committed on 20/02/2012 at 21:28.
Pushed by riosa into branch 'master'.

[lcms2] use c++ static_cast<> instead of plain cast

M  +1    -0    libs/dklcms/README
M  +59   -30   libs/dklcms/digikam-lcms.cpp
M  +0    -1    libs/dklcms/digikam-lcms.h
M  +17   -1    libs/widgets/iccprofiles/cietonguewidget.cpp

http://commits.kde.org/digikam/42ff13cca64e536196fe963ca37db47a9e42ff54

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #4 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-20 21:05:51 ---
Git commit 6e81976afb1b26394650765ce8c8f77a4f929143 by Francesco Riosa.
Committed on 20/02/2012 at 21:38.
Pushed by riosa into branch 'master'.

[lcms2] working colorant triangle

but the mixmatch needed is not a good sign

M  +25   -1    libs/dklcms/digikam-lcms.cpp

http://commits.kde.org/digikam/6e81976afb1b26394650765ce8c8f77a4f929143

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #6 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-21 19:24:20 ---
Git commit 1b7a1fc839c61e2e25b1edf73857339e584df7e5 by Francesco Riosa.
Committed on 21/02/2012 at 20:19.
Pushed by riosa into branch 'master'.

[lcms2] fix some informational functions

the following functions are an aggregate of other fx:
- dkCmsTakeProductName()
- dkCmsTakeProductDesc()
- dkCmsTakeProductInfo()

also, now all of them return QString.

M  +2    -3    libs/dimg/filters/icc/iccprofile.cpp
M  +202  -56   libs/dklcms/digikam-lcms.cpp
M  +1    -1    libs/dklcms/digikam-lcms.h
M  +0    -41   libs/widgets/iccprofiles/cietonguewidget.cpp
M  +0    -2    libs/widgets/iccprofiles/cietonguewidget.h

http://commits.kde.org/digikam/1b7a1fc839c61e2e25b1edf73857339e584df7e5

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #7 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-21 23:42:04 ---
Digikam will stay with lcms1 for this release (will use lcms2 only in absence
of the former).
From the next one lcms2 will be default and lcms1 deprecated to be removed
after that.

Git commit 19d4c9201ccd175ed67cee0724413e087fb4b0e2 by Francesco Riosa.
Committed on 21/02/2012 at 21:40.
Pushed by riosa into branch 'master'.

[lcms2] tag buffer need initialization

M  +4    -1    libs/dklcms/digikam-lcms.cpp

http://commits.kde.org/digikam/19d4c9201ccd175ed67cee0724413e087fb4b0e2


Git commit 326c8803e3740dfbd421a537b6226c2a25bd4426 by Francesco Riosa.
Committed on 22/02/2012 at 00:22.
Pushed by riosa into branch 'master'.

[lcms2] fixed a cast bug in cmsFloat2XYZEncoded()

We are now at feature parity with lcms1.
There are differences between the two implementations, they are
quantifiable even in 8bit images (1/256).

lcms2 should be more precise (and faster) than lcms1

M  +1    -7    libs/dklcms/digikam-lcms.cpp
M  +0    -3    libs/dklcms/digikam-lcms.h

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #8 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-22 15:29:30 ---
Git commit 43d9572dbb17efacf96fbd484edfa37365e93ddf by Francesco Riosa.
Committed on 22/02/2012 at 16:26.
Pushed by riosa into branch 'master'.

[lcms2] add ENABLE_LCMS2 option to force lcms2

adding -DENABLE_LCMS2=1 to cmake options will force digikam applications
to link against lcms2, see comment in the commitdiff for a roadmap

M  +36   -31   CMakeLists.txt

http://commits.kde.org/digikam/43d9572dbb17efacf96fbd484edfa37365e93ddf

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |WAITINGFORINFO




--- Comment #9 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-26 21:03:30 ---
could someone please check that the this commmit:
http://commits.kde.org/digikam/43d9572dbb17efacf96fbd484edfa37365e93ddf

works under windows os? It use `pkg-config` which allegedly doesn't work on all
oses.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2012-02-26 21:13:29 ---
Ananta, Can you take a look to comment #9 from Francesco ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #11 from Ananta Palani <anantapalani gmail com>  2012-02-28 09:53:56 ---
(In reply to comment #9)
> could someone please check that the this commmit:
> http://commits.kde.org/digikam/43d9572dbb17efacf96fbd484edfa37365e93ddf
>
> works under windows os? It use `pkg-config` which allegedly doesn't work on all
> oses.

Looks like it works fine. I don't have lcms2 installed, but I can toggle
-DENABLE_LCMS2 and have it build with lcms1 when off (0) and fail to build (due
to no lcms2) when on (1). Do you need me to have lcms2 to fully test your
commit?

Also, does anything need to be changed in relation to this bug 290157 or any
other use of lcms2 that I don't know about?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2012-02-28 12:27:17 ---
Ananta,

thanks for feedback. I think Francesco need to see if lcms2 support compile and
work fine under windows.

For libkdcraw (bug 290157), i'm sure than libraw authors have already tested
lcms2 support everywhere...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #13 from Ananta Palani <anantapalani gmail com>  2012-02-29 11:08:43 ---
(In reply to comment #12)
> Ananta,
>
> thanks for feedback. I think Francesco need to see if lcms2 support compile and
> work fine under windows.
>
> For libkdcraw (bug 290157), i'm sure than libraw authors have already tested
> lcms2 support everywhere...
>
> Gilles Caulier

When running cmake on digikam-sc with lcms2, I get 2 errors.

1. When cmake examines the requirements of libkdcraw:

CMake Warning at extra/libkdcraw/CMakeLists.txt:110 (FIND_PACKAGE):
  Could not find module FindLCMS2.cmake or a configuration file for package
  LCMS2.

  Adjust CMAKE_MODULE_PATH to find FindLCMS2.cmake or set LCMS2_DIR to the
  directory containing a CMake configuration file for LCMS2.  The file will
  have one of the following names:

    LCMS2Config.cmake
    lcms2-config.cmake

I do not get this problem when running cmake on libkdcraw. Also, if I copy
FindLCMS2.cmake from digikam-sc/extra/libkdcraw/cmake/modules to
digikam-sc/cmake/modules then it finds lcms2. How should CMakeLists.txt be
adjusted to use the FindLCMS2.cmake from libkdcraw? Or, should it be
permanently copied to digikam-sc/cmake/modules?


2. digikam cannot find lcms2 because there is no pkg-config, as Francesco
expected:

CMake Error at r:/share/apps/cmake/modules/FindPkgConfig.cmake:323 (message):
  pkg-config tool not found
Call Stack (most recent call first):
  r:/share/apps/cmake/modules/FindPkgConfig.cmake:337
(_pkg_check_modules_internal)
  core/CMakeLists.txt:171 (pkg_check_modules)

Maybe use FindLCMS2.cmake from libkdcraw, or a similar technique as it uses for
WIN32?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2012-02-29 13:38:34 ---
Git commit 712e983ff995bbcc59cb3da1f067238d95fa862a by Gilles Caulier.
Committed on 29/02/2012 at 14:34.
Pushed by cgilles into branch 'master'.

Add missing LCMS version 2 cmake detection script. It's the same than
libkdcraw.

Laurent, it must be fine to factorize this script in kdelibs. I know that krita
use lcms2 too...
Note there is already a cmake script to detect LCMS version 1 which is very
different. Of course,
if this script can be patch to support version 1 and version 2, it will be
great.

CCMAIL: [hidden email]

A  +72   -0    cmake/modules/FindLCMS2.cmake

http://commits.kde.org/digikam/712e983ff995bbcc59cb3da1f067238d95fa862a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2012-02-29 13:39:31 ---
Ananta,

I add LCMS2 detection script to digiKam (it's the same than Libkdcraw).

It work better now ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #16 from Ananta Palani <anantapalani gmail com>  2012-02-29 15:31:12 ---
(In reply to comment #15)
> I add LCMS2 detection script to digiKam (it's the same than Libkdcraw).
>
> It work better now ?

It works for libkdcraw as expected when building digikam-sc, but digiKam still
can't compile because the method of detection that Francesco used does not use
FindLCMS2.cmake, so either digiKam's CMakeFile.txt needs to be modified to use
FindLCMS2.cmake or relevent code from the .cmake needs to be ported.

Also, if both lcms1 and lcms2 are on a system, libkdcraw will automatically
build using lcms2. However, digiKam will only build with lcms2 support if
-DENABLE_LCMS2=1. Would having libkdcraw built agains lcms2 but digiKam built
against lcms1 be a problem? If so, it would be useful if the -DENABLE_LCMS2 can
be toggled for libkdcraw as well (such that configuring this option for
digikam-sc would cause it to apply to libkdcraw as well). Of course, if
everything works fine with them built against different version of lcms, then
that isn't a problem I guess, but it is slightly unexpected from a build
perspective.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 13:22:34 ---
> It works for libkdcraw as expected when building digikam-sc...

Ah. For me it doesn't work :

-- Starting CMake configuration for: libkdcraw
CMake Warning at extra/libkdcraw/CMakeLists.txt:110 (FIND_PACKAGE):
  Could not find module FindLCMS2.cmake or a configuration file for package
  LCMS2.

  Adjust CMAKE_MODULE_PATH to find FindLCMS2.cmake or set LCMS2_DIR to the
  directory containing a CMake configuration file for LCMS2.  The file will
  have one of the following names:

    LCMS2Config.cmake
    lcms2-config.cmake

Of course i cleaned previous cmake cache before... Strange...

lcms2 is of course installed on my computer :


[gilles@localhost include]$ pwd
/usr/include
[gilles@localhost include]$ ls -al *lcms*
-rw-r--r-- 1 root root 93522 janv. 28 14:37 lcms2.h
-rw-r--r-- 1 root root 24728 janv. 28 14:37 lcms2_plugin.h
-rw-r--r-- 1 root root 78034 janv. 18  2011 lcms.h

[gilles@localhost lib64]$ pwd
/usr/lib64
[gilles@localhost lib64]$ ls -al *lcms*
lrwxrwxrwx 1 root root      17 janv. 28 14:55 liblcms2.so -> liblcms2.so.2.0.3*
lrwxrwxrwx 1 root root      17 janv. 28 14:55 liblcms2.so.2 ->
liblcms2.so.2.0.3*
-rwxr-xr-x 1 root root  320296 janv. 28 14:37 liblcms2.so.2.0.3*

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WAITINGFORINFO              |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel