[Bug 294105] New: Please support lcms2

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 14:24:29 ---
Git commit 1fc2bf3f97baa3a37a8b3ae0df987528efcff4d1 by Gilles Caulier.
Committed on 01/03/2012 at 15:23.
Pushed by cgilles into branch 'master'.

don't overwrite cmake variable to detect LCMS2 script. Just append path as well
to existing one.

M  +1    -1    CMakeLists.txt

http://commits.kde.org/libkdcraw/1fc2bf3f97baa3a37a8b3ae0df987528efcff4d1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 22:12:37 ---
Git commit 5c250eab9929c03896cb132cf845bc313ba15345 by Gilles Caulier.
Committed on 01/03/2012 at 23:10.
Pushed by cgilles into branch 'master'.

use same logic than digiKam to compile and link with lcms2 or lcms1 shared lib.
Use ENABLE_LCMS2 bool option with cmake to turn on lcms2 support, else lcms1 is
used.

M  +36   -16   CMakeLists.txt

http://commits.kde.org/libkdcraw/5c250eab9929c03896cb132cf845bc313ba15345

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2012-03-01 22:14:58 ---
Ananta,

libkdcraw and digiKam use the same logic to compile against lcms2. The same
cmake option is used for digiKam core and libkdcraw : ENABLE_LCMS2.

Please, try under windows if all is fine, and report...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #21 from Francesco Riosa <francesco+kde pnpitalia it>  2012-03-01 23:05:29 ---
(In reply to comment #20)
> Ananta,
>
> libkdcraw and digiKam use the same logic to compile against lcms2. The same
> cmake option is used for digiKam core and libkdcraw : ENABLE_LCMS2.
>
> Please, try under windows if all is fine, and report...
>
> Gilles Caulier

For the record previously both lcms1 and lcms2 were linked, this worked under
linux but could have not on other arches.
Gilles thanks for managing this, I'll kinda away from keybord 'till next week

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 07:31:46 ---
No problem Francesco.

I checked with LDD, and digiKam and libkdcraw are properly linked with lcms2,
or lcms1, not with both at the same time.

I see a pending problem on my computer : The lcms2 includes path passed to
cmake to compile digiKam/libkdcraw is empty. I don't know why. It must be
filled by lcms2 detection script. Variable is LCMS2_INCLUDE_DIR.

I print it here in lead cmake script :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/CMakeLists.txt#L173

Can you confirm this ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #23 from Francesco Riosa <francesco+kde pnpitalia it>  2012-03-02 11:10:27 ---
(In reply to comment #22)

> No problem Francesco.
>
> I checked with LDD, and digiKam and libkdcraw are properly linked with lcms2,
> or lcms1, not with both at the same time.
>
> I see a pending problem on my computer : The lcms2 includes path passed to
> cmake to compile digiKam/libkdcraw is empty. I don't know why. It must be
> filled by lcms2 detection script. Variable is LCMS2_INCLUDE_DIR.
>
> I print it here in lead cmake script :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/CMakeLists.txt#L173
>
> Can you confirm this ?

confirmed, but lcms2.h is into /usr/include/, which is the canonical path for
includes, maybe the variable is empty if the header is in that default path.

from `cmake --help-command FIND_PATH`:
<<If nothing is found, the result will be <VAR>-NOTFOUND,>>
not empty

on the other hand

`grep LCMS2_INCLUDE CMakeCache.txt`
LCMS2_INCLUDEDIR:INTERNAL=/usr/include
LCMS2_INCLUDE_DIRS:INTERNAL=

and show that LCMS2_INCLUDEDIR has indeed the correct path.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 11:57:49 ---
Hum perhaps LCMS2 find script need to be updated from Krita. I copied it from
KOffice.

I ask to Laurent Montel if we can factorize it to kdelibs in the future, to
prevent duplicates.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #25 from Ananta Palani <anantapalani gmail com>  2012-03-02 13:55:06 ---
(In reply to comment #20)
> libkdcraw and digiKam use the same logic to compile against lcms2. The same
> cmake option is used for digiKam core and libkdcraw : ENABLE_LCMS2.
>
> Please, try under windows if all is fine, and report...

Gilles,

PKG_CHECK_MODULES was still being used, so I switched to FindLCMS2.cmake
instead and committed the change (forgot to CC this bug, sorry). Works fine on
Windows now. I think this may also fix the problem you mention in comment #22?

-Ananta

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 17:33:01 ---
Git commit 2d36b980995d744f9cbe9c36125386d700ba6136 by Ananta Palani.
Committed on 02/03/2012 at 14:50.
Pushed by palani into branch 'master'.

Use FindLCMS2.cmake instead of PKG_CHECK_MODULES which doesn't work on Windows

M  +6    -6    CMakeLists.txt

http://commits.kde.org/digikam/2d36b980995d744f9cbe9c36125386d700ba6136

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #27 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 17:33:31 ---
Git commit 13308aec86a8e02322e063c2190aed2f9e0b21c8 by Ananta Palani.
Committed on 02/03/2012 at 14:51.
Pushed by palani into branch 'master'.

Use FindLCMS2.cmake instead of PKG_CHECK_MODULES which doesn't work on Windows

M  +5    -5    CMakeLists.txt

http://commits.kde.org/libkdcraw/13308aec86a8e02322e063c2190aed2f9e0b21c8

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 17:40:20 ---
Cmake configuration trace is different between libkdcraw and digiKam :


-- -------------------------------------------------------------------------
-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- Found JPEG: /usr/lib64/libjpeg.so
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp

...


---------------------------------------------------------------------------
-- Starting CMake configuration for: digikam
-- Found Jasper: /usr/lib64/libjasper.so
-- Check for Kdcraw library in local sub-folder...
...
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
--   found lcms2, version 2.3
-- Found LCMS2: lcms2
-- Identified libjpeg version: 80+
-- Found MySQL server executable at: /usr/sbin/mysqld
-- Found MySQL install_db executable at: /usr/bin/mysql_install_db
...

Why ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105





--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2012-03-02 17:43:17 ---
Note : I started cmake configuration script with "-DENABLE_LCMS2=on"

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105

--- Comment #30 from Ananta Palani <[hidden email]> ---
(In reply to comment #29)
> Note : I started cmake configuration script with "-DENABLE_LCMS2=on"
>
> Gilles

Strange, works fine for me, either together (digikam-sc) or separately
(libkdcraw, digikam). Here is separately:

-- Starting CMake configuration for: libkdcraw
...
-- Check for LCMS2 availability...
-- Found lcms version 2.03, c:/kderoot/lib/lcms-2.lib
-- Found LCMS2: c:/kderoot/lib/lcms-2.lib c:/kderoot/include

-- Found JPEG: c:/kderoot/lib/jpeg.lib
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP C flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP CXX flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: /openmp

----------------------------------------

-- Starting CMake configuration for: digikam
...
-- Check for LCMS2 availability...
-- Found lcms version 2.03, c:/kderoot/lib/lcms-2.lib
-- Found LCMS2: c:/kderoot/lib/lcms-2.lib c:/kderoot/include

-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP C flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP CXX flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: /openmp

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105

--- Comment #31 from Ananta Palani <[hidden email]> ---
Git commit b0cfc14a4dad0bd137fdf8d9493c378dbecca652 by Ananta Palani.
Committed on 03/03/2012 at 08:11.
Pushed by palani into branch 'master'.

Give libkdcraw cmake modules preference over pre-existing ones.

M  +1    -1    CMakeLists.txt

http://commits.kde.org/libkdcraw/b0cfc14a4dad0bd137fdf8d9493c378dbecca652

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=294105

--- Comment #32 from Ananta Palani <[hidden email]> ---

Gilles,

Could you have another version of FindLCMS2.cmake on your system somewhere?
Your 'found' message does not look consistent with the file included in
libkdcraw/digikam:

Found lcms version ${LCMS2_MAJOR_VERSION}.${LCMS2_MINOR_VERSION},
${LCMS2_LIBRARIES}

so maybe cmake is using the wrong one? The commit I just made may fix your
problem regardless.

-Ananta

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105

--- Comment #33 from Gilles Caulier <[hidden email]> ---
No other lcms2 cmake find script is on my computer.

I updated my local git and cleaned cmake cache. trace is better :


-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
--   found lcms2, version 2.3
-- Found lcms version 2.03, /usr/lib64/liblcms2.so
-- Found LCMS2: /usr/lib64/liblcms2.so /usr/include
-- Found JPEG: /usr/lib64/libjpeg.so
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * LCMS2 - A small-footprint color management engine
   * libjpeg - JPEG image format support

...


-- Starting CMake configuration for: digikam
-- Found Jasper: /usr/lib64/libjasper.so
-- Check for Kdcraw library in local sub-folder...
-- Found Kdcraw library in local sub-folder:
/mnt/data/Devel/GIT/2.x/extra/libkdcraw
-- Check Kexiv2 library in local sub-folder...
-- Found Kexiv2 library in local sub-folder:
/mnt/data/Devel/GIT/2.x/extra/libkexiv2
-- Check Kipi library in local sub-folder...
-- Found Kipi library in local sub-folder:
/mnt/data/Devel/GIT/2.x/extra/libkipi
-- Check Kface library in local sub-folder...
-- Found Kface library in local sub-folder:
/mnt/data/Devel/GIT/2.x/extra/libkface
-- Check for KGeoMap library in local sub-folder...
-- Found KGeoMap library in local sub-folder:
/mnt/data/Devel/GIT/2.x/extra/libkgeomap
-- checking for module 'libpgf'
--   package 'libpgf' not found
-- Could NOT find any working clapack installation
-- Check for LCMS2 availability...
-- Found lcms version 2.03, /usr/lib64/liblcms2.so
-- Found LCMS2: /usr/lib64/liblcms2.so /usr/include
-- Identified libjpeg version: 80+
-- Found MySQL server executable at: /usr/sbin/mysqld
...

i need to check OSX now...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105

--- Comment #34 from Gilles Caulier <[hidden email]> ---
Work fine under MACOSX :


--
----------------------------------------------------------------------------------
-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
--   found lcms2, version 2.2
-- Found lcms version 2.02, /opt/local/lib/liblcms2.dylib
-- Found LCMS2: /opt/local/lib/liblcms2.dylib /opt/local/include
-- Found JPEG: /opt/local/lib/libjpeg.dylib

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * LCMS2 - A small-footprint color management engine
   * libjpeg - JPEG image format support

...


--
----------------------------------------------------------------------------------
-- Starting CMake configuration for: digikam
-- Found Jasper: /opt/local/lib/libjasper.dylib
-- Check for Kdcraw library in local sub-folder...
-- Found Kdcraw library in local sub-folder:
/Users/gilles/Devel/2.x/extra/libkdcraw
-- Check Kexiv2 library in local sub-folder...
-- Found Kexiv2 library in local sub-folder:
/Users/gilles/Devel/2.x/extra/libkexiv2
-- Check Kipi library in local sub-folder...
-- Found Kipi library in local sub-folder:
/Users/gilles/Devel/2.x/extra/libkipi
-- Check Kface library in local sub-folder...
-- Found Kface library in local sub-folder:
/Users/gilles/Devel/2.x/extra/libkface
-- Check for KGeoMap library in local sub-folder...
-- Found KGeoMap library in local sub-folder:
/Users/gilles/Devel/2.x/extra/libkgeomap
-- checking for module 'libpgf'
--   package 'libpgf' not found
-- Found clapack includes: /System/Library/Frameworks/vecLib.framework/Headers
-- Found clapack library: /usr/lib/libclapack.dylib
-- Check for LCMS2 availability...
-- Found lcms version 2.02, /opt/local/lib/liblcms2.dylib
-- Found LCMS2: /opt/local/lib/liblcms2.dylib /opt/local/include
-- Identified libjpeg version: 80+
...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #35 from Gilles Caulier <[hidden email]> ---
All compile fine under MACOSX through macport :


[ 56%] Building C object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/lsame.c.o
[ 57%] Building C object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/sfe.c.o
[ 57%] Building C object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/util.c.o
[ 57%] Building C object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/xerbla.c.o
[ 57%] Building CXX object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/dklcms/digikam-lcms.cpp.o
[ 57%] Building CXX object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgbuiltinfilter.cpp.o
[ 57%] Building CXX object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgthreadedfilter.cpp.o
[ 57%] Building CXX object
core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgfiltermanager.cpp.o

I close this file now...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=294105

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=294105

Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #36 from Christoph Feck <[hidden email]> ---
Roadmap says:

# future plans:
#   2.7 will compile against lcms2 by default but lcms1 will stay as a fallback
#   2.8 will support lcms2 only, probably ENABLE_LCMS2 will be removed too
#       unless we decide to support another color managment library

Any plan to make lcms2 the default now, if both are found?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel