[Bug 287267] New: IptcCore tags are written incorrectly

https://bugs.kde.org/show_bug.cgi?id=287267

           Summary: IptcCore tags are written incorrectly
           Product: digikam
           Version: 2.2.0
          Platform: MS Windows
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Metadata
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=65938)
 --> (http://bugs.kde.org/attachment.cgi?id=65938)
XMP sidecar file with incorrectly written IptcCore tags

Version:           2.2.0 (using KDE 4.7.2)
OS:                MS Windows

According to email conversation with Phil Harvey - ExifTool Author - following
IptcCore tags have been written incorrectly:

CiAdrCity
CiAdrCtry
CiAdrExtadr
CiAdrPcode
CiAdrRegion
CiEmailWork
CiTelWork
CiUrlWork

These are elements of the "ContactInfo" structure used by CreatorContactInfo,
not stand-alone IptcCore tags.

Reproducible: Didn't try

Steps to Reproduce:
In DigiKam settings choose: Metadata Writing Mode: "Write to XMP sidecar only"

Then add metadata using right hand side Caption/Tags -button --> Information
panel. (I think I had to create metadata template first (using pencil button on
Information panel) writing just some test text in all possible fields. I then
applied this template into a selected photo. I had marked my actual photo file
as READ ONLY in Windows Explorer.)


Expected Results:  
Software should write metadata correctly and robustly!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287267


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-11-22 15:40:17 ---
Andreas, sound like a problem with Exiv2 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287267





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-11-22 15:41:17 ---
*** Bug 287272 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287267





--- Comment #3 from Andreas Huggel <ahuggel gmx net>  2011-11-24 06:15:38 ---
Gilles, I think this is a usage problem. If these are fields in a structure,
then they have to be set accordingly, Exiv2 doesn't do that by itself. You can
get an idea from the example here: http://www.exiv2.org/example5.html - Look
for "structure" and you'll find tags like "Xmp.xmpDM.videoFrameSize/stDim:w".

I'll check the IptcCore specs and come back with more specific info.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287267





--- Comment #4 from Andreas Huggel <ahuggel gmx net>  2011-11-28 03:15:27 ---
Gilles,
This is how to add the CreatorContactInfo structure as far as I can tell:

    // Add a creator contact info structure
    xmpData["Xmp.iptc.CreatorContactInfo/Iptc4xmpCore:CiAdrCity"] = "Kuala
Lumpur";
    xmpData["Xmp.iptc.CreatorContactInfo/Iptc4xmpCore:CiAdrCtry"] = "Malaysia";
    xmpData["Xmp.iptc.CreatorContactInfo/Iptc4xmpCore:CiUrlWork"] =
"http://www.exiv2.org";

The XMP-SDK serializes this to:

   <Iptc4xmpCore:CreatorContactInfo
    Iptc4xmpCore:CiAdrCity="Kuala Lumpur"
    Iptc4xmpCore:CiAdrCtry="Malaysia"
    Iptc4xmpCore:CiUrlWork="http://www.exiv2.org"/>

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287267





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 09:19:54 ---
Thanks Andreas,

I will take a look in libkexiv2

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=287267

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
Git commit 8111d3535d289d3f751957c016c1d0267f20b579 by Marcel Wiesweg.
Committed on 14/04/2012 at 17:16.
Pushed by mwiesweg into branch 'master'.

Fix accessing IptcCore contact info structure in XMP, as recommend by A.
Huggel.

M  +2    -1    NEWS
M  +24   -24   libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/8111d3535d289d3f751957c016c1d0267f20b579

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=287267

--- Comment #7 from Marcel Wiesweg <[hidden email]> ---
In a short test, the information from the test .xmp given above was read
correctly with this patch applied

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

On 14/04/12 17:17, Marcel Wiesweg wrote:

> https://bugs.kde.org/show_bug.cgi?id=287267
>
> Marcel Wiesweg<[hidden email]>  changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>               Status|UNCONFIRMED                 |RESOLVED
>           Resolution|---                         |FIXED
>
> --- Comment #6 from Marcel Wiesweg<[hidden email]>  ---
> Git commit 8111d3535d289d3f751957c016c1d0267f20b579 by Marcel Wiesweg.
> Committed on 14/04/2012 at 17:16.
> Pushed by mwiesweg into branch 'master'.
>
> Fix accessing IptcCore contact info structure in XMP, as recommend by A.
> Huggel.
>
> M  +2    -1    NEWS
> M  +24   -24   libs/dmetadata/dmetadata.cpp
>
> http://commits.kde.org/digikam/8111d3535d289d3f751957c016c1d0267f20b579

OK, I am sure that this is fine for new images going forward. However I
don't see any code to migrate this metadata from images that have the
incorrect way to the correct one. Unless there is something that I am
missing?

Andrew
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287267

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel