[Bug 287081] New: F2 renames image, not Album in Thumbnails mode

https://bugs.kde.org/show_bug.cgi?id=287081

           Summary: F2 renames image, not Album in Thumbnails mode
           Product: digikam
           Version: 2.4.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.4.0 (using KDE 4.7.3)
OS:                Linux

When I select an album and hit F2 to rename it, the popup proposes to rename
the selected image, not the album.

Reproducible: Always

Steps to Reproduce:
Select an album in the album tree. An image is automatically selected in the
right pane. A dotted rectangle surrounds the album name, not the image, showing
that the focus is on the album tree pane. Now hit F2 to rename that album

Actual Results:  
the popup proposes to rename the image from the right pane

Expected Results:  
the popup should be the same as when I use right click/rename album.

OS: Linux (x86_64) release 3.1.1-1.fc16.x86_64
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287081


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Albums GUI




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=287081





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2012-02-21 17:26:06 ---
Such a solution is available with two QActions of limited shortcut context for
the left sidebar and for the remaining widgets.
Now unfortunately, it seems that the KDE gui framework cannot work with that;
when adding such an action, the infamous "ambiguous shortcut" popup comes up,
although the shortcut context is clearly defined.

That means
a) we cannot implement this within the KDE framwork
b) we could implement it with QAction only, hardcoding the F2 shortcut without
the possibility to customize it

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|Albums GUI                  |Usability
         Resolution|---                         |DUPLICATE

--- Comment #2 from Gilles Caulier <[hidden email]> ---


*** This bug has been marked as a duplicate of bug 327628 ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=287081

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from DrSlony <[hidden email]> ---
It would be a significant time saver to be able to rename albums using a
keyboard shortcut. If you need to hard-code it, i suggest Ctrl+r or Shift+F2.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DUPLICATE                   |---
             Status|RESOLVED                    |UNCONFIRMED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287081

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.3.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/e73950979ebef04aec2c22a
                   |                            |75d36def2bfd6c2f7
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Git commit e73950979ebef04aec2c22a75d36def2bfd6c2f7 by Gilles Caulier.
Committed on 01/09/2014 at 06:59.
Pushed by cgilles into branch 'master'.

add SHIFT+F2 keyboard shortcut to rename album.
plug this action in main Album menu
Related: bug 327628
FIXED-IN: 4.3.0

M  +3    -2    NEWS
M  +15   -4    digikam/main/digikamapp.cpp
M  +2    -0    digikam/main/digikamapp_p.h
M  +2    -1    digikam/main/digikamui.rc
M  +2    -2    digikam/utils/contextmenuhelper.cpp
M  +5    -0    digikam/views/digikamview.cpp
M  +1    -0    digikam/views/digikamview.h

http://commits.kde.org/digikam/e73950979ebef04aec2c22a75d36def2bfd6c2f7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=287081

--- Comment #5 from Frederic Grelot <[hidden email]> ---
I would like to reopen this bug, for two reasons :

-Marcel (in comment #1) said that there is no such possibility in KDE framework
to affect a shortcut without any ambiguity. However, I can't believe that
point, since in every file manager I know, if the "tree" view has the focus and
I hit F2, the folder get renamed, while if the "file" view has it, the
currently selected file is renamed. Am I missing something?
-In the current situation, is it possible to add an hint in the right-click
popup to tell that "Shift+F2" renames the folder?

Actually, I came back to this bug for the second point, because it seems like I
hit it again... I hit "F2" as usual, and was asked to rename a picture. So I
remembered "my" bug, searched for it, and saw in comment #4 that "Shift+F2"
would do the trick : not really straightforward :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=287081

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Git commit d7f536a4030b664e99210ab696b4d3f4752ee220 by Maik Qualmann.
Committed on 03/08/2016 at 17:18.
Pushed by mqualmann into branch 'master'.

add shortcuts to context menu

M  +1    -0    app/utils/contextmenuhelper.cpp

http://commits.kde.org/digikam/d7f536a4030b664e99210ab696b4d3f4752ee220

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=287081

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|4.3.0                       |5.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=287081

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Albums-Icons

--
You are receiving this mail because:
You are the assignee for the bug.