[Bug 286212] New: Digikam's shortcut for Delete permanently does not work (shift + del).

[Thomas Damgaard]

https://bugs.kde.org/show_bug.cgi?id=286212

           Summary: Digikam's shortcut for Delete permanently does not
                    work (shift + del).
           Product: digikam
           Version: 2.3.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.3.0 (using KDE 4.7.2)
OS:                Linux

In 11.10, Digikam's shortcut for Delete permanently does not work (shift +
del).
This error is given when selecting an image and pressing shift+del:
http://i.imgur.com/CeBN5.png

When going to Configure Shortcuts and sorting by "shortcut" column, it appears
that there is only one action defined with this combo: delete permanently.
In other words: it is NOT ambiguous.

Configure shortcuts is shown here:
http://i.imgur.com/XWrzv.png


Reproducible: Always

Steps to Reproduce:
Select an image.
Press shift+del.


Actual Results:  
You get an error.


Expected Results:  
File deletion dialog should be shown.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=286212


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-11-12 13:57:36 ---
Look indeep in shortcuts config dialog, you will see that KDE define Edit/Cut
alternate shortcut as SHIFT+DEL...

Edit action are defined by KDE libs. It's factorized for all applications.

Proposal : use CTRL+DEL instead...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-11-12 14:07:31 ---
Following this page :
http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts

...CTRL+DEL is already used.

ALT+DEL sound like the solution

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=286212


Ananta Palani <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Ananta Palani <anantapalani gmail com>  2011-11-12 16:29:03 ---
On Windows, when working with files SHIFT+DEL is permanently delete a file.
Isn't there a way to tell KDE that permanently delete is the definite action
desired and override the ambiguity?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-12 16:52:21 ---
Shift+Del is working in Dolphin, and I know it's used in Windows Explorer. It's
definitely the right shortcut for "Delete permanently".

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-12 16:52:51 ---
See this code from dolphin:

    // need to remove shift+del from cut action, else the shortcut for
deletejob
    // doesn't work
    KAction* cut = KStandardAction::cut(this, SLOT(cut()), actionCollection());
    KShortcut cutShortcut = cut->shortcut();
    cutShortcut.remove(Qt::SHIFT | Qt::Key_Delete, KShortcut::KeepEmpty);
    cut->setShortcut(cutShortcut);

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-11-13 10:18:47 ---
Created an attachment (id=65584)
 --> (http://bugs.kde.org/attachment.cgi?id=65584)
SHIFT+DEL conflict

Marcel, Ananta,

You cannot see the same conflict on your computer with config dialog ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Damgaard]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #7 from Thomas Damgaard <thomasdn gmail com>  2011-11-13 15:51:11 ---
Marcel, I agree. Shift+Del works in Dolphin. And it is also used in Windows
Explorer. It is rather confusing that it does not work in digikam.

Another thing: it is really not great that the user receives and error only
telling her that the shortcut is ambiguous. It should provide more information,
such as:
1) *why* is it ambiguous -- i.e. which actions are defined to have this
shortcut combo.
2) *how* does the user solve the problem?
3) preferably the user should be given the option to choose which one of the
conflicting actions she wants to be working -- either in this particular
application or globally across all KDE applications.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=286212


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-13 16:28:31 ---
Git commit bdf416be9a5dcc3aedc58e64718b222890c49600 by Marcel Wiesweg.
Committed on 13/11/2011 at 17:27.
Pushed by mwiesweg into branch 'master'.

Remove secondary shortcut Shift+Del from Cut action, so that Delete permanently
can work

BUG: 286212

M  +2    -1    NEWS
M  +5    -0    digikam/main/digikamapp.cpp

http://commits.kde.org/digikam/bdf416be9a5dcc3aedc58e64718b222890c49600

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Damgaard]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #9 from Thomas Damgaard <thomasdn gmail com>  2011-11-13 18:45:56 ---
Thanks. Looking forward to try it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-14 18:40:00 ---

> 1) *why* is it ambiguous -- i.e. which actions are defined to have this
> shortcut combo.
> 2) *how* does the user solve the problem?
> 3) preferably the user should be given the option to choose which one of the
> conflicting actions she wants to be working -- either in this particular
> application or globally across all KDE applications.

I agree that the message box is not really helpful, but, it comes from kdelibs,
no code in digikam about this.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thomas Damgaard]

https://bugs.kde.org/show_bug.cgi?id=286212





--- Comment #11 from Thomas Damgaard <thomasdn gmail com>  2011-11-14 19:47:57 ---
Marcel, ok. Maybe this should be reported to kdelibs then. I am not familiar
with kdelibs. Are you? If so, will you report the bug there?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=286212

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=286212

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=286212

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.