[Bug 285683] New: Already imported pictures not recognized after daylight savings time

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=285683

           Summary: Already imported pictures not recognized after
                    daylight savings time
           Product: digikam
           Version: 2.2.0
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=65206)
 --> (http://bugs.kde.org/attachment.cgi?id=65206)
"DownloadHistory" table of digikam table

Version:           2.2.0 (using KDE 4.7.2)
OS:                Linux

While importing new pictures from an SD card, digikam normally recognizes the
pictures that has already been imported so that it's easy to import only the
new ones.
However, after the daylight savings time (30th of October 2011 this year),
digikam fails to recognize pictures already imported if they were taken before
30th of October ! I.e. : digikam considers these pictures are new (not imported
yet).

Reproducible: Always

Steps to Reproduce:
1) take a picture before daylight saving time
2) import that picture before daylight saving time with digikam
3a) import that picture again before daylight saving time with digikam => OK,
digikam shows that the picture has already been imported
3b) import that picture again AFTER daylight saving time with digikam => NOT
OK, digikam doesn't show that the picture has already been imported


Expected Results:  
Daylight saving time should not affect this !

The picture attached shows why this happens. It is a view of the
"DownloadHistory" table of the digikam database.
First highlighted item shows the first time the picture "IMG_1736" was imported
(in September) => the "filedate" field shows "20:33".
Second highlighted item shows when I imported this same picture yesterday (i.e.
after daylight saving time) => the "filedate" field shows "21:33".
Conclusion: depending when you import a picture (after or before daylight
saving time), the time ("filedate" field) is not the same => this bug happens.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=285683


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Import




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=285683





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-20 11:43:04 ---
This problem may be a bit out of our scope.
I assume this is the story: Modern filesystems store the time stamp in UTC,
while vfat stores it in local time. When accessing vfat, Linux will convert the
time to UTC, and there is a one hour difference after DST change.
I'm not quite sure about the Exif timestamps, I guess they'll be in camera
local time.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=285683





--- Comment #2 from Nicofo <nicofo tuxfamily org>  2011-12-10 20:47:40 ---
(In reply to comment #1)
> This problem may be a bit out of our scope.
I don't really agree with you: the fact is that the majority of memory cards
are vfat formatted (I think) => this must be taken into account.

There are several ways to avoid this problem: store the EXIF time instead (this
will avoid the problem because if you look the EXIF time of a photo after or
before the DST change, it will remain the same, which is not the case of the
file's time in VFAT).
Another solution (less clean) is to consider that a file has already been
downloaded if the 'filedate' field of the 'DownloadHistory' table is the same
or with 1 hour difference.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=285683





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-12-25 11:13:06 ---
Reading the Exif date is not an option because retrieving the metadata of all
pictures on the memory card would be very slow. The one-hour-off solution does
seem pretty dirty to me.

With "out of our scope" I mean that this seems to be a shortcoming of the
decades-old FAT. If this is indeed the case, and this is indeed applicable to
all memory cards, I would be open to an algorithm which a) confirms that the
memory card is vfat b) finds out the time of the DST in current time zone c)
computes the DST-corrected date of the given pictures.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #4 from Nicofo <[hidden email]> ---
Additional info:
Windows deals with DST in FAT file system but Linux doesn't and there is no
intention of changing that -> see
https://bugzilla.kernel.org/show_bug.cgi?id=68131

I'm surprised: am I the only one to be affected by this bug ? I think all the
cameras use vfat memory card and so every one that use 'import picture' in
digikam encounter this problem one day or another ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=285683

Islam Wazery <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #5 from Islam Wazery <[hidden email]> ---
No Nicofo you are not the only one affected by it, it's reproducible and I am
working on fixing it right now.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #6 from Nicofo <[hidden email]> ---
(In reply to comment #5)
> No Nicofo you are not the only one affected by it, it's reproducible and I
> am working on fixing it right now.

Great, thank you ! Next daylight saving time change will be on 29th of March,
I'll be there to test it ;-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Nicofo,

Can you reproduce the dysfunction using last digiKam 4.2.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #8 from Nicofo <[hidden email]> ---
Hi Gilles,
Yes, it is still reproducible with DK 4.4.

(In reply to Islam Wazery from comment #5)
> No Nicofo you are not the only one affected by it, it's reproducible and I am working on fixing it right now.
@Islam, any news since your previous message ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=285683

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.2.0                       |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #9 from [hidden email] ---
This file still valid using last digiKam 5.0.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #10 from Nicofo <[hidden email]> ---
Hi Gilles,
I don't remember problem last DST (was still digikam 4.14) -> I think this bug
can be closed. Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

--- Comment #11 from Nicofo <[hidden email]> ---
Created attachment 102058
  --> https://bugs.kde.org/attachment.cgi?id=102058&action=edit
Same picture undully imported twice

Hi,
I reopen this bug because, unlike I thought, it is actually not solved.

Last DST was last weekend (30 Oct): all the pictures I made before (and that I
had already imported) are not recognized anymore as already imported: if I
import "New items" in Digikam, all my pictures imported before DST are
re-imported again :(

See picture attached (file digikam4.db), with the example of one picture taken
before DST (25 Sept 18h35) but now recognized one hour later (25 Sept 19h35) so
re-imported by digikam.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

Nicofo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

Nicofo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.4.0                       |5.1.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=285683

Nicofo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|5.1.0                       |

--
You are receiving this mail because:
You are the assignee for the bug.