[Bug 284720] New: build fails with error

https://bugs.kde.org/show_bug.cgi?id=284720

           Summary: build fails with error
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Metadata
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unspecified (using KDE 4.7.1)
OS:                Linux

~/digikam-sc/core/libs/dmetadata/dmetadata.cpp: In static member function
‘static QString Digikam::DMetadata::valueToString(const QVariant&,
Digikam::MetadataInfo::Field)’:
~/digikam-sc/core/libs/dmetadata/dmetadata.cpp:2410:1: error: control reaches
end of non-void function [-Werror=return-type]
cc1plus: some warnings being treated as error


tcaswell@eowyn:~/other_source/digikam-sc$ g++ --version
g++ (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1


It seems that the compiler does not agree that the default case will keep the
program from getting out of the switch statement without returning.  Adding the
default return after the switch allows the code compile

Reproducible: Always

Steps to Reproduce:
update to head of master branch

Actual Results:  
-

Expected Results:  
-

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=284720





--- Comment #1 from Christoph Feck <christoph maxiom de>  2011-10-22 19:06:04 ---
Stupid compiler, but I guess there is no choice to add the redundant "return
QString();"

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=284720





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-10-23 05:36:04 ---
Which version do you compile ? Git/master ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=284720


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Francesco Riosa <francesco+kde pnpitalia it>  2011-10-23 11:55:21 ---
(In reply to comment #2)
> Which version do you compile ? Git/master ?
>
> Gilles Caulier

it's a gcc-4.6 warning, threathed like error,
http://commits.kde.org/digikam/5bf4ba612516d2c15d4e6659f9653ae574735ace

I've adopted the same solution as Christoph Feck #c1 in sql2.0 branch, should I
cherry pick it to master?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=284720


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-10-23 12:11:13 ---
yes, sure backport it and close this entry (:=)))

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=284720


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Francesco Riosa <francesco+kde pnpitalia it>  2011-10-23 15:49:56 ---
done

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=284720

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel