[Bug 283323] New: a new label _Digikam_root_tag_ is created every time

classic Classic list List threaded Threaded
120 messages Options
123456
Reply | Threaded
Open this post in threaded view
|

[Bug 283323] a new label _Digikam_root_tag_ is created every time

eldk
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #57 from [hidden email] ---
Hello,

using Digikam without writing and reading tags metadata from pictures "solve"
this too :

https://bugs.kde.org/show_bug.cgi?id=230602.

Greatings,

Eric

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] a new label _Digikam_root_tag_ is created every time

eldk
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #58 from [hidden email] ---
Hello,

you should have a look here too :

http://ninedegreesbelow.com/photography/dam-software-metadata.html

Greatings,

Eric

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] a new label _Digikam_root_tag_ is created every time

eldk
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #59 from [hidden email] ---
related to this too :

https://bugs.kde.org/show_bug.cgi?id=268688

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] a new label _Digikam_root_tag_ is created every time

alexander.s.m
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Alexander Meshcheryakov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #60 from Alexander Meshcheryakov <[hidden email]> ---
Occured for me with digiKam 3.3.0.

While tagging faces I got tag _Digikam_root_tag_ in tag list.

MariaDB [digikam4]> SELECT * FROM Tags WHERE name like '%Digikam%';
+----+------+-------------------------+------+---------+-----+-----+
| id | pid  | name                    | icon | iconkde | lft | rgt |
+----+------+-------------------------+------+---------+-----+-----+
|  0 |   -1 | _Digikam_root_tag_      |    0 | NULL    |   1 | 136 |
|  1 |    0 | _Digikam_Internal_Tags_ |    0 | NULL    |  90 | 135 |
| 87 |    0 | _Digikam_root_tag_      |    0 | NULL    |   2 |   5 |
+----+------+-------------------------+------+---------+-----+-----+

After removing _Digikam_root_tag_  from digiKam UI and restarting of digiKam I
do not see any tags in digiKam, but

MariaDB [digikam4]> SELECT COUNT(*) FROM Tags;
+----------+
| COUNT(*) |
+----------+
|       63 |
+----------+

MariaDB [digikam4]> SELECT COUNT(*) FROM Tags WHERE name like '%People%';
+----------+
| COUNT(*) |
+----------+
|        0 |
+----------+

Looks like my DB is messed up and I have to recreate it.

MySQL binlogs indicate that extra _Digikam_root_tag_ were created by following
queries

#130831 23:12:15 server id 1  end_log_pos 65360732      Intvar
SET INSERT_ID=87/*!*/;
# at 65360732
#130831 23:12:15 server id 1  end_log_pos 65360780      User_var
SET @`myLeft`:=1/*!*/;
# at 65360780
#130831 23:12:15 server id 1  end_log_pos 65360942      Query   thread_id=8340
exec_time=0     error_code=0
SET TIMESTAMP=1377976335/*!*/;
INSERT INTO Tags(name, pid, lft, rgt) VALUES('_Digikam_root_tag_', 0, @myLeft +
1, @myLeft + 2)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|a new label                 |MySQL : a new label
                   |_Digikam_root_tag_ is       |_Digikam_root_tag_ is
                   |created every time          |created every time

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veaceslav.munteanu90@gmail.
                   |                            |com

--- Comment #61 from Gilles Caulier <[hidden email]> ---
veaceslav,

outside the fact that people try to investigate the origin of this problem by
an analysis of database tag structures, i think you have solved this issue
recently to drop older and unwanted tags to plug in database from image
metadata.

Right ?

See comment #10 for details.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Veaceslav Munteanu-2
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #62 from Veaceslav Munteanu <[hidden email]> ---
I added checks and sanitize functionality for Image Scanner and to metadata
write functionality.

But I don't know how to sanitize an existing database with _Digikam_root_tags_
in it rather than writing tags to image, drop everything and re-read them
back..

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #63 from Gilles Caulier <[hidden email]> ---
The database marked with older and obsolete tags is a fact.

At least with 4.2.0, these tags will must never re-appear after a cleanup of
database content and a sync from image metadata to database.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #64 from Gilles Caulier <[hidden email]> ---
To all people in this room who have experience this problem, i recommend to
test with digiKam 4.2.0 where Veaceslav have patched image scanner to prevent
post creation of obsolete tags in database.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MySQL : a new label _Digikam_root_tag_ is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #65 from Gilles Caulier <[hidden email]> ---
*** Bug 325331 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MySQL : a new label         |MYSQL : a new label
                   |_Digikam_root_tag_ is       |"_Digikam_root_tag_" is
                   |created every time          |created every time

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

Gilles Caulier-4
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database                    |Database-Mysql

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CONFIRMED

--- Comment #66 from [hidden email] ---
From Marcel Wiesweg, by private email :

"I believe the root of the problem is the TagsTree table. This table is only
maintained to allow searching in a tag including all child tags. In SQLite, it
always worked, in MySQL, there were problems and a solution with another tree
structure which I have never really understood.
This tree seems to create a lot of problems.

Alternative solution for the problem is to find in the C++ search code, all
child tags (readily available from TagsCache), and add them as bound values
(WHERE tagid IN (?,?,?....)).
This was limited for SQLite which only supports 999 bound values, and that
limit can be hit easily.

For MySQL, the limit appears to be 65536, which is feasible. Optimizations are
possible (using boost interval etc.)"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #67 from [hidden email] ---
This is still an issue with digikam5.0.0-beta6 version.

I'm able to reproduce it.

My log:

MariaDB [digikam]> select * from Tags;  
+----+------+----------------------------+------+---------+-----+-----+
| id | pid  | name                       | icon | iconkde | lft | rgt |
+----+------+----------------------------+------+---------+-----+-----+
|  0 |   -1 | _Digikam_root_tag_         | NULL | NULL    |   1 |  80 |
|  1 |    0 | _Digikam_Internal_Tags_    | NULL | NULL    |  38 |  79 |
|  2 |    1 | Original Version           | NULL | NULL    |  77 |  78 |
|  3 |    1 | Intermediate Version       | NULL | NULL    |  75 |  76 |
|  4 |    1 | Current Version            | NULL | NULL    |  73 |  74 |
|  5 |    1 | Version Always Visible     | NULL | NULL    |  71 |  72 |
|  6 |    0 | People                     | NULL | NULL    |  22 |  37 |
|  7 |    6 | Monica Geller              | NULL | NULL    |  35 |  36 |
|  8 |    6 | Ross Geller                | NULL | NULL    |  33 |  34 |
|  9 |    6 | Phoebe Buffay              | NULL | NULL    |  31 |  32 |
| 10 |    6 | Joey Tribbiani             | NULL | NULL    |  29 |  30 |
| 11 |    0 | friends                    | NULL | NULL    |  20 |  21 |
| 12 |    6 | Chandler Bing              | NULL | NULL    |  27 |  28 |
| 13 |    6 | Rachel Green               | NULL | NULL    |  25 |  26 |
| 14 |    1 | Color Label None           | NULL | NULL    |  69 |  70 |
| 15 |    1 | Color Label Red            | NULL | NULL    |  67 |  68 |
| 16 |    1 | Color Label Orange         | NULL | NULL    |  65 |  66 |
| 17 |    1 | Color Label Yellow         | NULL | NULL    |  63 |  64 |
| 18 |    1 | Color Label Green          | NULL | NULL    |  61 |  62 |
| 19 |    1 | Color Label Blue           | NULL | NULL    |  59 |  60 |
| 20 |    1 | Color Label Magenta        | NULL | NULL    |  57 |  58 |
| 21 |    1 | Color Label Gray           | NULL | NULL    |  55 |  56 |
| 22 |    1 | Color Label Black          | NULL | NULL    |  53 |  54 |
| 23 |    1 | Color Label White          | NULL | NULL    |  51 |  52 |
| 24 |    1 | Pick Label None            | NULL | NULL    |  49 |  50 |
| 25 |    1 | Pick Label Rejected        | NULL | NULL    |  47 |  48 |
| 26 |    1 | Pick Label Pending         | NULL | NULL    |  45 |  46 |
| 27 |    1 | Pick Label Accepted        | NULL | NULL    |  43 |  44 |
| 28 |    6 | Joey Tribbianii            | NULL | NULL    |  23 |  24 |
| 29 |    0 | singer                     | NULL | NULL    |  10 |  19 |
| 30 |   29 | adam                       | NULL | NULL    |  17 |  18 |
| 31 |   29 | ellie_goulding             | NULL | NULL    |  15 |  16 |
| 32 |   29 | enrique                    | NULL | NULL    |  13 |  14 |
| 33 |   29 | eminem                     | NULL | NULL    |  11 |  12 |
| 34 |    1 | Need Resolving History     | NULL | NULL    |  41 |  42 |
| 35 |    1 | Need Tagging History Graph | NULL | NULL    |  39 |  40 |
| 36 |    0 | smiley                     | NULL | NULL    |   4 |   9 |
| 37 |   36 | cry_laugh                  | NULL | NULL    |   7 |   8 |
| 38 |   36 | tongue_out                 | NULL | NULL    |   5 |   6 |
| 39 |    0 | nature                     | NULL | NULL    |   2 |   3 |
+----+------+----------------------------+------+---------+-----+-----+
40 rows in set (0.00 sec)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #68 from [hidden email] ---
Yes, it is. Look in Mysql DB schema :

https://quickgit.kde.org/?p=digikam.git&a=blob&h=5fd4abfe3318e37cba448551a769325217590ff2&hb=ebba4691ef367bbe15bd2b2c8dfe6e582b1668f5&f=data%2Fdatabase%2Fdbconfig.xml.cmake.in#l1202

About this topic, Richard Mortimer has already take a look into this file :

https://bugs.kde.org/show_bug.cgi?id=355831

... to fix this problem with a patch, if i'm not too wrong... but this do not
work. Look at comment #55 for details :

https://bugs.kde.org/show_bug.cgi?id=355831#c55

And my test results at comment #59 :

https://bugs.kde.org/show_bug.cgi?id=355831#c59

In all cases, there are a lots of information in bug #355831 for your GSoC 2016
project.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

Richard Mortimer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #69 from Richard Mortimer <[hidden email]> ---
First step to resolve this has to be to add UNIQUE(name, pid) to the MySQL
version of the Tags table (around line 1056 in dbconfig.xml.cmake).

That will at least force MySQL to reject any attempts to add duplicates. Once
that is done then it should be easier to find out why digikam is trying to add
the duplicates in the first place.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #70 from [hidden email] ---
Hello,

I still use digikam 3.5 with mysql.

As I don't write tags to pictures, only mysql support, I have had never again a
double _digikam_root_tag.

Exception : importing some images that aren't mine and that include tags
(forget to erase them with exiftool before collection scan/digikam start).  

hope it will helps.

Eric

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #71 from [hidden email] ---
(In reply to Richard Mortimer from comment #69)
> First step to resolve this has to be to add UNIQUE(name, pid) to the MySQL
> version of the Tags table (around line 1056 in dbconfig.xml.cmake).
>
> That will at least force MySQL to reject any attempts to add duplicates.
> Once that is done then it should be easier to find out why digikam is trying
> to add the duplicates in the first place.

Is this fine?

CREATE TABLE `Tags` (
    ->   `id` int(11) NOT NULL AUTO_INCREMENT,
    ->   `pid` int(11) DEFAULT NULL UNIQUE,
    ->   `name` varchar(100) CHARACTER SET utf8 NOT NULL UNIQUE,
    ->   `icon` int(11) DEFAULT NULL,
    ->   `iconkde` longtext CHARACTER SET utf8,
    ->   `lft` int(11) NOT NULL,
    ->   `rgt` int(11) NOT NULL,
    ->   PRIMARY KEY (`id`),
    ->   KEY `Tags_Images` (`icon`),
    ->   CONSTRAINT `Tags_Images` FOREIGN KEY (`icon`) REFERENCES `Images`
(`id`) ON DELETE SET NULL ON UPDATE CASCADE
    -> ) ENGINE=InnoDB AUTO_INCREMENT=40 DEFAULT CHARSET=utf8mb4;

For column 'name' I changed from TEXT to VARCHAR ('cause it gave error:
TEXT/BLOB column 'name' used in key specification without key length)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #72 from Richard Mortimer <[hidden email]> ---
I've tended to keep LONGTEXT and use a length on the index. That way a long tag
name will not totally break things - but will likely cause unexpected
behaviour.

Try

CREATE TABLE IF NOT EXISTS Tags
                            (id INTEGER PRIMARY KEY NOT NULL AUTO_INCREMENT,
                            pid INTEGER,
                            name LONGTEXT CHARACTER SET utf8 NOT NULL,
                            icon INTEGER,
                            iconkde LONGTEXT CHARACTER SET utf8,
                            lft INT NOT NULL,
                            rgt INT NOT NULL,
                            UNIQUE(pid, name(100)),
                            CONSTRAINT Tags_Images FOREIGN KEY (icon)
REFERENCES Images (id) ON DELETE SET NULL ON UPDATE CASCADE
                            ) ENGINE InnoDB;

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 283323] MYSQL : a new label "_Digikam_root_tag_" is created every time

bugzilla_noreply
In reply to this post by Leo-2
https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #73 from [hidden email] ---
Created attachment 99945
  --> https://bugs.kde.org/attachment.cgi?id=99945&action=edit
To remove duplicates from Tags table

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
123456