[Bug 283323] New: a new label _Digikam_root_tag_ is created every time

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #85 from [hidden email] ---
Maik,
i cannot confirm your comment #84. I run digiKam with patch version 100045 with
a fresh database (i delete /var/lib/mysql and restart mysqld to be sure. The DB
created is clean. I create myself the digiKam DB in Mysql repository using SQL
statements  from DK config panel. After the first scan, the _root_ tag appear
in left and right Tags panels.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #86 from [hidden email] ---
Maik,

Do you seen any slow down performance with a fresh DB created, typically at
first scan ? Look in the console if registration to DB take time latency (1/2
seconds here). Previously, i never see this with remote Mysql DB (same
computer, same configuration)

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #87 from Maik Qualmann <[hidden email]> ---
Gilles,

I have tested it with patch #100118.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #88 from Maik Qualmann <[hidden email]> ---
Gilles,

No slow DB access with a new internal DB on the first scan here.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #89 from [hidden email] ---
(In reply to Maik Qualmann from comment #84)
> In an old DB the tag _Digikam_root_tag_ still exists. When a new DB is
> created, the tag _Digikam_root_tag_ no longer appear. Do we need QRegExp? Is
> enough no simple QLatin1String?

I think QRegExp is fine to use here for pattern matching in the strings.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #90 from [hidden email] ---
Maik,

Currently i test with new version patch. Do you seen that splashscreen is
frozen on screen while long first scanning without any progress indicator and
without any text message on the top ?

https://www.flickr.com/photos/digikam/27722159883/in/dateposted-public/

In fact, while scanning, the Progress dialog must be show in all cases, even if
user turn on splashscreen option. In this last case, the splashscreen must be
show when scan is completed. It will appear few seconds only, and it's enough.

There is already a report open about this topic in bugzilla if i remember.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #91 from [hidden email] ---
Another problem : If images in collection have been previously managed with
option to save tags in image metadata, the _root_ tags will be restored in a
fresh database.

I'm sure that my  collection is in this use case.

I don't know if metadata hub has already the rules to drop this internal tag
while scanning.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #92 from [hidden email] ---
The first scan is complete with the new patch version. It took 20 mn !

The _root_ tag is not restored. So it's not present in my images metadata or
Metadata Hub do the job properly. This point still to verify to be sure.

So the new patch version look better until now.

Now i start the face detection scan to see if _root_ tag is recreated.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #93 from [hidden email] ---
Note : Face Scan is started with "Clear unconfirmed results and rescan" +
"Detect faces" options.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #94 from [hidden email] ---
I confirm : new patch is really better as not _root_ tag appear in tree-view
after face scan. Good job Swati...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #95 from [hidden email] ---
Now i will scan items to generate fuzzy fingerprints to find duplicates.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #96 from [hidden email] ---
Maik,

metadathub.cpp::line 553 and imagescanner.cpp::line 840 has all rules to
prevent _root_ tag to be imported to DB.

So for your problem "In an old DB the tag _Digikam_root_tag_ still exists", I
think a migration rule must be written to clean up the registration of internal
tag to items.

Swati, what do you think about ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #97 from [hidden email] ---
The fuzzy FingerPrints process is done. No _root_ tag here...

I restarted digiKam  just to be sure, no _root_ tag here...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #98 from [hidden email] ---
(In reply to caulier.gilles from comment #94)
> I confirm : new patch is really better as not _root_ tag appear in tree-view
> after face scan. Good job Swati...

Thank you!

(In reply to caulier.gilles from comment #96)
> Maik,
>
> metadathub.cpp::line 553 and imagescanner.cpp::line 840 has all rules to
> prevent _root_ tag to be imported to DB.
>
> So for your problem "In an old DB the tag _Digikam_root_tag_ still exists",
> I think a migration rule must be written to clean up the registration of
> internal tag to items.

Could you please elaborate on this?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #99 from [hidden email] ---
"In an old DB the tag _Digikam_root_tag_ still exists"

It's clear. If this tag still appear in tree-view, certainly it's assigned to
item as well (as a normal tag). As Maik can reproduce the problem (not me), he
can check this kind of situation in DB.

If it's the case, well something must be done to remove these assignation in
older database : a migration of contents to prevent _root_ tag visibility in
treeview.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #100 from [hidden email] ---
Hello,

Le samedi 16 juillet 2016 à 09:28 +0000, via KDE Bugzilla a écrit :
> https://bugs.kde.org/show_bug.cgi?id=283323
>
> --- Comment #99 from [hidden email] ---
> "In an old DB the tag _Digikam_root_tag_ still exists"
>
> It's clear. If this tag still appear in tree-view, certainly it's assigned to
> item as well (as a normal tag). As Maik can reproduce the problem (not me), he
> can check this kind of situation in DB.

As I have said in a earlyer response :

1 - clear all embedded metadata from image before "scanning" it with
Digikam make disapear extra "_digikam_root_tag"

2 - don't write metadata to image with digikam (only stored in mysql
db), prevent digikam to fill mysql db with extra "_digikam_root_tag"

3 - forgive to erase metadata from image before "scanning", should make
"_digikam_root_tag" appear again, even if image has no embeded
"_digikam_root_tag".

I have it working like this (no metadata writed to image, and only
stored in mysql) with old digikam 3.5 and mysql on a
multi-digikam-client config

Greatings,

Eric


>
> If it's the case, well something must be done to remove these assignation in
> older database : a migration of contents to prevent _root_ tag visibility in
> treeview.
>
> Gilles
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #101 from [hidden email] ---
Git commit eb6318a45efe1e08f35da450633f3bcb1027fd6a by Swati Lodha.
Committed on 16/07/2016 at 09:51.
Pushed by swatil into branch 'master'.

Remove _digikam_root_tag_ from tag tree-view

M  +3    -1    data/database/dbconfig.xml.cmake.in
M  +8    -1    libs/database/tags/facetags.cpp
M  +10   -2    libs/database/tags/tagscache.cpp

http://commits.kde.org/digikam/eb6318a45efe1e08f35da450633f3bcb1027fd6a

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

--- Comment #102 from [hidden email] ---
Maik

Could this file be closed now, with the last commit?

Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://quickgit.kde.org/?p
                   |                            |=digikam.git&a=commit&h=eb6
                   |                            |318a45efe1e08f35da450633f3b
                   |                            |cb1027fd6a
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.1.0
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=283323

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #103 from Simon <[hidden email]> ---
*** Bug 374988 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.