[Bug 281877] New: Redo same result as discard changes

[Rinus]

https://bugs.kde.org/show_bug.cgi?id=281877

           Summary: Redo same result as discard changes
           Product: digikam
           Version: 2.1.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.1.0 (using KDE 4.7.0)
OS:                Linux

Whichever point of edit step redo I select, it reverts step by step with the
ultimate result being same as discard changes.

Reproducible: Always

Steps to Reproduce:
as descibed

Actual Results:  
as described

Expected Results:  
As digikam editor is aware of which step at a certain point can be reverted, it
would be nice if this was reflected in the menu, by graying out steps that are
not available or group all steps that will be involved in a reversion to the
selected point and do this steps at once, so not doing something you did not
expect, no matter how logical explainable digikams action is, it is different
from choosed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=281877





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-09-12 19:23:54 ---
I understand that you pick an item from the submenu (downwards arrow of the
redo toolbar button) but as a result all available steps are redone?
Undo (backwards) or redo (undo undone step)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=281877


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-11-24 11:40:58 ---
Rinnus,

Can you reproduce the problem with current implementation from Git/Master (next
2.4.0) ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=281877


Farhan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]




--- Comment #3 from Farhan <farhand98 gmail com>  2011-12-06 16:22:58 ---
On DigiKam 2.3.0, after applying the effect, the Redo button is disabled.

I think the user may have meant Undo.

After applying, if I Undo, I get back the image prior to applying the full
effect i.e if i choose blur, try out blur at different settings and apply, I
get the unblurred image and not one of the "set blur where I hadn't clicked OK
yet".

In Photoshop, I can Undo every small change like a blur but we use the mouse
there and it has a different interface.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=281877





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-12-18 17:25:07 ---
Rinus,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=281877





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2012-02-21 18:48:44 ---
Git commit fec6928e7e1b2300ae9c667503843162842e44c1 by Marcel Wiesweg.
Committed on 21/02/2012 at 19:47.
Pushed by mwiesweg into branch 'master'.

Fix order of redo actions. Functionality was correct, but labelling was
reversed.

M  +6    -2    utilities/imageeditor/canvas/undomanager.cpp

http://commits.kde.org/digikam/fec6928e7e1b2300ae9c667503843162842e44c1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=281877


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME




--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2012-02-21 18:49:47 ---
Undo/redo works fine for me. I have fixed a little problem with a reverse
labelling of redo steps. No further input here from original reporter, so
closing.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=281877





--- Comment #7 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-21 20:42:40 ---
Git commit 19d4c9201ccd175ed67cee0724413e087fb4b0e2 by Francesco Riosa.
Committed on 21/02/2012 at 21:40.
Pushed by riosa into branch 'master'.

[lcms2] tag buffer need initialization

M  +4    -1    libs/dklcms/digikam-lcms.cpp

http://commits.kde.org/digikam/19d4c9201ccd175ed67cee0724413e087fb4b0e2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=281877


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |FIXED




--- Comment #8 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-21 23:27:37 ---
Git commit 326c8803e3740dfbd421a537b6226c2a25bd4426 by Francesco Riosa.
Committed on 22/02/2012 at 00:22.
Pushed by riosa into branch 'master'.

[lcms2] fixed a cast bug in cmsFloat2XYZEncoded()

We are now at feature parity with lcms1.
There are differences between the two implementations, they are
quantifiable even in 8bit images.

lcms2 should be more precise (and faster) than lcms1

M  +1    -7    libs/dklcms/digikam-lcms.cpp
M  +0    -3    libs/dklcms/digikam-lcms.h

http://commits.kde.org/digikam/326c8803e3740dfbd421a537b6226c2a25bd4426

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=281877


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Francesco Riosa <francesco+kde pnpitalia it>  2012-02-21 23:36:11 ---
latest two comment obviously on the wrong bug :-/

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=281877

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel