[Bug 278490] New: Incorrect focus path in tool settings panels

https://bugs.kde.org/show_bug.cgi?id=278490

           Summary: Incorrect focus path in tool settings panels
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.5)
OS:                Linux

When I want to go from one element to another one using the "tabulation" key,
the focus path seems incorrect in most of the panels.
In particular, everytime there is a slider, a spin box*, and a "reset" button,
the layout shows the slider at the left, the box in the middle, and the button
on the right. However, if the spin box is focus-active and I hit "tab", the
slider to its left gets focused (while either the reset button or the slider on
the next line should)

* For me (Java developer :-) ), a spin box is an input field for numbers, with
two small arrows to its left to increment/decrement the value :-)

Reproducible: Didn't try

Steps to Reproduce:
-in the Editor, use Transform/resize
-click in the "width" spin box
-hit tab

Actual Results:  
-the "width" slider gets focused

Expected Results:  
-the "height" slider gets focused

OS: Linux (x86_64) release 2.6.38.8-35.fc15.x86_64
Compiler: gcc
Locale : French (i.e natural layout is from left to right)

to be sure to get understood, layout is as follow :
WIDTH_SLIDER   -  WIDTH_SPINBOX   -  (WIDTH_RESET)
HEIGHT_SLIDER  -  HEIGHT_SPINBOX  -  (WIDTH_RESET)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=278490





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-08-06 16:04:02 ---
Frederic:
Work is needed in two different directions.
1) slider and spinbox come in a single component named KIntNumInput from KDE
libraries. There is no clean way to change tab order for us. I would ask you to
file a separate bug report against KDE libs: The slide is created after the
spinbox, but placed on the left; setTabOrder would be needed to make the tab
move from left to right.
2) I fixed the tab order in the resize widget and for the Ok/Cancel buttons
below. Which other tools have tab order problems, ignoring the slider/spinbox
bug?

Note to developers: Apparently tab order is determined by the time the widget
is added to its parent, either at construction if the parent is given to the
constructor, or when adding to a layout when no parent is given to the
constructor.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=278490





--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-08-06 16:04:56 ---
Git commit 1ada12e82688edba047b4a96e8c32f55c11f9203 by Marcel Wiesweg.
Committed on 06/08/2011 at 18:04.
Pushed by mwiesweg into branch 'master'.

Fix tab order for the resize tool and for the EditorTool buttons

CCBUG: 278490

M  +4    -4    imageplugins/transform/resizetool.cpp
M  +13   -6    utilities/imageeditor/editor/editortoolsettings.cpp

http://commits.kde.org/digikam/1ada12e82688edba047b4a96e8c32f55c11f9203

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=278490





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-11-24 11:37:28 ---
To Marcel, #1

Thanks for the tab layout tip managed by Qt.

I don't know if other tool need to be patched. At least, the most important is
to move this file on KDElibs to fix KIntNumInput and KDoubleNumInput widget tab
order.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=278490


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |kdeui
            Version|2.0.0                       |Git
            Product|digikam                     |kdelibs




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=278490


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[hidden email]       |[hidden email]
            Summary|Incorrect focus path in     |KIntNumInput and
                   |tool settings panels        |KDoubleNumInput : Incorrect
                   |                            |tab layout (orginal report
                   |                            |from digiKam about tab
                   |                            |layout in tools settings
                   |                            |tab from editor)




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel