[Bug 277429] New: Write out face rectangles to XMP file

https://bugs.kde.org/show_bug.cgi?id=277429

           Summary: Write out face rectangles to XMP file
           Product: digikam
           Version: 2.0.0
          Platform: Unlisted Binaries
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Face Detection
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.2)
OS:                Linux

Digikam only stores the face rectangles in its DB.  It would be nice if it
would also store that data in the XMP tag or sidecar associated with the image.

The question is, what should the format look like?  Digikam already writes out
some tags for compatibility with Windows Live (for tags, not faces).  Here's
what Windows Live does for faces:

http://msdn.microsoft.com/en-us/library/ee719905%28VS.85%29.aspx

At any rate, I'd like it if I could move files in and out of digikam without
losing the face rectangle.


Reproducible: Always

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277429


Leif Huhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE




--- Comment #1 from Leif Huhn <leif dkstat com>  2011-07-09 23:05:17 ---


*** This bug has been marked as a duplicate of bug 271030 ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=277429


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|DUPLICATE                   |




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-09-15 16:54:55 ---
Reopening this bug: (solved) 271030 implemented importing Window Live gallery
tags, but writing digikam faces to metadata is not implemented.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277429


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-12-14 14:02:22 ---
Leif,

As with bug 271030, you are welcome to provide patch to write face tag in XMP
Window Live gallery tags.

Thanks in advance for your help.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[harry]

https://bugs.kde.org/show_bug.cgi?id=277429

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from [hidden email] ---
Hi

Does digikam still not write facetags to image files?

Thanks,
Harry

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nick Andrik]

https://bugs.kde.org/show_bug.cgi?id=277429

Nick Andrik <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Nick Andrik <[hidden email]> ---
I think digikam still does not write face info in XMP.MP tags:
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Microsoft.html#MP

If what you need is a patch for that, could you please give me a pointer on
where to check (in digikam code) in order to add it?

Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #6 from Marcel Wiesweg <[hidden email]> ---
In libs/dmetadata/dmetadata.cpp, there is a method DMetadata::getImageFacesMap
which implements the reading part. First step would be to implement the writing
part here.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Nick,

Thanks to contribute. As Marcel said look in this method :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dmetadata/dmetadata.cpp#L1217

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #8 from Felix Leif Keppmann <[hidden email]> ---
Hi all,

i am interested too and will install the toolchain again to test this
functionality if related changes are commited.

Regards
Felix Leif

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dominic Lyons]

https://bugs.kde.org/show_bug.cgi?id=277429

Dominic Lyons <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Dominic Lyons <[hidden email]> ---
There is also a XMP schema from the Metadata Working Group. At
http://www.metadataworkinggroup.org/specs/ you find the spec (page 59 of the
pdf) and test files. The specification also gives hints about resizing,
rotation and so on, although this probably is out of focus at the moment.

Exiv2 supports the mwg-rg schema and it seems very similar to the MP schema
(both use normalized values). So maybe it would be possible to write both
schemes with only little additional effort.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #10 from Marcel Wiesweg <[hidden email]> ---
Rotation is important, faces are recognized in "correct" rotation which can
differ from pixel arrangement in the file, so the standard must define the
applicable rotation.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nick Andrik]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #11 from Nick Andrik <[hidden email]> ---
Can you please also tell me where to call this function from?
(I guess chosen by a checkbox in geolocation window just as "write tags to
XMP")

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Nick Andrik]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #12 from Nick Andrik <[hidden email]> ---
Oops, ignore the comment in parentheses, it was for another bug.
But the question is still valid: when should I call the writeFaces function
(just for testing).

Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Nick,

Some words about DMetadata::getImageFacesMap(). As Marcel said, it's read Face
Tags registered in image metadata to populate digiKam database. It's used here
:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/database/imagescanner.cpp#L593

ImageScanner class is used when a new items is detected on collection. Whole
image metadata are scanned...

As you can see in this method, there are 3 classes used to manage faces on DB :

- FaceTags :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/database/faces/facetags.h

- FaceTagsEditor :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/database/faces/facetagseditor.h

- TagRegion :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/database/core/tagregion.h

Now about future DMetadata::setImageFacesMap(), the complete goal to implement
is not trivial. You need to patch a lots of place in digiKam, including setup
metadata dialog.

- The lead class used to write and update metadata to image and DB, is
MetadatHub

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/fileaction/metadatahub.h

This class manage the way to update metadata in file accordingly with digiKam
Metadata Setup options set by end users in config dialog :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/setup/setupmetadata.cpp

.. where a new option need to be add to handle face writing stuff...

But in the first way, you need to write DMetadata::setImageFacesMap(). Do hack
it, i recommend to write a small test command line program as some exist here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/show/tests

We have already written test program for libkexiv2 (DMetadata is a drivated
class of KExiv2). As your new method will be introduced in digiKam core, you
cannot set this test program in libkexiv2, but you can take inspiration from
existing test program from Kexiv2 here :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2/repository/revisions/master/show/test

Only after to have finalized DMetadata::setImageFacesMap(), the rest of digiKam
metadata stuff need to be patched.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kristian Karl]

https://bugs.kde.org/show_bug.cgi?id=277429

Kristian Karl <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #14 from Kristian Karl <[hidden email]> ---
*** This bug has been confirmed by popular vote. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=277429

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #15 from Veaceslav Munteanu <[hidden email]> ---
Hello. I'm working on this bug. Indeed it's more complex that it looks like.
For now I tried to hack setImagesFaceTags() but it was a little complicated. It
seem that I'm unable to use just libkexiv2, I had to use exiv2 itself and set
up a new method for libkexiv2. I don't know if it's ok like this, but here is
the result. Look at my last commit:

https://github.com/veaceslav/Exiv2-hacking/commits/master

Please review if you can.

A bigger patch with digikam this method integrated is coming, but for now I'm
going to sleep :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #16 from Veaceslav Munteanu <[hidden email]> ---
Hello, this is my first patch.

https://git.reviewboard.kde.org/r/109087/

Please review it and give me you opinion

Thank you,

Veaceslav

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #17 from Gilles Caulier <[hidden email]> ---
Veaceslav,

Do you see this comment about face tags from Picasa and an open source
application named PicFace :

https://bugs.kde.org/show_bug.cgi?id=217991#c4

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #18 from Gilles Caulier <[hidden email]> ---
Veaceslav,

See also this entry : https://bugs.kde.org/show_bug.cgi?id=313190

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=277429

--- Comment #19 from Veaceslav Munteanu <[hidden email]> ---
Thank you Gilles,

for now I should implement:
1. Auto-rotate picassa tags according to exif tag
2. Trigger metadata write when tag updated
3. Rotate tags when image is rotated by exif flag(now only rotates when image
itself is rotated)

Still so much to do...

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel