[Bug 276096] New: PGF images not shown if zoom is set to 100%

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096

           Summary: PGF images not shown if zoom is set to 100%
           Product: digikam
           Version: 2.0.0
          Platform: openSUSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.4)
OS:                Linux

With the latest PGF changes the image editor just shows an empty pane when the
zooming is set to 100%.

Reproducible: Didn't try

Steps to Reproduce:
Open the image editor with some picture and set the zooming to 100%.
Close the ditor and open a PGF in the editor via pressing F4. No picture is
shown.
Click on "fit to screen" to see the image.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 16:09:18 ---
There is no reason to see this problem with only PGF images... zoom level don't
care about image format.

Please checkout my last changes performed tody about libpgf and try again.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #2 from S. Burmeister <sven burmeister gmx net>  2011-06-21 16:20:42 ---
Same issue. Even the small preview that appears if you click on the icon
inbetween the horizontal and the vertical scroll-bar at the bottom-right just
shows an empty frame if the zoom is set to 100%. Works with non-pgf pictures.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-06-21 16:57:10 ---
Can you attach PGF file to this entry ?

which option you use about preview. Do you load full image size in this mode ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #4 from S. Burmeister <sven burmeister gmx net>  2011-06-21 22:50:53 ---
It's the image editor, not the preview in the album view.

If the image fits completely into the image pane in the editor at 100% it is
shown. If it is larger and would not be shown completely the issue occurs.

Currently I cannot attach a sample picture because even with lossy compression
set to 9 (lowest quality) a 2 MPx picture is bigger than the 1 MB max
attachment size.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-22 22:11:23 ---
send it to me by private mail

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #6 from S. Burmeister <sven burmeister gmx net>  2011-06-28 08:06:59 ---
If you make the image editor's window small enough you can reproduce it with
the test images from
digikam-software-compilation/core/tests/databases/testimages/a2/pgf>

Attached is what I see at zoom 120% and 100%

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #7 from S. Burmeister <sven burmeister gmx net>  2011-06-28 08:11:39 ---
Created an attachment (id=61396)
 --> (http://bugs.kde.org/attachment.cgi?id=61396)
120% zoom

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #8 from S. Burmeister <sven burmeister gmx net>  2011-06-28 08:12:26 ---
Created an attachment (id=61397)
 --> (http://bugs.kde.org/attachment.cgi?id=61397)
100% zoom

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-06-28 10:41:58 ---
Incredible,

converting
digikam-software-compilation/core/tests/databases/testimages/a2/pgf/foto001q5.pgf
to png, and problem disappear...

i can reproduce the problem. Change zoom level, and look artifacts with canvas
tile mechanism. I already see this problem in old past...

It due to a precision issue with tile size computation, probably about image
size. code is there :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/canvas/canvas.cpp#L628

Gilles Caulier




Gilles Cauier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2011-06-28 10:43:56 ---
Created an attachment (id=61405)
 --> (http://bugs.kde.org/attachment.cgi?id=61405)
canvas tile artifacts

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2011-06-28 10:45:18 ---
Zoom to 768% and look the result.

I think image data are not corrupted. Export this image as well to PNG, and
load it. All is fine.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 17:03:05 ---
Git commit 3f5e6a3c587aa27573f6b421928f4f9af2da10fc by Marcel Wiesweg.
Committed on 30/06/2011 at 22:09.
Pushed by mwiesweg into branch 'master'.

If the image has no alpha channel, we can avoid QPixmap scanning the whole
image for
transparent pixels if we specify the correct QImage format.
As a side effect, this fixes bug 276096, but as explained there, there's a
libpgf regression as well.

CCBUG: 276096

M  +2    -2    libs/dimg/dimg.cpp    

http://commits.kde.org/digikam/3f5e6a3c587aa27573f6b421928f4f9af2da10fc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 17:03:45 ---
This one was difficult to debug.

At the root, there is a libpgf regression: When the image has no alpha
channel, the alpha byte is set to 0, instead of 255.
(we initialize the memory with 0xFF, which seems unnecessary, given that
libpgf seems to fully write the memory including the alpha byte).

Afterwards, the story goes so that we see the problem only in a very specific
case:
Whenever we scale, the alpha byte is ignored because hasAlpha is false, so all
is well. At 100%, no scaling is done, and we pass the data as is to QImage and
then to QPixmap. QPixmap sees transparent pixels and produces a transparent
pixmap.

I will commit an optimization which as a side-effect fixes the problem here -
if alpha is false, the image is RGB32 and not ARGB32, which frees QPixmap from
scanning the image for transparent pixels.

but I think the underlying regression must be fixed in libpgf, it should
preferably write 255 to the alpha channel, or not touch the alpha channel (and
say so in the API docs)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2011-07-11 17:44:29 ---
Raphael,

Please take a look in Marcel comment #13. There is a regression in libpgf since
i updated the library in digiKam core to 6.1.24.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #15 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-11 23:52:22 ---
Marcel,

> This one was difficult to debug.

sorry for that one. I suspect we introduced this behaviour when attempting to
fix the non-determinism (i.e. we now initialize all buffers).

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #16 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-12 00:43:03 ---
Can anyone confirm that this problem also exists in 1.9.0?

Thanks
- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2011-07-12 04:23:47 ---
In 1.9.0, libpgf is not updated with last version. In fact 1.9.0 is not
maintained.

But i can do it using an external version of libpgf and recompiling 1.9.0 as
well. I will do it today.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #18 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-12 10:14:08 ---
Just tested with 1.9.0 (from package repository, using libPGF 6.09.44) on
another Ubuntu VM. The problem already exists. I'll see what I can do about
that.
- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-07-12 10:20:49 ---
Ok thanks Raphael...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel