[Bug 276096] New: PGF images not shown if zoom is set to 100%

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #20 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-12 13:21:06 ---
Is it possible that the image out buffer (QImage) is somehow initialized to
0x04 (contrary to 0xFF)? In CPGFimage::GetBitmap I see that 'buff' consists of
0x04 values. Explicitly writing 255 to the (otherwise untouched by libPGF)
alpha channel has the desired effect of showing the image.

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #21 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-12 18:42:06 ---
Code excerpt:

            memset(data, sizeof(data), 0xFF);

            pgf.Read(level, CallbackForLibPGF, this);
            pgf.GetBitmap(m_sixteenBit ? width*8 : width*4,
                          (UINT8*)data,
                          m_sixteenBit ? 64 : 32,
                          NULL,
                          CallbackForLibPGF, this);

Hmmm...could it be that sizeof(data) is 4?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #22 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-12 22:33:38 ---
I thought the problem is with
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/abd03787b7b1e3a392803edc5b40dfb25a69423c/entry/libs/threadimageio/pgfutils.cpp#L80
with the uninitialized QImage buffer (I'm sure I saw a corresponding stacktrace
today).
But for pgfloader, should it not be memset(data, 0xFF,
width*height*(m_sixteenBit ? 8 : 4)) ?

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #23 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-12 22:41:26 ---
Created an attachment (id=61825)
 --> (http://bugs.kde.org/attachment.cgi?id=61825)
memset patch for missing alpha channel values

https://bugs.kde.org/show_bug.cgi?id=276096#c22

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #24 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-13 07:08:33 ---
> > memset(data, sizeof(data), 0xFF);
> But for pgfloader, should it not be memset(data, 0xFF,
> width*height*(m_sixteenBit ? 8 : 4)) ?

Here we have the 0x4:
We set the first 0xFF bytes to the value of sizeof(data), which is 4 ;-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-07-21 09:34:42 ---
Marcel, Raphael,

What's new in this file ? It can be closed for 2.0.0 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=276096





--- Comment #26 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-07-21 22:21:52 ---
No related changes in
https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/loaders/pgfloader.cpp
(maybe in another branch/revision?)
Problem identified, patch (https://bugs.kde.org/attachment.cgi?id=61825)
submitted. When applied everything should be fine.

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=276096


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #27 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-23 14:00:27 ---
Git commit a33630e56184ad1370f668d744c443a1f3d3ea80 by Marcel Wiesweg.
Committed on 23/07/2011 at 15:39.
Pushed by mwiesweg into branch 'master'.

Fix memset call (thanks to Raphael Schweizer)

BUG: 276096

M  +2    -1    NEWS
M  +1    -1    libs/dimg/loaders/pgfloader.cpp

http://commits.kde.org/digikam/a33630e56184ad1370f668d744c443a1f3d3ea80

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=276096

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel