[Bug 274555] New: Digikam crashes while browsing images downloaded from nokia N90

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|2.7.0                       |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #35 from Gilles Caulier <[hidden email]> ---
Git commit 04933fa86122db4e1cc20df15ea9c6250cb6325f by Gilles Caulier.
Committed on 01/10/2012 at 23:51.
Pushed by cgilles into branch 'master'.

use DImg image histogram constructor everywhere

M  +1    -2    libs/dimg/filters/auto/autolevelsfilter.cpp
M  +1    -2    libs/dimg/filters/auto/equalizefilter.cpp
M  +1    -2    libs/dimg/filters/auto/stretchfilter.cpp
M  +2    -1    libs/dimg/filters/curves/curveswidget.cpp
M  +3    -2    libs/dimg/filters/levels/histogramwidget.cpp
M  +0    -6    libs/dimg/filters/levels/imagehistogram.cpp
M  +0    -2    libs/dimg/filters/levels/imagehistogram.h
M  +3    -8    libs/dimg/filters/wb/wbfilter.cpp

http://commits.kde.org/digikam/04933fa86122db4e1cc20df15ea9c6250cb6325f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #36 from Gilles Caulier <[hidden email]> ---
Git commit 1a0bbc83b837d9a272842accea777b66227f7f89 by Gilles Caulier.
Committed on 02/10/2012 at 09:53.
Pushed by cgilles into branch 'master'.

store internal image data in DImg Container.

M  +27   -30   libs/dimg/filters/levels/imagehistogram.cpp
M  +1    -1    libs/dimg/filters/levels/imagehistogram.h

http://commits.kde.org/digikam/1a0bbc83b837d9a272842accea777b66227f7f89

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #37 from Gilles Caulier <[hidden email]> ---
Git commit 445c84557a943a281856cdf2451d7e4ddc78b9bf by Gilles Caulier.
Committed on 02/10/2012 at 12:59.
Pushed by cgilles into branch 'master'.

remove HistogramWidget constructor with image data argumets. Use updtaeData()
methods to pass image data.
Clenup and simplifcation of API

M  +5    -5    imageplugins/color/adjustlevelstool.cpp
M  +6    -5    imageplugins/color/filmtool.cpp
M  +0    -29   libs/dimg/filters/levels/histogramwidget.cpp
M  +1    -20   libs/dimg/filters/levels/histogramwidget.h

http://commits.kde.org/digikam/445c84557a943a281856cdf2451d7e4ddc78b9bf

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #38 from Gilles Caulier <[hidden email]> ---
Git commit ca4d5e3ed151ee0e0150732d0a046632b26449e6 by Gilles Caulier.
Committed on 02/10/2012 at 13:47.
Pushed by cgilles into branch 'master'.

remove all methods to update image data based on ucher pointers.
Used DImg container instead.
API polish and simplification.

M  +1    -17   imageplugins/color/adjustcurvestool.cpp
M  +2    -21   imageplugins/color/adjustlevelstool.cpp
M  +1    -17   imageplugins/color/autocorrectiontool.cpp
M  +1    -17   imageplugins/color/bcgtool.cpp
M  +1    -17   imageplugins/color/bwsepiatool.cpp
M  +1    -17   imageplugins/color/cbtool.cpp
M  +1    -17   imageplugins/color/channelmixertool.cpp
M  +2    -17   imageplugins/color/filmtool.cpp
M  +1    -17   imageplugins/color/hsltool.cpp
M  +1    -17   imageplugins/color/profileconversiontool.cpp
M  +3    -18   imageplugins/color/whitebalancetool.cpp
M  +3    -18   imageplugins/enhance/localcontrasttool.cpp
M  +1    -20   imageplugins/enhance/redeyetool.cpp
M  +2    -11   imageplugins/filters/colorfxtool.cpp
M  +1    -3    imageplugins/transform/ratiocroptool.cpp
M  +10   -14   libs/dimg/filters/levels/histogramwidget.cpp
M  +4    -6    libs/dimg/filters/levels/histogramwidget.h
M  +16   -32   libs/imageproperties/imagepropertiescolorstab.cpp
M  +1    -1    utilities/imageeditor/rawimport/rawsettingsbox.cpp
M  +1    -2    utilities/setup/setupeditor.cpp

http://commits.kde.org/digikam/ca4d5e3ed151ee0e0150732d0a046632b26449e6

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.7.0                       |3.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #39 from Gilles Caulier <[hidden email]> ---
Marcel,

I have been able to reproduce the crash in ImageHistogram with 3.0.0 in certain
conditions, when Color tab is visible from right sidebar tab...

I ported all code relevant of histogram management to DImg and removed all
methods and constructors using pointer to uchar data container. In all case
this is more safe and clean. Code sound better.

I'm sure that it's a race condition relevant of image data deleted during
histogram computation. using DImg will prevent this. Also, i'm not able to
reproduce the crash now, after few intensive race condition test in my fast
computer.

It still a point to clear before to close this file. Look here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/filters/levels/imagehistogram.cpp#L90

Do i need really to make a deep copy of image here ? Because it will mangle
more memory, and i'm not sure that it must necessary to prevent race condition
of image data deleted. Typically the DImg shared data reference mechanism  must
be safe and enough. Right ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #40 from Marcel Wiesweg <[hidden email]> ---
We are safe that the data will not be deleted (a reference is kept, and data is
deleted only when the last reference is dropped)
 But we should be aware of a difference: DImg is explicitly shared, in contrast
to implicitly shared classes like QString, QImage. That means a change to one
copy of an image does not detach this copy, instead, the change will affect all
shared instances.
So, if e.g. the image editor gives the DImg to the sidebar, and then the data
of the editor's main DImg is changed or resized, a shallow copy in the
histogram will be immediately affected. This can lead to crashes, or can be
safe, depending on the terms of use.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/37a1414726f92a3ef3b350a
                   |                            |7ff5a939c88d27307

--- Comment #41 from Gilles Caulier <[hidden email]> ---
Git commit 37a1414726f92a3ef3b350a7ff5a939c88d27307 by Gilles Caulier.
Committed on 03/10/2012 at 10:05.
Pushed by cgilles into branch 'master'.

make a simple copy of reference instead a deep copy. This must be enough and
optimum for memory allocation.
FIXED-IN: 3.0.0

M  +4    -1    libs/dimg/filters/levels/imagehistogram.cpp

http://commits.kde.org/digikam/37a1414726f92a3ef3b350a7ff5a939c88d27307

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #42 from Gilles Caulier <[hidden email]> ---
Git commit 50939b7dd0c6a02761792c6f7750adcb8f30d9d0 by Gilles Caulier.
Committed on 07/10/2012 at 07:23.
Pushed by cgilles into branch 'master'.

use DImg constructor instead pointer based image data arguments

M  +22   -20   libs/dimg/filters/bw/bwsepiasettings.cpp
M  +4    -4    libs/dimg/filters/bw/bwsepiasettings.h
M  +4    -4    libs/dimg/filters/curves/curvesbox.cpp
M  +2    -2    libs/dimg/filters/curves/curvesbox.h
M  +2    -2    libs/dimg/filters/curves/curvessettings.cpp
M  +3    -3    libs/dimg/filters/curves/curveswidget.cpp
M  +3    -5    libs/dimg/filters/curves/curveswidget.h
M  +1    -1    utilities/imageeditor/rawimport/rawimport.cpp
M  +1    -1    utilities/imageeditor/rawimport/rawsettingsbox.cpp

http://commits.kde.org/digikam/50939b7dd0c6a02761792c6f7750adcb8f30d9d0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #43 from Gilles Caulier <[hidden email]> ---
*** Bug 312048 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #44 from Gilles Caulier <[hidden email]> ---
*** Bug 314833 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=274555

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability

--
You are receiving this mail because:
You are the assignee for the bug.