[Bug 274555] New: Digikam crashes while browsing images downloaded from nokia N90

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2011-11-17 12:26:47 ---
*** Bug 286840 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-11-21 09:46:15 ---
Git commit fe3583f0a282f025cdda127405e6cfffb45fc28b by Gilles Caulier.
Committed on 21/11/2011 at 10:44.
Pushed by cgilles into branch 'master'.

add more histogram data null pointer checks to pevent chrash in suspected race
conditions.
CCBUGS: 274555

M  +20   -4    libs/dimg/filters/levels/histogramwidget.cpp

http://commits.kde.org/digikam/fe3583f0a282f025cdda127405e6cfffb45fc28b

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2011-11-21 09:57:33 ---
Hi all,

With #19, i consolidate ImageHistogram data pointer handling to prevent crash.

As i connot reproduce the crash on my computers, someone can try to see if
problem is reproducible with current implementation from git/master (next 2.4.0
release) ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #21 from Rudolf Leitgeb <Rudolf Leitgeb gmx at>  2011-11-21 10:18:12 ---
As described here:

    https://bugs.kde.org/show_bug.cgi?id=285849#c6


I instrumented the call which causes the NULL pointer dereference. And sure
enough, I finally triggered the crash. Here is my output:


Triggered histogram crash!
Dumping class state:
sixteenBits: 0
guideVisible: 0
statisticsVisible: 1
inSelected: 0
selectMode: 1
showProgress: 1
renderingType: 0
range: 255
state: 0
channelType: 0
scaleType: 1
imageHistogram: 0x0
selectionHistogram: 0x0
xmin: 0.000000
xminOrg: 0.000000
xmax: 0.000000
animationState: 0
animation: 0x36eb890
histogramPainter: 0x36ec610
arguments:
i_idata: 0x0, i_w: 0d, i_h: 0d
i_sixteenBits: 0
s_idata: 0x0, s_w: 0d, s_h: 0d
showProgress: 1

I will now apply the patch you posted and see whether it also fixes the
problem. You can still use my dump output to verify whether your patch would
address this state.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2011-11-22 13:30:30 ---
Rudolf,

My patch in git/master fix the problem for you ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #23 from Rudolf Leitgeb <Rudolf Leitgeb gmx at>  2011-11-22 13:53:00 ---
Your patch does the same as my instrumentation and I indeed had no crash
anymore with this change. I did spend some effort looking a little bit deeper
into the problem last night and think it has something to do with image crop
selection returning bad values, which leads to an illegal clip rectangle.

If the DImg::copy in imagepropertiescolorstab.cpp:541 is fed a bad rectangle,
an empty image is returned which ultimately produces exactly the numbers my
dump showed in Comment 21. And I strongly suspect that there is something
rotten in the state of ImagePropertiesSideBar::slotImageSelectionChanged or
rather the function triggering it, because for some reason I can never select
the whole image, there is always something cropped off the right and bottom
side. Press Ctrl+A and Ctrl+X often enough and the whole image disappears. I
know, I know, this should be a separate bug report ....

I will report my findings, for the time the patch is a quick fix for the
obvious symptom.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2011-11-22 13:58:35 ---
Thanks Rudolf for your investiguations...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #25 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-11-23 18:07:42 ---
If selection is stored in integers and the picture is zoomed, there can and
will be rounding errors, this may explain your latter observations.

Did you experience any other adverse effect when bad values come from somewhere
when the crop rectangle is moving?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2011-12-12 18:24:48 ---
*** Bug 288823 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #27 from Luis Alberto Arriola <laarriola yahoo com>  2012-01-11 16:04:24 ---
Created an attachment (id=67700)
 --> (http://bugs.kde.org/attachment.cgi?id=67700)
New crash information added by DrKonqi

digikam (2.1.1) on KDE Platform 4.7.4 (4.7.4) using Qt 4.7.4

- What I was doing when the application crashed:

Trying to apply color changes, whe clicked on color button, it just crashed.

-- Backtrace (Reduced):
#7  Digikam::ImageHistogram::calculate (this=0xaa988d8) at
/build/buildd/digikam-2.1.1/core/libs/dimg/filters/levels/imagehistogram.cpp:237
#8  0xb6928dcb in Digikam::ImageHistogram::run (this=0xaa988d8) at
/build/buildd/digikam-2.1.1/core/libs/dimg/filters/levels/imagehistogram.cpp:174
#9  0xb6a5a8ee in Digikam::DynamicThread::DynamicThreadPriv::run
(this=0xbb2b570) at
/build/buildd/digikam-2.1.1/core/libs/threads/dynamicthread.cpp:328
#10 0xb4b83651 in QThreadPoolThread::run (this=0xb37dcf0) at
concurrent/qthreadpool.cpp:106
#11 0xb4b8f7b3 in QThreadPrivate::start (arg=0xb37dcf0) at
thread/qthread_unix.cpp:331

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2012-01-11 16:55:34 ---
Luis,

I applied patch to consolidate code with 2.4.1. release, not 2.1.1. Please
update and try again.

Note that me and Marcel, we never reproduce the crash. So it's difficult to
hack...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #29 from Gilles Caulier <[hidden email]> ---
Official digiKam 2.6.0 release is out since few days now :

http://www.digikam.org/drupal/node/656

Please, check if this entry still valid, or update report accordingly.

Thanks in advance.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #30 from Rudolf Leitgeb <[hidden email]> ---
A number of updates have been made to Ubuntu in the meantime which made this
bug mysteriously disappear, with or without the patch. I have not been able to
reproduce the problem ever since. I'd recommend this bug gets closed until new
reports come in (unlikely IMHO).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #31 from Gilles Caulier <[hidden email]> ---
*** Bug 302678 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kaspar Schwarzenbach]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #32 from Kaspar Schwarzenbach <[hidden email]> ---
Created attachment 72987
  --> https://bugs.kde.org/attachment.cgi?id=72987&action=edit
New crash information added by DrKonqi

digikam (2.7.0) on KDE Platform 4.7.4 (4.7.4) using Qt 4.7.4

- What I was doing when the application crashed: I edited a .nef raw-picture
using the solarizing kipi plugin

-- Backtrace (Reduced):
#7  Digikam::ImageHistogram::calculate (this=0x970fb20) at
/build/buildd/digikam-2.7.0/core/libs/dimg/filters/levels/imagehistogram.cpp:218
#8  0x011a625b in Digikam::ImageHistogram::run (this=0x970fb20) at
/build/buildd/digikam-2.7.0/core/libs/dimg/filters/levels/imagehistogram.cpp:174
#9  0x012da19e in Digikam::DynamicThread::DynamicThreadPriv::run
(this=0xbb0fad8) at
/build/buildd/digikam-2.7.0/core/libs/threads/dynamicthread.cpp:186
#10 0x01567651 in QThreadPoolThread::run (this=0xabf4cc0) at
concurrent/qthreadpool.cpp:106
#11 0x015737b3 in QThreadPrivate::start (arg=0xabf4cc0) at
thread/qthread_unix.cpp:331

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

--- Comment #33 from Gilles Caulier <[hidden email]> ---
*** Bug 304673 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #34 from Gilles Caulier <[hidden email]> ---
*** Bug 301051 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
            Version|2.0.0                       |2.7.0
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel