[Bug 274029] New: Edit Metadata dialog doesn't honour settings for XMP sidecar

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 274029] New: Edit Metadata dialog doesn't honour settings for XMP sidecar

Bugzilla from dan@berrange.com
https://bugs.kde.org/show_bug.cgi?id=274029

           Summary: Edit Metadata dialog doesn't honour settings for XMP
                    sidecar
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: Metadata
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.3)
OS:                Linux

I am using digikam 2.0.0, beta5, compiled from source.

I have changed the default digikam settings to enable 'Read metadata from XML
sidecar files' and change 'Metadata writing mode' to 'Write to XMP sidecar
only'


From the main album view, if I now select an image and then use the menu 'Image
-> Metadata -> Edit Metadata', it does not populate the dialog with metadata
from any existing XMP sidecar file. If I make metadata changes and then apply
them, they are saved directly into the image file and no XMP sidecar is
created.

In essence, changes to the 'Read metadata from XMP sidecar' and 'Metadata
writing mode' settings have no effect on the metadata dialog at all.


Reproducible: Always

Steps to Reproduce:
1. Open menu 'Settings' -> 'Configure Digikam'
2. Select the 'Metadata' settings page
3. Enable 'Read metadata from XMP sidecar'
4. Change 'Metadata writing mode' to 'Write to XMP sidecar only'
5. Press OK to apply settings & close dialog
6. Select an image which has an XMP sidecar file with 'Headline' field set
7. Open menu 'Image -> Metadata -> Edit All Metadata'
8. Switch to 'Edit XMP' tab
8. Look at existing metadata that is loaded for 'Headline'
9. Make a change to the 'Headline'
10. Press 'Apply'


Actual Results:  
In step 8, the 'headline' field is not populated with data from the XMP
sidecar.
In step 10, the change is written directly into the JPG file, and the XMP
sidecar is unchanged. If there was no existing XMP sidecar in step 10, none is
created either.


Expected Results:  
In step 8, the 'headline' contains the data from the XMP sidecar

In step 10, an XMP sidecar file should be created, or the existing one updated.
No change must be made to the original JPG (as per 'Metadata writing mode'
setting changed made earlier)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274029] Edit Metadata dialog doesn't honour settings for XMP sidecar

Bugzilla from dan@berrange.com
https://bugs.kde.org/show_bug.cgi?id=274029





--- Comment #1 from Daniel Berrange <dan berrange com>  2011-05-24 15:05:12 ---
Created an attachment (id=60270)
 --> (http://bugs.kde.org/attachment.cgi?id=60270)
Fix kipi-plugins to load digikam settings before load/save of metadata via
KExiv2

Debugging the code revealed that the use of the KExiv2 class in
extra/kipi-plugins/metadataedit/ was incorrect. Some places did not apply any
of the Digikam settings for metadata usage, and others only applied the
WriteMetadataUpdateFiletimeStamp & WriteMetadataToRAW settings.

The usage pattern of KExiv2 seems rather error-prone, requiring every piece of
code to remember to manually load digikam metadata settings into the object
instance. I wasn't sure of the history and/plans for improving this, so rather
than re-factor it myself, I'm providing a minimal patch which simply follows
the current coding practice. Specifically the patch just updates all code in
extra/kipi-plugins/metadataedit/  to apply WriteMetadataToRAW,
MetadataWritingMode, UseXMPSidecar4Reading and
WriteMetadataUpdateFiletimeStamp.

In my testing, this makes the 'Edit All Metadata' dialog correctly handle XMP
sidecars as per digikam settings. Some of the kipi-plugins look like they might
also need work in this area though.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274029] Edit Metadata dialog doesn't honour settings for XMP sidecar

Gilles Caulier-4
In reply to this post by Bugzilla from dan@berrange.com
https://bugs.kde.org/show_bug.cgi?id=274029


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Metadata                    |MetadataEdit
            Product|digikam                     |kipiplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274029] Edit Metadata dialog doesn't honour settings for XMP sidecar

Gilles Caulier-4
In reply to this post by Bugzilla from dan@berrange.com
https://bugs.kde.org/show_bug.cgi?id=274029


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[hidden email]       |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 274029] Edit Metadata dialog doesn't honour settings for XMP sidecar [patch]

bugzilla_noreply
In reply to this post by Bugzilla from dan@berrange.com
https://bugs.kde.org/show_bug.cgi?id=274029

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel