[Bug 273765] New: replacing pgf files with an open digikam lead to reproducible crash

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #40 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-19 16:43:34 ---
Yes, I can fully reproduce. See these error messages on the console:
digikam(5323)/digikam (core) Digikam::readPGFImageData: Error running libpgf (
2 )!
digikam(5323)/digikam (core) Digikam::ThumbnailCreator::loadFromDatabase:
Cannot load PGF thumb from DB

This means the data is loaded from the db, but libpgf fails to load the data
with error code 2. Apparently this happens only with every second or third
image.
Backtrace of the thrown exception:

#0  0x00007fffef9d7d90 in __cxa_throw () from /usr/lib64/libstdc++.so.6
#1  0x00007ffff4aa9912 in CPGFMemoryStream::Read (this=0x7fffcbe98460,
count=0x7fffcbe97cfc, buffPtr=<value optimized out>)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/PGFstream.cpp:157
#2  0x00007ffff4aa06f3 in CDecoder::ReadMacroBlock (this=0x7fffd021d430,
block=0x7fffd0450370)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/Decoder.cpp:461
#3  0x00007ffff4aa14d0 in CDecoder::DecodeBuffer (this=0x7fffd021d430)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/Decoder.cpp:571
#4  0x00007ffff4aa169a in CDecoder::DequantizeValue (this=0x7fffd021d430,
band=<value optimized out>,
    bandPos=<value optimized out>, quantParam=<value optimized out>)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/Decoder.cpp:429
#5  0x00007ffff4aa1b87 in CDecoder::Partition (this=0x7fffd021d430,
band=0x7fffd056a7b8, quantParam=3, width=<value optimized out>,
    height=<value optimized out>, startPos=0, pitch=42)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/Decoder.cpp:249
#6  0x00007ffff4aaa1f6 in CSubband::PlaceTile (this=0x7fffd056a7b8,
decoder=..., quantParam=3, tile=false, tileX=0, tileY=0)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/Subband.cpp:230
#7  0x00007ffff4aa92b9 in CPGFImage::Read (this=0x7fffcbe97f30, level=0, cb=0,
data=0x0)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/3rdparty/libpgf/PGFimage.cpp:408
#8  0x00007ffff4aab93f in Digikam::readPGFImageData (data=<value optimized
out>, img=...)
    at
/home/marcel/freshmeat/multimedia/kde4/src/extragear/graphics/digikam/core/libs/threadimageio/pgfutils.cpp:71

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #41 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-19 16:50:20 ---
Created an attachment (id=61150)
 --> (http://bugs.kde.org/attachment.cgi?id=61150)
Thumbnail PGF data which throws exception

Sample thumbnail data (written to disk the first time an exception is caught at
startup from libpgf)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #42 from Gilles Caulier <caulier gilles gmail com>  2011-06-19 19:19:03 ---
Thanks Marcel,

Sound like something must be adapted in PGFUtils interface with libpgf API to
load RAW PGF image data from a bytearray take from thumbs database:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/threadimageio/pgfutils.cpp

Raphael, any sugestions ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #43 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 09:00:30 ---
Git commit e7e53a9c288b3b2aa83a3b7dd09c7a136f6253b1 by Gilles Caulier.
Committed on 20/06/2011 at 08:58.
Pushed by cgilles into branch 'master'.

Note : MSVC 2008 patched with SP1 work fine. MSVC 2008 official has a problem
with OpenMP.
CCBUGS: 273765

M  +1    -1    libs/3rdparty/libpgf/PGFplatform.h    

http://commits.kde.org/digikam/e7e53a9c288b3b2aa83a3b7dd09c7a136f6253b1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #44 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 12:12:00 ---
Git commit cb9435fae37f32553e8e354705e9abfe77783dad by Gilles Caulier.
Committed on 20/06/2011 at 12:10.
Pushed by cgilles into branch 'master'.

fix argment call for PGFImage::write method, which have changed with libpgf
6.11.24
CCBUGS: 273765

M  +1    -1    libs/threadimageio/pgfutils.cpp    

http://commits.kde.org/digikam/cb9435fae37f32553e8e354705e9abfe77783dad

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #45 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 13:06:12 ---
Marcel, Raphael

I hacked a lot digiKam PGF Utils interface and found a bug in lipgf API call
arguments (in fact, an evolution of API to update in digiKam core).

I tested with pgf test program from digiKam, and encoding and decoding PGF work
fine.

BUT, the problem still here about thumb database. I set a debug print to see if
PGF data taken from thumb db are not null. It's not the case :

digikam(11244)/digikam (core) Digikam::readPGFImageData: image data stream size
is :  8722
digikam(11244)/digikam (core) Digikam::readPGFImageData: Error running libpgf (
2 )!
digikam(11244)/digikam (core) Digikam::ThumbnailCreator::loadFromDatabase:
Cannot load PGF thumb from DB
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Preview data
size: 345669
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Using embedded
RAW preview extraction
digikam(11244)/digikam (core) Digikam::DMetadata::getIccProfile: Exif
color-space tag is sRGB. Using default sRGB ICC profile.
digikam(11244)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1
digikam(11244)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1
digikam(11244)/digikam (core) Digikam::readPGFImageData: image data stream size
is :  8002
digikam(11244)/digikam (core) Digikam::readPGFImageData: Error running libpgf (
2 )!
digikam(11244)/digikam (core) Digikam::ThumbnailCreator::loadFromDatabase:
Cannot load PGF thumb from DB
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Preview data
size: 101661
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Using embedded
RAW preview extraction
digikam(11244)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1
digikam(11244)/digikam (core) Digikam::readPGFImageData: image data stream size
is :  8814
digikam(11244)/digikam (core) Digikam::readPGFImageData: Error running libpgf (
2 )!
digikam(11244)/digikam (core) Digikam::ThumbnailCreator::loadFromDatabase:
Cannot load PGF thumb from DB
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Preview data
size: 331522
digikam(11244)/KDCRAW KDcrawIface::KDcraw::loadEmbeddedPreview: Using embedded
RAW preview extraction
digikam(11244)/kio (KIOConnection) KIO::ConnectionServer::listenForRemote:
digikam(11244)/digikam (core) Digikam::DMetadata::getIccProfile: Exif
color-space tag is sRGB. Using default sRGB ICC profile.
digikam(11244)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation =>
Exif.Image.Orientation =>  1
digikam(11244)/digikam (core) Digikam::readPGFImageData: image data stream size
is :  10966
digikam(11244)/digikam (core) Digikam::readPGFImageData: Error running libpgf (
2 )!
digikam(11244)/digikam (core) Digikam::ThumbnailCreator::loadFromDatabase:
Cannot load PGF thumb from DB

Thumbs size are around 8/10Kb (256x256 pixels). So it sound fine.

The exception generated by libPGF appear when image data taken from DB is
passed to CPGFImage::Open() as a memory stream :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/threadimageio/pgfutils.cpp#L67

What's error #2 given by libPGF ?

Note : in my pgf test code, i use this method, and all work fine ! PGF image
data are taken from a file, not DB of course.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #46 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 13:45:49 ---
Sorry,

The exception is not generated by libpgf to CPGFImage::Open(), by to
CPGFImage::Read() :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/threadimageio/pgfutils.cpp#L76

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #47 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 14:08:17 ---
Marcel,

Your PGF thumb from #41 work fine here. I wan load it into showfoto and
pgfscaled test program do not report an error.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #48 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 14:32:14 ---
Git commit 3382b0cb2901b599b8e593c9cc07353cea045ee6 by Gilles Caulier.
Committed on 20/06/2011 at 14:30.
Pushed by cgilles into branch 'master'.

new test program to load PGF data from image file and convert it to QImg using
PGFUtils::readPGFImageData()
CCBUGS: 273765

M  +3    -0    tests/CMakeLists.txt    
A  +76   -0    tests/loadpgfdata.cpp         [License: GPL (v2+)]

http://commits.kde.org/digikam/3382b0cb2901b599b8e593c9cc07353cea045ee6

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #49 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 14:35:13 ---
Marcel, with your PGF thumb image data, i can also pass loadpgfdata test
program... How do you explain that ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #50 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 14:49:40 ---
Ok, i find the problem, but not the real solution.

I disable OpenMp support to libpgf, and now, it work fine. Thumbnails can be
loaded from database and decoded through libpgf without an error.

As thumbnail process run into a separated thread, using QThread, i suspect a
problem here.

The fact that loadpgdfdata work as well is simple : i do not run in a separate
thead, but in main thread, as it's a single a small test application.

Raphael,

Do you have tested into libpgf test collection tools a case where libpgf is
used through a separated thread, as Posix thread ?

Note that Windows thread as the same problem. It's not Unix thread in this
case...


Marcel,

Another question : image editor use a separated thread to load PGF image. Why
it work fine in this case, if libpgf is compiled with OpenMP support ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #51 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-06-20 15:11:49 ---
AFAIK there were no such tests. Unfortunately I still have no access to our
source server (it went down shortly after some migration, no words from IT
yet). I'm currently at home - preparing for next week's exams - and ha

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #52 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-06-20 15:20:47 ---
AFAIK there were no explicit tests (a background thread is used by the
ImageViewer [http://xeraina.ch/pgf/pgfdownload.html] to load the images, no
problems there). Unfortunately I still have no access to our source server (it
went down shortly after some migration, no words from IT yet). I'm currently at
home - preparing for next two week's exams - and have no access to our test
system nor the latest source.
I really appreciate the work you have done so far. Is it feasible to disable
OpenMP for the time being and suspend development till start of July?

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #53 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 15:25:55 ---
Raphael,

Trying to find a solution to OpenMP support in libpgf, is tried to turn off
OpenMP with PGF encoder/decoder in digiKam PGFUtils methods relevant of thumbs
database.

libPGF still compiled with OpenMP support. digiKam crash into libpgf :

Thread 2 (Thread 0xa8c3ab70 (LWP 7763)):
[KCrash Handler]
#6  0xb67ede11 in CDecoder::DecodeBuffer (this=0xa746628) at
/mnt/data/Devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:571
#7  0xb67ed900 in CDecoder::DequantizeValue (this=0xa746628, band=0xa732f2c,
bandPos=0, quantParam=0) at
/mnt/data/Devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:429
#8  0xb67ed187 in CDecoder::Partition (this=0xa746628, band=0xa732f2c,
quantParam=0, width=64, height=43, startPos=0, pitch=64) at
/mnt/data/Devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:249
#9  0xb67f9fe7 in CSubband::PlaceTile (this=0xa732f2c, decoder=...,
quantParam=0, tile=false, tileX=0, tileY=0) at
/mnt/data/Devel/GIT/2.x/core/libs/3rdparty/libpgf/Subband.cpp:230
#10 0xb67f19b9 in CPGFImage::Read (this=0xa8c398d0, level=0, cb=0, data=0x0) at
/mnt/data/Devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.cpp:398
#11 0xb67fc342 in Digikam::readPGFImageData (data=..., img=...) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/pgfutils.cpp:78
#12 0xb67ddbfd in Digikam::ThumbnailCreator::loadFromDatabase (this=0xa3a8f00,
info=...) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/thumbnailcreator.cpp:884
#13 0xb67da8fc in Digikam::ThumbnailCreator::load (this=0xa3a8f00, path=...,
rect=..., pregenerate=false) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/thumbnailcreator.cpp:245
#14 0xb67da599 in Digikam::ThumbnailCreator::load (this=0xa3a8f00, path=...) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/thumbnailcreator.cpp:196
#15 0xb67e8181 in Digikam::ThumbnailLoadingTask::execute (this=0xa733768) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/thumbnailtask.cpp:169
#16 0xb67c574a in Digikam::LoadSaveThread::run (this=0xa3841f8) at
/mnt/data/Devel/GIT/2.x/core/libs/threadimageio/loadsavethread.cpp:118
#17 0xb68024ca in Digikam::DynamicThread::DynamicThreadPriv::run
(this=0xa3a71a8) at
/mnt/data/Devel/GIT/2.x/core/libs/threads/dynamicthread.cpp:328
#18 0xb48fa9d6 in ?? () from /usr/lib/libQtCore.so.4
#19 0xb490555f in ?? () from /usr/lib/libQtCore.so.4
#20 0xb4892ae5 in start_thread () from /lib/i686/libpthread.so.0
#21 0xb466203e in clone () from /lib/i686/libc.so.6

Why ???

So, my only solution is to temporally disable OpenMP support with libpgf to be
able to run properly digiKam.

I recommend to improve better OpenMP support in libpgf. I will write some code
to be able to force compilation of libpgf without OpenMP, in case of OpenMP is
detected on target computer. I recommend to backport my patch to current
implementation of libpgf

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #54 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 15:33:53 ---
Git commit 4ca8c22c4368306457aed9d62bbf48f7436553da by Gilles Caulier.
Committed on 20/06/2011 at 15:32.
Pushed by cgilles into branch 'master'.

add a flag to compile libpgf without openmp support at compilation time.
Raphael, please add this patch to current libpgf implementation
CCMAIL: [hidden email]
CCBUGS: 273765

M  +10   -4    libs/3rdparty/libpgf/PGFplatform.h    

http://commits.kde.org/digikam/4ca8c22c4368306457aed9d62bbf48f7436553da

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #55 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 15:52:26 ---
Git commit 6349f79b8a059034bfe218f51ef26e46581a64d4 by Gilles Caulier.
Committed on 20/06/2011 at 15:51.
Pushed by cgilles into branch 'master'.

disable openmp support to libpgf
CCBUGS: 273765

M  +4    -0    CMakeLists.txt    

http://commits.kde.org/digikam/6349f79b8a059034bfe218f51ef26e46581a64d4

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #56 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 17:50:37 ---
Francesco,

Lets' me hear if this file can be closed now...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=273765


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #57 from Francesco Riosa <francesco+kde pnpitalia it>  2011-06-20 20:58:35 ---
yes it is, liked very much the collaborative work on this one, congratz

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #58 from Gilles Caulier <caulier gilles gmail com>  2011-06-21 09:57:39 ---
Git commit 22018b3ec500ee76178d486456598f511eb74455 by Gilles Caulier.
Committed on 21/06/2011 at 09:53.
Pushed by cgilles into branch 'master'.

Add a PGF codec version ID to be able to make rules with clien application
accodingly with libpgf API changes.
Raphael, it's not possible to do it with PGFCodecVersion string and
preprocessor. Of course both must be updated at each libpgf version.
We use already this way in libraw and libexiv2.
CCMAIL: [hidden email]
CCBUGS: 273765

M  +2    -0    libs/3rdparty/libpgf/PGFtypes.h    

http://commits.kde.org/digikam/22018b3ec500ee76178d486456598f511eb74455

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #59 from Gilles Caulier <caulier gilles gmail com>  2011-06-22 08:23:55 ---
Git commit 67029dd34cc4314885db49258b948de4c77d7d58 by Gilles Caulier.
Committed on 22/06/2011 at 08:22.
Pushed by cgilles into branch 'master'.

fix MSVC warnings
CCBUGS: 273765
CCMAIL: [hidden email]

M  +2    -2    libs/3rdparty/libpgf/PGFplatform.h    

http://commits.kde.org/digikam/67029dd34cc4314885db49258b948de4c77d7d58

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel