[Bug 273765] New: replacing pgf files with an open digikam lead to reproducible crash

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #20 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-06-16 17:02:28 ---
New version out now: including
- fixed crashes
- deterministic encoder
- OpenMP support

We are looking forward to your test result.

- Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2011-06-16 19:53:21 ---
Raphael,

I patched digiKam with your last libpgf tarball...

There is a problem with OpenMP dependency : it's not optional. It must be.

Un MACOSX, GCC do not support OpenMP very well, especially when parallelized
code run into separated thread. We have already see very weird side-effect with
libraw under Mac.

I think it can be easily patched. I see in your code that you include hard
omp.h. It must be wrapped in prepocessor like this :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkdcraw/repository/revisions/master/entry/libraw/libraw/libraw_types.h#L32

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2011-06-17 08:57:26 ---
Git commit 46c8af586c53127ea48eebad23ff5968bcd9aa5c by Gilles Caulier.
Committed on 17/06/2011 at 08:55.
Pushed by cgilles into branch 'master'.

update libpgf from digiKam core to last 6.11.24 including OpenMP support
CCBUGS: 273765

M  +22   -1    CMakeLists.txt    
M  +1    -0    NEWS    
M  +3    -0    digikam/CMakeLists.txt    
M  +56   -53   libs/3rdparty/libpgf/BitStream.h    
M  +458  -272  libs/3rdparty/libpgf/Decoder.cpp    
M  +62   -35   libs/3rdparty/libpgf/Decoder.h    
M  +358  -307  libs/3rdparty/libpgf/Encoder.cpp    
M  +96   -36   libs/3rdparty/libpgf/Encoder.h    
M  +703  -483  libs/3rdparty/libpgf/PGFimage.cpp    
M  +114  -58   libs/3rdparty/libpgf/PGFimage.h    
M  +70   -61   libs/3rdparty/libpgf/PGFplatform.h    
A  +272  -0    libs/3rdparty/libpgf/PGFstream.cpp         [License: BSD]  *
A  +185  -0    libs/3rdparty/libpgf/PGFstream.h         [License: BSD]  *
M  +35   -21   libs/3rdparty/libpgf/PGFtypes.h    
D  +0    -254  libs/3rdparty/libpgf/Stream.cpp    
D  +0    -169  libs/3rdparty/libpgf/Stream.h    
M  +16   -13   libs/3rdparty/libpgf/Subband.cpp    
M  +14   -9    libs/3rdparty/libpgf/Subband.h    
M  +55   -48   libs/3rdparty/libpgf/WaveletTransform.cpp    
M  +17   -10   libs/3rdparty/libpgf/WaveletTransform.h    

The files marked with a * at the end have a non valid license. Please read:
http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are
listed at that page.


http://commits.kde.org/digikam/46c8af586c53127ea48eebad23ff5968bcd9aa5c

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2011-06-17 09:16:55 ---
Git commit 781571dd5b72d50d3e26e70bd4023938f20df94a by Gilles Caulier.
Committed on 17/06/2011 at 09:14.
Pushed by cgilles into branch 'master'.

patch against original libpgf 6.11.24 to :
- Handle properly OpenMP depending of compiler/OS (inspired from libraw.org).
- Include only one omp.h instance in PGFplatform.h
- Support no OpenMP availability (else libpgf do not compile without OpenMP).
This patch must be included in next stable libpgf.

Raphael, i recommend too to change EOL as Unix like and to replace tab by 4
spaces.

CCBUGS: 273765
CCMAIL: [hidden email]

M  +3    -1    libs/3rdparty/libpgf/Decoder.cpp    
M  +3    -1    libs/3rdparty/libpgf/Encoder.cpp    
M  +25   -0    libs/3rdparty/libpgf/PGFplatform.h    

http://commits.kde.org/digikam/781571dd5b72d50d3e26e70bd4023938f20df94a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2011-06-17 09:21:40 ---
Raphael,

digiKam with new libpgf 6.11.24 compile fine under Linux with or without OpenMP
with my personnal patch from #23. Please include it to your official
repository.

digiKam run and do not crash under my Linux Mandriva  (thumbnails generation
and file save as/load PGF in image editor)

I will check if all compile and run fine under MACosX and Windows (using MSVC
compiler)

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-06-17 17:38:03 ---
Raphael,

digiKam with new libpgf 6.11.24 compile fine under MacOSX. Note that OpenMP
support is disabled, as for libraw, to prevent crash when parallelized code run
in a separated thread (current limitation of OpenMp support under MacOSX).

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2011-06-18 09:54:56 ---
Git commit dbb1f15dbe0998b9cc806ef32f7c15afbde1614c by Gilles Caulier.
Committed on 18/06/2011 at 09:50.
Pushed by cgilles into branch 'master'.

Another patch about OpenMp support for libpgf :

- M$ Visual C++ 2008 support well OpenMP. Do not limit OpenMP support to Visual
C++ 2010.
- use dedicated OpenMP detection define everywhere if OpenMP will be used with
libpgf implementation.

Raphael, now, digiKam+libpgf compile fine with M$ Visual C++. Please include
this patch into official and current libpgf repository. Thanks in advance.

CCBUGS: 273765
CCMAIL: [hidden email]

M  +2    -2    libs/3rdparty/libpgf/Decoder.cpp    
M  +2    -2    libs/3rdparty/libpgf/Encoder.cpp    
M  +2    -2    libs/3rdparty/libpgf/PGFplatform.h    

http://commits.kde.org/digikam/dbb1f15dbe0998b9cc806ef32f7c15afbde1614c

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #27 from Gilles Caulier <caulier gilles gmail com>  2011-06-18 10:39:21 ---
To all in this room.

digiKam from git master include now the new libpgf library + few patches for
OpenMP support. Please checkout last digiKam code and try again to see if crash
is reproducible.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #28 from Francesco Riosa <francesco+kde pnpitalia it>  2011-06-18 16:48:05 ---
(In reply to comment #27)
> To all in this room.
>
> digiKam from git master include now the new libpgf library + few patches for
> OpenMP support. Please checkout last digiKam code and try again to see if crash
> is reproducible.
>
> Thanks in advance
>
> Gilles Caulier

_dsc4243.pgf does not crash showfoto any more, thanks to everybody involved

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #29 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-18 16:52:05 ---
The two pgf examples (in tests/) do not link anymore. Any change in symbol
visibility?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #30 from Gilles Caulier <caulier gilles gmail com>  2011-06-18 17:28:04 ---
Marcel,

I don't change visibility. I don't check test source code compilation too. I
will take a look.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2011-06-18 17:37:36 ---
Marcel,

Since libpgf have been updated into digiKam, under windows, thumbnails database
do not sound to work as espected. There is no thumbnails cache effects visible
between 2 digiKam sessions.

Can you confirm this problem under Linux ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #32 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2011-06-18 18:41:32 ---
Thanks for all the testing and the patches. I'm pleasantly surprised of your
fast pace. Our source server is currently down, I'll apply patches and update
sourceforge as soon as I get access again.

Thanks, Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2011-06-18 20:02:02 ---
Raphael,

use test compilation mode from KDE sdk, more GCC warnings options are turned
on. I can see this :

[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/Decoder.cpp.o
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:29:              
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h: In constructor
‘CDecoder::CMacroBlock::CMacroBlock(CDecoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:74: attention :
‘CDecoder::CMacroBlock::m_decoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:62: attention :  
‘ROIBlockHeader CDecoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:52: attention :  
when initialized here
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h: In constructor
‘CDecoder::CDecoder(CPGFStream*, PGFPreHeader&, PGFHeader&, PGFPostHeader&,
UINT32*&, bool)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:180: attention :
‘CDecoder::m_encodedHeaderLength’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:179: attention :  
‘UINT64 CDecoder::m_streamSizeEstimation’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:65: attention :  
when initialized here
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:185: attention :
‘CDecoder::m_macroBlocksAvailable’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:183: attention :  
‘int CDecoder::m_currentBlockIndex’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.cpp:65: attention :  
when initialized here
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/Encoder.cpp.o
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.cpp:29:              
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h: In constructor
‘CEncoder::CMacroBlock::CMacroBlock(CEncoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:82: attention :
‘CEncoder::CMacroBlock::m_encoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:63: attention :  
‘ROIBlockHeader CEncoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:52: attention :  
when initialized here
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h: In constructor
‘CEncoder::CEncoder(CPGFStream*, PGFPreHeader, PGFHeader, const PGFPostHeader&,
UINT32*&, bool)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:188: attention :
‘CEncoder::m_forceWriting’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:186: attention :  
‘UINT8 CEncoder::m_nLevels’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.cpp:67: attention :  
when initialized here
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/PGFimage.cpp.o
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.cpp:30:              
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h: In constructor
‘CDecoder::CMacroBlock::CMacroBlock(CDecoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:74: attention :
‘CDecoder::CMacroBlock::m_decoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:62: attention :  
‘ROIBlockHeader CDecoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:52: attention :  
when initialized here
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.cpp:31:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h: In constructor
‘CEncoder::CMacroBlock::CMacroBlock(CEncoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:82: attention :
‘CEncoder::CMacroBlock::m_encoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:63: attention :  
‘ROIBlockHeader CEncoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:52: attention :  
when initialized here
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.h: In constructor
‘CPGFImage::CPGFImage()’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.h:509: attention :
‘CPGFImage::m_cbArg’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.h:502: attention :  
‘bool CPGFImage::m_levelwise’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/PGFimage.cpp:56: attention :
 when initialized here
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/PGFstream.cpp.o
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/Subband.cpp.o
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Subband.cpp:30:              
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h: In constructor
‘CEncoder::CMacroBlock::CMacroBlock(CEncoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:82: attention :
‘CEncoder::CMacroBlock::m_encoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:63: attention :  
‘ROIBlockHeader CEncoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Encoder.h:52: attention :  
when initialized here
In file included from
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Subband.cpp:31:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h: In constructor
‘CDecoder::CMacroBlock::CMacroBlock(CDecoder*)’:
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:74: attention :
‘CDecoder::CMacroBlock::m_decoder’ will be initialized after
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:62: attention :  
‘ROIBlockHeader CDecoder::CMacroBlock::m_header’
/mnt/data/devel/GIT/2.x/core/libs/3rdparty/libpgf/Decoder.h:52: attention :  
when initialized here
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/3rdparty/libpgf/WaveletTransform.cpp.o
[ 55%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/threadimageio/pgfutils.cpp.o
Linking CXX shared library ../../lib/libdigikamdatabase.so                      

I will fix it tomorow...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #34 from Gilles Caulier <caulier gilles gmail com>  2011-06-19 01:05:17 ---
To Marcel, #29

All digiKam tests compile fine here :

[ 98%] Built target advancedrenametest_automoc
Linking CXX executable advancedrenametest
[ 98%] Built target advancedrenametest
[ 98%] Built target cameranamehelpertest_automoc
Linking CXX executable cameranamehelpertest
[ 98%] Built target cameranamehelpertest
[ 98%] Built target dimagefilteractiontest_automoc
Linking CXX executable dimagefilteractiontest
[ 98%] Built target dimagefilteractiontest
[ 98%] Built target dimagehistorygraphtest_automoc
Scanning dependencies of target dimagehistorygraphtest
[ 98%] Building CXX object
core/tests/CMakeFiles/dimagehistorygraphtest.dir/dimagehistorygraphtest_automoc.cpp.o
Linking CXX executable dimagehistorygraphtest
[ 98%] Built target dimagehistorygraphtest
[ 98%] Built target dimagehistorytest_automoc
Linking CXX executable dimagehistorytest
[ 98%] Built target dimagehistorytest
[ 98%] Built target filesaveoptionsboxtest_automoc
Linking CXX executable filesaveoptionsboxtest
[ 98%] Built target filesaveoptionsboxtest
[ 98%] Built target freerotationtest_automoc
Linking CXX executable freerotationtest
[ 98%] Built target freerotationtest
[ 98%] Built target pgfscaled_automoc
Scanning dependencies of target pgfscaled
[ 98%] Building CXX object
core/tests/CMakeFiles/pgfscaled.dir/__/libs/3rdparty/libpgf/Decoder.cpp.o
Linking CXX executable pgfscaled
[100%] Built target pgfscaled
[100%] Built target qtpgftest_automoc
Scanning dependencies of target qtpgftest
[100%] Building CXX object
core/tests/CMakeFiles/qtpgftest.dir/__/libs/3rdparty/libpgf/Decoder.cpp.o
Linking CXX executable qtpgftest
[100%] Built target qtpgftest
[100%] Built target searchtextbartest_automoc
Linking CXX executable searchtextbartest
[100%] Built target searchtextbartest
[100%] Built target statesavingobjecttest_automoc
Linking CXX executable statesavingobjecttest
[100%] Built target statesavingobjecttest
Scanning dependencies of target uifilevalidatortest_automoc
Generating uifilevalidatortest.moc
[100%] Built target uifilevalidatortest_automoc
Scanning dependencies of target uifilevalidatortest
[100%] Building CXX object
core/tests/CMakeFiles/uifilevalidatortest.dir/uifilevalidatortest_automoc.cpp.o
[100%] Building CXX object
core/tests/CMakeFiles/uifilevalidatortest.dir/uifilevalidatortest.cpp.o
Linking CXX executable uifilevalidatortest
[100%] Built target uifilevalidatortest

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #35 from Gilles Caulier <caulier gilles gmail com>  2011-06-19 01:22:58 ---
Git commit cf8cdc2cd50a63f6aa6d81c327005ed4faf37592 by Gilles Caulier.
Committed on 19/06/2011 at 01:20.
Pushed by cgilles into branch 'master'.

fix gcc warnings about order of classes member initialization
Raphael, please include this patch to official libpgf repository. Thanks in
advance
CCBUGS: 273765
CCMAIL: [hidden email]

M  +2    -2    libs/3rdparty/libpgf/Decoder.cpp    
M  +3    -3    libs/3rdparty/libpgf/Decoder.h    
M  +1    -1    libs/3rdparty/libpgf/Encoder.cpp    
M  +2    -2    libs/3rdparty/libpgf/Encoder.h    
M  +2    -2    libs/3rdparty/libpgf/PGFimage.cpp    

http://commits.kde.org/digikam/cf8cdc2cd50a63f6aa6d81c327005ed4faf37592

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #36 from Gilles Caulier <caulier gilles gmail com>  2011-06-19 01:30:43 ---
Marcel,

As in #31, i can reproduce the thumbnail cache problem under Linux, as under
Windows.

there is something to patch in thumbnail management Database code about PGF
image data handling. Thumbs are displayed very slowly. Sound like all thumb
from an album are recompute between each digiKam session.

Of course, if you change current album in same digiKam session, thumbs cache
from memory work fine.

Can you reproduce the problem ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #37 from Gilles Caulier <caulier gilles gmail com>  2011-06-19 10:33:44 ---
Marcel,

Under Linux, I removed all DB file, restarted digiKam, and rebuild all
thumbnails. Problem still here. Icon view is very slow in all case to display
thumbs.

Can you reproduce ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #38 from S. Burmeister <sven burmeister gmx net>  2011-06-19 12:13:52 ---
I see it as well, not only with PGFs.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=273765





--- Comment #39 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-19 16:33:11 ---
Git commit bf9645f52d22ba43b7b5bc58b73f915ecd713df4 by Marcel Wiesweg.
Committed on 19/06/2011 at 15:46.
Pushed by mwiesweg into branch 'master'.

Fix linking of libpgf tests
CCBUG: 273765

M  +2    -2    tests/CMakeLists.txt    

http://commits.kde.org/digikam/bf9645f52d22ba43b7b5bc58b73f915ecd713df4

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel