[Bug 273369] New: digikam does not get UUID for disk devices inside LVM

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] New: digikam does not get UUID for disk devices inside LVM

Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369

           Summary: digikam does not get UUID for disk devices inside LVM
           Product: digikam
           Version: 1.9.0
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.9.0 (using KDE 4.6.2)
OS:                Linux

When adding an album on devices inside a LVM, digikam complains that it is not
able to identify the storage medium of the path. The album is then identify
only by its path which poses other problems if the device is LUKS and one
starts digikam without unlocking the LUKS device (see #271591 for more
details).

Reproducible: Always

Steps to Reproduce:
Add an album on a device inside an LVM

Actual Results:  
digikam is unable to identify the storage medium of the path

Expected Results:  
digikam should be able to identify the storage medium of the path

I understand that digikam relies on solid-hardware to find out the storage
devices.

Below is the solid-hardware output for one of a LUKS disks stored in a LVM for
which digikam fails:

udi = '/org/freedesktop/UDisks/devices/dm_2d7'
  parent = '/org/freedesktop/UDisks/devices/dm_2d2'  (string)
  vendor = ''  (string)
  product = 'luks'  (string)
  description = 'luks'  (string)
  Block.major = 253  (0xfd)  (int)
  Block.minor = 7  (0x7)  (int)
  Block.device = '/dev/dm-7'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home/luks'  (string)
  StorageAccess.ignored = true  (bool)
  StorageVolume.ignored = true  (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'ext4'  (string)
  StorageVolume.label = 'luks'  (string)
  StorageVolume.uuid = '13ea945a-ef5b-4db7-9fc6-34e1bd00df96'  (string)
  StorageVolume.size = 450102292480  (0x68cc2ff000)  (qulonglong)


Below is the solid-hardware output for one of a non-encrypted disks stored in a
LVM for which digikam fails:

udi = '/org/freedesktop/UDisks/devices/dm_2d1'
  parent = '/org/freedesktop/UDisks'  (string)
  vendor = ''  (string)
  product = 'homes'  (string)
  description = 'homes'  (string)
  Block.major = 253  (0xfd)  (int)
  Block.minor = 1  (0x1)  (int)
  Block.device = '/dev/dm-1'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home'  (string)
  StorageAccess.ignored = true  (bool)
  StorageVolume.ignored = true  (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'ext4'  (string)
  StorageVolume.label = 'homes'  (string)
  StorageVolume.uuid = '92903620-f0f3-4f5a-bce2-7fb6de0650f7'  (string)
  StorageVolume.size = 93415538688  (0x15c0000000)  (qulonglong)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] digikam does not get UUID for disk devices inside LVM

Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369





--- Comment #1 from Matthieu Pupat <kde pupat-ghestem net>  2011-05-16 03:05:21 ---
Created an attachment (id=60046)
 --> (http://bugs.kde.org/attachment.cgi?id=60046)
patch

the problems comes from drives under LVM not being Drives and having UDisks as
parent which mean they do not belong to a drive either.

I do not know if it is an issue with solid-hardware or if this is digikam
assuming something it should not (i.e. each volume will have a drive as aparent
at some point).

Attached is a patch that fixes the issue in 1.9.0 and works fine for me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Bugzilla from kde@pupat-ghestem.net
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369


Matthieu Pupat <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digikam does not get UUID   |[PATCH] digikam does not
                   |for disk devices inside LVM |get UUID for disk devices
                   |                            |inside LVM




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Gilles Caulier-4
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Database
            Version|1.9.0                       |2.0.0




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-05-16 08:35:07 ---
Thanks Matthieu for your patch. It can be applied to 2.0.0 as well, but need
some tune i think.

Marcel ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Gilles Caulier-4
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |271591




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Marcel Wiesweg
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-05-17 21:46:57 ---
Git commit f55e24a8fbd519cfffa6509abc1ef3f109559f94 by Marcel Wiesweg.
Committed on 17/05/2011 at 21:45.
Pushed by mwiesweg into branch 'master'.

Apply patch by Matthieu Pupat.
We strictly need the drive device only to find out if it is
removable/hotpluggable,
and I see the point that logical volumes may not have a clear parent.

BUG: 273369

M  +2    -1    NEWS    
M  +13   -1    libs/database/collectionmanager.cpp    

http://commits.kde.org/digikam/f55e24a8fbd519cfffa6509abc1ef3f109559f94

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Marcel Wiesweg
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-05-23 21:20:53 ---
*** Bug 271591 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

Gilles Caulier-4
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 273369] [PATCH] digikam does not get UUID for disk devices inside LVM

bugzilla_noreply
In reply to this post by Bugzilla from kde@pupat-ghestem.net
https://bugs.kde.org/show_bug.cgi?id=273369

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database                    |Database-Media

--
You are receiving this mail because:
You are the assignee for the bug.