[Bug 269511] New: cmake install files include wrong path for libmediawiki/version.h

https://bugs.kde.org/show_bug.cgi?id=269511

           Summary: cmake install files include wrong path for
                    libmediawiki/version.h
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.5.1)
OS:                Linux

when building from the git repos the file

$BULID_DIR/extra/libmediawiki/libmediawiki/cmake_install.cmake

has an error in where to find version.h on line 90 in the files list it has:
"$SRC_DIR/extra/libmediawiki/libmediawiki/version.h"
It should have:
"$BUILD_DIR/extra/libmediawiki/libmediawiki/version.h"

changing this by hand allows digikam to install

My understanding is this is a generated file, but I do not know cmake well
enough to figure out where it is being generated.

Reproducible: Always

Steps to Reproduce:
check out a clean copy from git, build and install

Actual Results:  
reports an error during install that version.h does not exist

Expected Results:  
successfully install

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-03-27 10:23:12 ---
Git commit 985dcf72dc3545d647124139140f4465a28d8552 by Gilles Caulier.
Committed on 27/03/2011 at 10:25.
Pushed by cgilles into branch 'master'.

use bin dir to install hearder files
BUGS: 269511

M  +22   -22   libmediawiki/CMakeLists.txt    

http://commits.kde.org/libmediawiki/985dcf72dc3545d647124139140f4465a28d8552

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #2 from Thomas Caswell <tcaswell gmail com>  2011-03-28 01:23:15 ---
Created an attachment (id=58385)
 --> (http://bugs.kde.org/attachment.cgi?id=58385)
tweaks CMakeLists.txt

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #3 from Thomas Caswell <tcaswell gmail com>  2011-03-28 01:24:13 ---
This change breaks the rest of the header files as they are not copied to the
build directory.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-03-28 19:45:22 ---
Thomas,

There is no reason to apply this patch. version.h is has managed as all other
header files... I compiled and installed the library under linux/Mocos, and
windows without any problem...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philip Johnsson]

https://bugs.kde.org/show_bug.cgi?id=269511


Philip Johnsson <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Philip Johnsson <philip johnsson gmail com>  2011-03-31 13:44:16 ---
I get the same problems with libmediawiki building Digikam 2.0 beta4 using
cmake, make and make install without any package building tools on Kubuntu
10.10. The only header that gets installed to my building dir
(digikam-2.0.0-beta4/builddir/extra/libmediawiki/libmediawiki/) is version.h so
make install breaks with missing headers. All other headers are missing there.

-- Set runtime path of "/opt/digikam2/usr/lib/libmediawiki.so.1.0.0" to
"/opt/digikam2/usr/lib"
CMake Error at extra/libmediawiki/libmediawiki/cmake_install.cmake:76 (FILE):
  file INSTALL cannot find
 
"/media/sdd2/backup/download/source/done/digikam/digikam2/digikam-2.0.0-beta4/builddir/extra/libmediawiki/libmediawiki/image.h".
Call Stack (most recent call first):
  extra/libmediawiki/cmake_install.cmake:51 (INCLUDE)
  extra/cmake_install.cmake:43 (INCLUDE)
  cmake_install.cmake:37 (INCLUDE)

My guess is that anyone building and installing digikam directly from digikam
source code root and not using any staging directory for building does not get
this problem but if you use a special builddir like I do or package building
tools like pbuilder on debian you would also would get this problem.

Could this problem effect other parts of the build and install process or just
in this case?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-03-31 14:48:42 ---
Philip,

If libkdcraw, libkexiv2 and libkipi installation is fine, i will try to use the
same way with libmediawiki (which is a little bit different)

To test, i recommend to checkout code from git master, using this super
repository :

https://projects.kde.org/projects/extragear/graphics/digikam/digikam-software-compilation

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-03-31 14:57:45 ---
Git commit e3991d324061c6caa043193dad47a7df3ff58007 by Gilles Caulier.
Committed on 31/03/2011 at 15:00.
Pushed by cgilles into branch 'master'.

do not use a container to host header files list
CCBUGS: 269511

M  +25   -26   libmediawiki/CMakeLists.txt    

http://commits.kde.org/libmediawiki/e3991d324061c6caa043193dad47a7df3ff58007

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-03-31 14:58:06 ---
[root@localhost libmediawiki]# pwd
/mnt/data/Devel/GIT/2.x/extra/libmediawiki
[root@localhost libmediawiki]# make install
[  0%] Built target mediawiki_automoc
[100%] Built target mediawiki
[100%] Built target editSample_automoc
[100%] Built target editSample
[100%] Built target uploadSample_automoc
[100%] Built target uploadSample
Install the project...
-- Install configuration: "debugfull"                                          
-- Up-to-date: /usr/lib/pkgconfig/libmediawiki.pc
-- Up-to-date: /usr/share/apps/cmake/modules/FindMediawiki.cmake
-- Up-to-date: /usr/lib/libmediawiki.so.1.0.0
-- Up-to-date: /usr/lib/libmediawiki.so.1
-- Up-to-date: /usr/lib/libmediawiki.so
-- Up-to-date: /usr/include/libmediawiki/image.h
-- Up-to-date: /usr/include/libmediawiki/imageinfo.h
-- Up-to-date: /usr/include/libmediawiki/mediawiki.h
-- Up-to-date: /usr/include/libmediawiki/login.h
-- Up-to-date: /usr/include/libmediawiki/logout.h
-- Up-to-date: /usr/include/libmediawiki/queryimageinfo.h
-- Up-to-date: /usr/include/libmediawiki/queryimages.h
-- Up-to-date: /usr/include/libmediawiki/querysiteinfogeneral.h
-- Up-to-date: /usr/include/libmediawiki/generalinfo.h
-- Up-to-date: /usr/include/libmediawiki/querysiteinfousergroups.h
-- Up-to-date: /usr/include/libmediawiki/queryrevision.h
-- Up-to-date: /usr/include/libmediawiki/queryinfo.h
-- Up-to-date: /usr/include/libmediawiki/edit.h
-- Up-to-date: /usr/include/libmediawiki/job.h
-- Up-to-date: /usr/include/libmediawiki/usergroup.h
-- Up-to-date: /usr/include/libmediawiki/revision.h
-- Up-to-date: /usr/include/libmediawiki/page.h
-- Up-to-date: /usr/include/libmediawiki/parse.h
-- Up-to-date: /usr/include/libmediawiki/protection.h
-- Up-to-date: /usr/include/libmediawiki/upload.h
-- Up-to-date: /usr/include/libmediawiki/mediawiki_export.h
-- Up-to-date: /usr/include/libmediawiki/version.h

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #10 from Andreas K. Huettel <dilfridge gentoo org>  2011-03-31 15:02:09 ---
Gilles,
I have not checked yet if your fix works, but here is how to test it:
The difference is whether the cmake build is "in source" or "out of source".

In the release beta4, the above error came up only when doing an "out of
source" build (which is the Gentoo default). Switching to "in source build"
worked around the problem.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philip Johnsson]

https://bugs.kde.org/show_bug.cgi?id=269511





--- Comment #11 from Philip Johnsson <philip johnsson gmail com>  2011-03-31 15:06:51 ---
libkdcraw, libkexiv2 and libkipi installation is fine so it's just libmediawiki
that have this problem with installation of headers.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=269511

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=269511

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |general
            Product|digikam                     |libmediawiki
            Version|2.0.0                       |unspecified
           Assignee|[hidden email]       |[hidden email]
                   |                            |m

--
You are receiving this mail because:
You are the assignee for the bug.