[Bug 267777] New: Versioning not working properly when saving changes in the image editor

https://bugs.kde.org/show_bug.cgi?id=267777

           Summary: Versioning not working properly when saving changes in
                    the image editor
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Versioning
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.0)
OS:                Linux

Saving changes doesn't seem to work at all when closing the image editor and
choosing "Save as new version" from the popup dialog.

Choosing "Save changes" closes the editor, but it seems to create a new version
(although I didn't want to). When I edit the new version of the image, a "Save
changes" results in overwriting the versioned image (as expected).

Reproducible: Always

Steps to Reproduce:
1. Edit an image
2. Make some changes
3. Close the editor
4. Select "Save as new version"

Actual Results:  
Nothing happens, the editor doesn't close

Expected Results:  
Editor closes, a new version has been created for the edited image

OS: Linux (i686) release 2.6.37-ARCH
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-13 14:05:37 ---
Andi,

It still valid with 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #2 from Andi Clemens <andi clemens googlemail com>  2011-12-13 19:17:50 ---
I can't compile digiKam at the moment, since it (or Qt) is not working with the
new boost libraries. I will check this when I'm able to compile again.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #3 from Andi Clemens <andi clemens googlemail com>  2011-12-21 00:26:05 ---
I downgraded boost for now to be able to compile digiKam again.
It seems to be fixed now, I couldn't reproduce it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-12-21 07:13:35 ---
Downgraded to which version exactly ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #5 from Andi Clemens <andi clemens googlemail com>  2011-12-21 09:39:15 ---
I downgraded boost from 1.48.0 to 1.47.0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |287772




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2012-01-04 08:54:46 ---
Andi,

This entry depend of bug 287772

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2012-01-04 22:05:02 ---
Andi,

A developer have posted a patch to support boost 1.48 in the file :

https://bugs.kde.org/attachment.cgi?id=67460

Please, can you take a look if it compile fine on your computer and if
versioning work fine with this patch ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2012-01-05 11:42:02 ---
Andi,

patch have been updated to work with all boost version :

http://bugs.kde.org/attachment.cgi?id=67481

It work for you ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2012-01-06 10:26:51 ---
Git commit d18ea6da2d3e2359f4113e83c3fd40c18a29ddab by Gilles Caulier.
Committed on 06/01/2012 at 11:23.
Pushed by cgilles into branch 'master'.

Apply patch #67483 from Jeremiah Willcock to compile fine digiKam boost graph
interface with libboost 1.48
Related: bug 287772

M  +10   -8    libs/database/imagehistory/imagehistorygraph_boost.h

http://commits.kde.org/digikam/d18ea6da2d3e2359f4113e83c3fd40c18a29ddab

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2012-01-06 10:29:43 ---
Andi,

I apply patch from bug 287772 about boost compilation failure.

Please check if this entry still valid using current git/master implementation

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.0.0                       |2.5.0




--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2012-01-06 10:34:00 ---
Andi,

Note, all work fine for me with patch applied, using boost 1.46. I don't have
boost 1.47 and 1.48 to check versioning feature from image editor.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu]

https://bugs.kde.org/show_bug.cgi?id=267777


Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Veaceslav Munteanu <slavuttici gmail com>  2012-01-06 11:51:21 ---
I can't reproduce this bug with boost 1.47 or with boost 1.48.

My system is an ArchLinux with latest updates and latest git.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2012-01-06 12:12:42 ---
Thanks for the report. I can close this file now.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267777

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel