[Bug 267613] New: Lensfun doesn't work correctly with compact cameras

https://bugs.kde.org/show_bug.cgi?id=267613

           Summary: Lensfun doesn't work correctly with compact cameras
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.0)
OS:                Linux

Previously lensfun crashed when I was trying to apply any lens corrections in
any application (digikam, ufraw, darktable). I have compiled and installed
lensfun-0.2.5.1. Now automatic lens corrections work well with DSLR cameras,
but not with compact cameras. In darktable it works well with compacts too.

I see two problems with automatic lens correction realization in digikam. At
first, if you disable automatic camera identification, you can't select
standard lens for compact camera because there are only lenses for DSLR. This
is a problem for Canon DSLR too, because the list doesn't contain EF-S lenses.
However, if your camera is automatically identified, EF-S lenses are in the
list.
In darktable when I select a compact camera the lens list contains only few
lenses and one of them is "Standard".

The next problem is possibly connected only to Canon PowerShot S5 IS. This
camera is automatically identified and it's lens is set to "Standard". However,
the correction doesn't work correctly. The result is a small rounded image in
the center (something like fisheye). In darktable lens correction for the same
image works well.

I think the above problems are connected to digikam because in darktable and
ufraw lens corrections work well.

If you have any questions I'm ready to answer.

Reproducible: Always

Steps to Reproduce:
This problem is reproduced every time in digikam 1.8.0 - 2.0.0beta3

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |Lens Distortion
            Product|digikam                     |digikamimageplugins




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-03-04 11:32:06 ---
Can you provide some image to test here.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-03-04 11:33:21 ---
Do you use a shared version of lensfun library or do you use version of Lensfun
embeded  in digiKam core ? Go to Hellp/Components Info for details.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #3 from Sergey Salnikov <salsergey gmail com>  2011-03-04 11:55:26 ---
Created an attachment (id=57669)
 --> (http://bugs.kde.org/attachment.cgi?id=57669)
Photo taken with Canon PowerShot S5 IS

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #4 from Sergey Salnikov <salsergey gmail com>  2011-03-04 12:02:07 ---
The photo attached becomes rounded if I use automatic lens identification. If I
turn off automatic identification, I can't select "Standard" lens.
I have similar behavior with Canon EOS 60D and EF-S lenses. In this case
automatic correction works well. However, if I select camera manually, there
are no EF-S lenses in the list.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #5 from Sergey Salnikov <salsergey gmail com>  2011-03-04 12:04:25 ---
Digikam should use a shared version of lensfun. Help/Components gives no
information about lensfun.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-03-04 16:25:14 ---
Well, embeded version is current implementation from svn of lensfun. Please
recompile digiKam without to use an external Lensfun, which is really outdated
now, and include several and important fixes.

Note : Ask to Lensfun team to release a new version of the library soon...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=267613





--- Comment #7 from Sergey Salnikov <salsergey gmail com>  2011-03-04 17:00:50 ---
I can try to recompile digikam. However, it seems to me that the problem isn't
connected to lensfun. I have downloaded lensfun from svn about a month ago, so
it shouldn't be outdated. Also I have said that in darktable (which uses the
same lensfun) lens corrections work well with all images.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=267613


S. Burmeister <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from S. Burmeister <sven burmeister gmx net>  2011-03-05 08:57:04 ---
This bug is long known and a dup of bug 253941 using the internal lensfun
version does not make a difference.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roman I Khimov]

https://bugs.kde.org/show_bug.cgi?id=267613

Roman I Khimov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |312764

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/8b3eb6f0b498ae11729e088
                   |                            |0e7ac0673b2dd2bd8

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit 8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8 by Gilles Caulier.
Committed on 07/01/2013 at 11:16.
Pushed by cgilles into branch 'master'.

Apply patch #76254 from Roman I Khimov about lensfun interface which don't
mangle cropFactor if it's set.
This behaviour was introduced by polish commit
bebef401e147a00f859cb81774f8498a0623eee5.
With this branch present we always get cropFactor of
-1.0 in LensFunFilter::filterImage() and given that lensfun library just uses
crop factor of 1 which leads to obviously wrong calculations for cropped
cameras.
Related: bug 312764, bug 253941, bug 266204, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +0    -4    libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613

Bug 267613 depends on bug 312764, which changed state.

Bug 312764 Summary: [patch] Crop factor always set to -1.0 in lens correction
https://bugs.kde.org/show_bug.cgi?id=312764

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier.
Committed on 07/01/2013 at 11:34.
Pushed by cgilles into branch 'master'.

Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from
lens data.
Lens crop factor in DB only tells us which crop factor was used for lens
calibration data, but it has nothing to do with shots made on random user's
camera. So the default behaviour should be to use camera's crop factor and only
fallback to lens data if there in no data present for camera. As "this should
not happen" it's appropriate to spit out some debug message in this case.

Ref: http://lensfun.berlios.de/manual/el_lens.html
Ref: http://lensfun.berlios.de/manual/el_camera.html
Related: bug 312766, bug 312764, bug 253941, bug 266204, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +2    -1    libs/dimg/filters/lens/lensfuncameraselector.cpp
M  +1    -1    libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267613

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier.
Committed on 07/01/2013 at 11:39.
Pushed by cgilles into branch 'master'.

Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale
factor to lensfun.

Sixth parameter to Initialize() is actually a scale factor which has nothing
in common with crop factor. I think it's safe to assume that we want no
scaling from lensfun and thus use the value of one.

Ref: http://lensfun.berlios.de/manual/structlfModifier.html
Related: bug 312765, bug 312764, bug 253941, bug 266204, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +1    -1    libs/dimg/filters/lens/lensfunfilter.cpp

http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=267613

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Lens Distortion             |Tool-LensDistortion

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel