[Bug 266204] New: Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 266204] New: Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

           Summary: Inconsistent results with distortion correction
                    between digikam, lensfun tool (tmod) and ufraw
           Product: digikam
           Version: 1.8.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.8.0 (using KDE 4.5.5)
OS:                Linux

I'm having troubles using the distortion correction tool of digikam with my
Panasonic GF1 and the 20mm pancake lensfun.
There exists 2 lensfun parameter set to correct gf1/20mm images. One is
distributed in lensfun CVS and works pretty well with lensfun tmod tool. I made
the other which works relatively well with ufraw
(http://xraynaudphotos.free.fr/lensfun.php). For some strange reason, the ufraw
parameter set doesn't work with tmod and vice versa. This inconsistency between
 has already been filed at ufraw's bug system.
Unfortunately, none of these parameters sets appear to work with digikam which
corrects too much the distortion. Follows are 3 jpegs showing the corrections
* lensfun parameters corrected image:
http://xraynaudphotos.free.fr/temp/lensfun.jpg
* ufraw parameters corrected image:
http://xraynaudphotos.free.fr/temp/ufraw.jpg
* original raw file : http://xraynaudphotos.free.fr/temp/P1010941.RW2

I may do something wrong, but I don't know what.
Thanks for your help

Xavier.

Reproducible: Always

Steps to Reproduce:
open a panasonic gf1 (with 20mm lens) raw image, open distortion
auto-correction, select panasonic gf1 and 20mm lens, look at the results.

Actual Results:  
image corrected too heavilly

Expected Results:  
distortion corrected image

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=266204


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |Lens Distortion
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 19:04:18 ---
Xavier,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikamimageplugins] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Roman I Khimov
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

Roman I Khimov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |312764

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikamimageplugins] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/8b3eb6f0b498ae11729e088
                   |                            |0e7ac0673b2dd2bd8

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Git commit 8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8 by Gilles Caulier.
Committed on 07/01/2013 at 11:16.
Pushed by cgilles into branch 'master'.

Apply patch #76254 from Roman I Khimov about lensfun interface which don't
mangle cropFactor if it's set.
This behaviour was introduced by polish commit
bebef401e147a00f859cb81774f8498a0623eee5.
With this branch present we always get cropFactor of
-1.0 in LensFunFilter::filterImage() and given that lensfun library just uses
crop factor of 1 which leads to obviously wrong calculations for cropped
cameras.
Related: bug 312764, bug 253941, bug 267613, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +0    -4    libs/dimg/filters/lens/lensfuncameraselector.cpp

http://commits.kde.org/digikam/8b3eb6f0b498ae11729e0880e7ac0673b2dd2bd8

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikamimageplugins] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

Bug 266204 depends on bug 312764, which changed state.

Bug 312764 Summary: [patch] Crop factor always set to -1.0 in lens correction
https://bugs.kde.org/show_bug.cgi?id=312764

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikamimageplugins] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier.
Committed on 07/01/2013 at 11:34.
Pushed by cgilles into branch 'master'.

Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from
lens data.
Lens crop factor in DB only tells us which crop factor was used for lens
calibration data, but it has nothing to do with shots made on random user's
camera. So the default behaviour should be to use camera's crop factor and only
fallback to lens data if there in no data present for camera. As "this should
not happen" it's appropriate to spit out some debug message in this case.

Ref: http://lensfun.berlios.de/manual/el_lens.html
Ref: http://lensfun.berlios.de/manual/el_camera.html
Related: bug 312766, bug 312764, bug 253941, bug 267613, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +2    -1    libs/dimg/filters/lens/lensfuncameraselector.cpp
M  +1    -1    libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikamimageplugins] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

Gilles Caulier-4
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier.
Committed on 07/01/2013 at 11:39.
Pushed by cgilles into branch 'master'.

Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale
factor to lensfun.

Sixth parameter to Initialize() is actually a scale factor which has nothing
in common with crop factor. I think it's safe to assume that we want no
scaling from lensfun and thus use the value of one.

Ref: http://lensfun.berlios.de/manual/structlfModifier.html
Related: bug 312765, bug 312764, bug 253941, bug 267613, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +1    -1    libs/dimg/filters/lens/lensfunfilter.cpp

http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 266204] Inconsistent results with distortion correction between digikam, lensfun tool (tmod) and ufraw

bugzilla_noreply
In reply to this post by Bugzilla from xraynaud@gmail.com
https://bugs.kde.org/show_bug.cgi?id=266204

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Lens Distortion             |Tool-LensDistortion
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel