[Bug 265431] New: digikam cmake check for JPEG_LIB_VERSION fails for libjpeg-turbo >= 1.0.90

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431

           Summary: digikam cmake check for JPEG_LIB_VERSION fails for
                    libjpeg-turbo >= 1.0.90
           Product: digikam
           Version: unspecified
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=56861)
 --> (http://bugs.kde.org/attachment.cgi?id=56861)
one attempt to address this, using cmake try_compile instead of regex

Version:           unspecified (using KDE 4.6.0)
OS:                Linux

In newer versions of libjpeg-turbo (as is used in fedora), starting with
1.0.90, the definition of JPEB_LIB_VERSION has moved from jpeglib.h to
jconfig.h , which breaks with the current incarnation of cmake regex'ing coming
from bug #228483 and the following commit:
http://websvn.kde.org/?revision=1100511&view=revision

Reproducible: Always

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #1 from Rex Dieter <rdieter math unl edu>  2011-02-04 18:55:02 ---
If this approach is agreeable, a similar implementation could be used elsewhere
too (like kdegraphics/gwenview and corresponding bug #227313 ).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=265431


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Portability
            Version|unspecified                 |1.9.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #2 from Rex Dieter <rdieter math unl edu>  2011-02-04 19:22:33 ---
Created an attachment (id=56863)
 --> (http://bugs.kde.org/attachment.cgi?id=56863)
minimalistic approach, simply add content from jconfig.h too

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #3 from Rex Dieter <rdieter math unl edu>  2011-03-03 19:30:11 ---
Looks like my minimalistic version doesn't work, nvm that one.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dennis Veatch-2]

https://bugs.kde.org/show_bug.cgi?id=265431


Dennis veatch <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Dennis veatch <dennisveatch bellsouth net>  2011-04-19 10:31:26 ---
This also causes the kdegraphics-4.6.2 make to fail with libjpeg-turbo-1.1.0
but kdegraphics is fine with 1.0.1.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=265431


Riccardo Iaconelli <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Riccardo Iaconelli <riccardo kde org>  2011-05-10 11:06:36 ---
ping! any news on the porting to libjpeg-turbo?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #6 from Rex Dieter <rdieter math unl edu>  2011-05-12 14:56:32 ---
OK, I've been using the try_compile patch variant for awhile.  that seems
safest to me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431


Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56863|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #7 from Riccardo Iaconelli <riccardo kde org>  2011-05-12 20:00:42 ---
can we merge it then? I can do it if you want (test included). Gilles?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #8 from Rex Dieter <rdieter math unl edu>  2011-05-12 20:08:07 ---
Fwiw, there's a similar/copied check in kdegraphics/gwenview too

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-05-12 20:14:24 ---
If something similar have been done to Gwenview, why to re-invent the wheel. If
Gwenview sometion have been test, it must be adapted to digiKam as well...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #10 from Rex Dieter <rdieter math unl edu>  2011-05-12 20:17:29 ---
Sorry, I meant that gwenview has the same problem here that digikam has.  They
are both broken wrt libjpeg-turbo.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #11 from Riccardo Iaconelli <riccardo kde org>  2011-05-13 11:05:19 ---
so... do I have green light?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=265431





--- Comment #12 from Rex Dieter <rdieter math unl edu>  2011-05-13 19:50:25 ---
fyi, tracking gwenview elsewhere in bug #273217

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=265431


Riccardo Iaconelli <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Riccardo Iaconelli <riccardo kde org>  2011-05-15 16:20:15 ---
Git commit 1ad9ae102ea1a82a72e31401fe840954a791219f by Riccardo Iaconelli.
Committed on 15/05/2011 at 16:18.
Pushed by ruphy into branch 'master'.

Don't fail CMake check: compile with libjpeg-turbo

Patch by Rex Dieter

BUG: 265431

Signed-off-by: Riccardo Iaconelli <[hidden email]>

M  +17   -11   CMakeLists.txt    

http://commits.kde.org/digikam/1ad9ae102ea1a82a72e31401fe840954a791219f

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=265431

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=265431

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.