[Bug 262175] New: The widget to select names is not large enough

https://bugs.kde.org/show_bug.cgi?id=262175

           Summary: The widget to select names is not large enough
           Product: digikam
           Version: 2.0.0
          Platform: Unlisted Binaries
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: NOR
         Component: Face Detection
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0
OS:                Linux

The widget to select names is not large enough, if the face is small I can not
see the label saying that the tag will be created in People or just a tag.

Maybe Create New Tag "toto" in People should be Create New Name "toto" to save
some screen space ?

Julien

Reproducible: Sometimes

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-01-05 15:26:50 ---
In preview view or icon view?
Width or height is not enough?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #2 from Julien Narboux <Julien narboux fr>  2011-01-05 15:34:21 ---
In preview view the width is not enough.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-02-05 23:59:32 ---
Git commit 13c21397e857463a64dea631045ae57cbbbca7dd by Marcel Wiesweg.
Committed on 05/02/11 at 23:50.
Pushed by mwiesweg into branch 'development/2.0'.

Shorten the text from "Create new tag <...>" to "Create <...>", to avoid
cutting the tag name

CCBUG: 262175

M  +2    -2    digikam/addtagscompletionbox.cpp    

http://commits.kde.org/digikam/13c21397e857463a64dea631045ae57cbbbca7dd

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #4 from Julien Narboux <Julien narboux fr>  2011-04-19 11:30:20 ---
Created an attachment (id=59126)
 --> (http://bugs.kde.org/attachment.cgi?id=59126)
The widget width is too small

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #5 from Julien Narboux <Julien narboux fr>  2011-04-19 11:30:58 ---
The width using current git trunk is still too small, i can only see the word
"Create".

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-24 19:27:05 ---
Created an attachment (id=59280)
 --> (http://bugs.kde.org/attachment.cgi?id=59280)
Debug statements

There is code to calculate the needed width from the contents in the combobox.
For me, the box usually exceeds the width of the line edit. In your screenshot
it ends at about 50%.

The attached patch could give some information about what may be wrong. The
output is produced when you type a letter in the line edit and autocompletion
begins.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=262175


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-07-03 15:47:36 ---
Julien,

Do you take a look about marcel patch to progress in investiguations ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-12-14 13:57:59 ---
Julien

Do you see my comment #7 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #9 from Andi Clemens <andi clemens googlemail com>  2011-12-26 10:35:56 ---
This bug is still valid, the widget is too small, the problem for me is the
height of the line edit field,I need magnifying glasses to see it :-)

I know the widget is painted over the delegate, so this might not work, but
couldn't this widget be wider than the thumbanil?

The problem is that if you define an even smaller thumbnail size, it is not
visible at all.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #10 from Andi Clemens <andi clemens googlemail com>  2011-12-26 10:42:54 ---
Created an attachment (id=67122)
 --> (http://bugs.kde.org/attachment.cgi?id=67122)
tagging widget too small

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-12-26 21:53:44 ---
See how the height is kept properly even at minimal thumbnail size on my
system:
http://wstaw.org/m/2011/12/26/plasma-desktopWp1762.jpg

Why does it work here and not for you?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2011-12-26 21:56:37 ---
Marcel,

This depend of widget style used with digiKam. Under MACOSX, It's a nightmare
with Qt mac widget style.

Go to Setup/Misc/Widget Style, and try with another one...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262175





--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-12-26 21:59:49 ---
Ok, I got it: I have switched on to display quite a few items below the
picture. If I switch off everything, no widget is visible at all...
Apparently, the placement and size adjustment of the overlay can be improved.
This also applies to the grouping icon which you mentioned in another bug
report. This opens a whole lot of problems to consider.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=262175

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.2.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/0e6d4d7f0fb5303ccbcacd4
                   |                            |9f3b058d5bd424d52
             Status|CONFIRMED                   |RESOLVED

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Git commit 0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52 by Gilles Caulier.
Committed on 15/07/2014 at 07:46.
Pushed by cgilles into branch 'master'.

Do not use a Qwidget as container of AssignNameWidget. This break layout with
non Oxgen widget style (fully reproducible under OSX)
Set argin a spacing to 1 pixel into AssignNameWidget layout.
constify and polish implementations
FIXED-IN: 4.2.0

M  +41   -39   digikam/items/assignnameoverlay.cpp
M  +16   -15   digikam/items/assignnameoverlay.h
M  +3    -1    utilities/facemanagement/assignnamewidget.cpp

http://commits.kde.org/digikam/0e6d4d7f0fb5303ccbcacd49f3b058d5bd424d52

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel